From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Subject: Re: [PATCH] coccinelle: api: detect duplicate chip data arrays Date: Thu, 5 Oct 2017 21:58:23 +0200 (CEST) Message-ID: References: <1506861768-5734-1-git-send-email-Julia.Lawall@lip6.fr> <1507230959.4434.39.camel@perches.com> <1507231856.4434.41.camel@perches.com> <1507233265.4434.45.camel@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Return-path: Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:6753 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751393AbdJET63 (ORCPT ); Thu, 5 Oct 2017 15:58:29 -0400 In-Reply-To: <1507233265.4434.45.camel@perches.com> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Joe Perches Cc: Liam Breck , Masahiro Yamada , Sebastian Reichel , =?ISO-8859-15?Q?Pali_Roh=E1r?= , Linux PM mailing list , kernel-janitors@vger.kernel.org, Gilles Muller , Nicolas Palix , cocci@systeme.lip6.fr, Linux Kernel Mailing List , kbuild test robot On Thu, 5 Oct 2017, Joe Perches wrote: > On Thu, 2017-10-05 at 12:46 -0700, Liam Breck wrote: > > Hi Joe, > > > > On Thu, Oct 5, 2017 at 12:30 PM, Joe Perches wrote: > > > On Thu, 2017-10-05 at 21:19 +0200, Julia Lawall wrote: > > > > On Thu, 5 Oct 2017, Joe Perches wrote: > > > > > On Thu, 2017-10-05 at 21:13 +0200, Julia Lawall wrote: > > > > > > On Fri, 6 Oct 2017, Masahiro Yamada wrote: > > > > > > > 2017-10-01 21:42 GMT+09:00 Julia Lawall : > > > > > > > > This semantic patch detects duplicate arrays declared using BQ27XXX_DATA > > > > > > > > within a single structure. It is currently specific to the file > > > > > > > > drivers/power/supply/bq27xxx_battery.c. > > > > > > > > Signed-off-by: Julia Lawall > > > > > > > > > > > > > > Applied to linux-kbuild/misc. > > > > > > > > > > > > Thanks for picking it up. > > > > > > > > > > If it is specific to one file, why not just run it > > > > > and post the resultant patch? Why have it in tree? > > > > > > > > I guess that they anticipate that the data may change in the future? > > > > > > Aren't you the script author Julia? Who is the "they"? > > > > > > I think having a script for a single file unnecessary. > > > > Sebastian Reichel, the power-supply maintainer, requested this script. > > I previously implemented this as a run-time check within ifdef DEBUG, > > but that was rejected. > > Hi Liam. > > If you are the author of the script, you should also have > a sign-off/from here right? > > This also has a copyright of Inria and Julia Lawall > which, if you are the author, doesn't seem appropriate. I am the author. Liam and Sebastian asked for it to be done and to be put into the kernel. julia