Linux Power Management development
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: TimGuo <timguo_via@aliyun.com>
Cc: mingo@redhat.com, hpa@zytor.com, x86@kernel.org,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	brucechang@via-alliance.com, benjaminpan@viatech.com,
	cooperyan@zhaoxin.com, qiyuanwang@zhaoxin.com
Subject: Re: [PATCH] This patch is used ... [trimmed overly long subject]
Date: Sat, 25 Nov 2017 00:41:43 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.20.1711250032250.2316@nanos> (raw)
In-Reply-To: <1511483521-7264-1-git-send-email-timguo_via@aliyun.com>

Tim,

Your patch looks good, but your patch description needs some care:

Please do not write full sentences in the subject line. The subject line
should be a short and precise information about the patch. The format is:

       [PATCH] subsystem: Short precise description.

in this case:

       [PATCH] x86/centaur: Mark TSC invariant

Then you add a decsription of the change in the body of the mail. Please
avoid wording like 'This patch does ...'. We already know that this is a
patch and the description should be more focussed on the WHY than on the
WHAT. The WHAT can be seen from the patch itself, but the WHY is the
information which is not in the code.

See also Documentation/process/submitting-patches.rst

Thanks,

	tglx

           reply	other threads:[~2017-11-24 23:41 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1511483521-7264-1-git-send-email-timguo_via@aliyun.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1711250032250.2316@nanos \
    --to=tglx@linutronix.de \
    --cc=benjaminpan@viatech.com \
    --cc=brucechang@via-alliance.com \
    --cc=cooperyan@zhaoxin.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=qiyuanwang@zhaoxin.com \
    --cc=timguo_via@aliyun.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox