Linux Power Management development
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: TimGuo <timguo_via@aliyun.com>
Cc: mingo@redhat.com, hpa@zytor.com, mingo@kernel.org,
	x86@kernel.org, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org, brucechang@via-alliance.com,
	benjaminpan@viatech.com, cooperyan@zhaoxin.com,
	qiyuanwang@zhaoxin.com
Subject: Re: [PATCH v2] x86/centaur: Mark TSC invariant
Date: Thu, 28 Dec 2017 12:12:12 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.20.1712281206140.1688@nanos> (raw)
In-Reply-To: <1511765383-2755-1-git-send-email-timguo_via@aliyun.com>

On Mon, 27 Nov 2017, TimGuo wrote:

> During the FIO benchmark for block device, we found there are lots of clocksource
> access. TSC access latency is much lower than HPET. Use TSC as clocksource can improve 
> the FIO benchmark result.
>  
> 
> changes from v1 to v2:
> ---------------------
> Adjust the subject and description of this patch according to tglx's suggestion.

Well, the subject makes sense. The changelog not so much.

It's completely irrelevant whether you run a FIO benchmark or something
different.

What's relevant is that the CPU has a constant frequency TSC and that TSC
does not stop in C-States. But because the flags are not set for that CPU
the TSC is treated as non constant frequency and assumed to stop in
C-States, which makes it an unreliable and unusable clock source.

Setting those flags tells the kernel that the TSC is usable, so it will
select it over HPET. The effect of this is that reading time stamps (from
kernel or user space) will be faster and more efficient.

Thanks,

	tglx

           reply	other threads:[~2017-12-28 11:12 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1511765383-2755-1-git-send-email-timguo_via@aliyun.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1712281206140.1688@nanos \
    --to=tglx@linutronix.de \
    --cc=benjaminpan@viatech.com \
    --cc=brucechang@via-alliance.com \
    --cc=cooperyan@zhaoxin.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=mingo@redhat.com \
    --cc=qiyuanwang@zhaoxin.com \
    --cc=timguo_via@aliyun.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox