From: Julia Lawall <julia.lawall@lip6.fr>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Wen Yang <wen.yang99@zte.com.cn>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Viresh Kumar <viresh.kumar@linaro.org>,
Yi Wang <wang.yi59@zte.com.cn>
Subject: Re: [PATCH 7/7] cpufreq: ppc_cbe: fix possible object reference leak
Date: Tue, 2 Apr 2019 12:50:23 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1904021249500.3297@hadrien> (raw)
In-Reply-To: <efe8fb3a-eb4a-a50a-c53a-0879a912fbd8@web.de>
[-- Attachment #1: Type: text/plain, Size: 728 bytes --]
On Tue, 2 Apr 2019, Markus Elfring wrote:
> > The call to of_get_cpu_node returns a node pointer with refcount
> > incremented thus it must be explicitly decremented after the last
> > usage.
>
> I would prefer a wording like the following.
>
> A reference counter was incremented for a CPU node by a call of
> the function “of_get_cpu_node”.
> Thus decrement it after the last usage.
The original log message seems perfectly clear.
>
>
> > Detected by coccinelle with the following warnings:
>
> I wonder about the shown duplicate notification.
> Can a single message be sufficient for the code search result
> in this source file?
Since you have removed the context, I have no idea what you are talking
about.
julia
next prev parent reply other threads:[~2019-04-02 10:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1554082674-2049-1-git-send-email-wen.yang99@zte.com.cn>
2019-04-01 1:37 ` [PATCH 1/7] cpufreq: ap806: fix possible object reference leak Wen Yang
2019-04-02 13:54 ` [1/7] cpufreq: ap806: Checking implementation of armada_8k_cpufreq_init() Markus Elfring
2019-04-02 13:54 ` Markus Elfring
2019-04-08 10:21 ` [PATCH 1/7] cpufreq: ap806: fix possible object reference leak Viresh Kumar
2019-04-08 10:21 ` Viresh Kumar
2019-04-01 1:37 ` [PATCH 2/7] cpufreq: imx6q: " Wen Yang
2019-04-01 1:37 ` [PATCH 3/7] cpufreq: kirkwood: " Wen Yang
2019-04-03 13:17 ` [3/7] " Markus Elfring
2019-04-01 1:37 ` [PATCH 5/7] cpufreq/pasemi: " Wen Yang
2019-04-03 14:23 ` [5/7] cpufreq/pasemi: Checking implementation of pas_cpufreq_cpu_init() Markus Elfring
2019-04-03 15:31 ` Dan Carpenter
2019-04-01 1:37 ` [PATCH 6/7] cpufreq: pmac32: fix possible object reference leak Wen Yang
2019-04-01 1:37 ` [PATCH 7/7] cpufreq: ppc_cbe: " Wen Yang
2019-04-02 10:43 ` Markus Elfring
2019-04-02 10:50 ` Julia Lawall [this message]
2019-04-02 12:50 ` Markus Elfring
2019-04-02 13:15 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1904021249500.3297@hadrien \
--to=julia.lawall@lip6.fr \
--cc=Markus.Elfring@web.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
--cc=wang.yi59@zte.com.cn \
--cc=wen.yang99@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox