From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A27EC432C0 for ; Mon, 25 Nov 2019 05:50:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 72B942071A for ; Mon, 25 Nov 2019 05:50:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725497AbfKYFuR (ORCPT ); Mon, 25 Nov 2019 00:50:17 -0500 Received: from mailbackend.panix.com ([166.84.1.89]:35975 "EHLO mailbackend.panix.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725468AbfKYFuR (ORCPT ); Mon, 25 Nov 2019 00:50:17 -0500 Received: from hp-x360n (c-73-241-154-233.hsd1.ca.comcast.net [73.241.154.233]) by mailbackend.panix.com (Postfix) with ESMTPSA id 47Lx2b0jPYz1Hsv; Mon, 25 Nov 2019 00:50:14 -0500 (EST) Date: Sun, 24 Nov 2019 21:50:13 -0800 (PST) From: "Kenneth R. Crudup" Reply-To: "Kenneth R. Crudup" To: "Rafael J. Wysocki" cc: Rafael Wysocki , Linux PM Subject: Re: Help me fix a regression caused by 56b9918490 (PM: sleep: Simplify suspend-to-idle control flow) In-Reply-To: Message-ID: References: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Sun, 24 Nov 2019, Rafael J. Wysocki wrote: > Well, because you identified 56b991849 as the first bad commit, the > following three lines of code in drivers/acpi/sleep.c are likely to be > the source of the problem: > > acpi_os_wait_events_complete(); /* synchronize EC GPE processing */ > acpi_ec_flush_work(); > acpi_os_wait_events_complete(); /* synchronize Notify handling */ Huh- so this is encouraging- I've removed these lines, and while I haven't been able to kill it yet (give me time :)) what DOES happen now is I get wakeups from sleep on POWER events- charger connect (and disconnect)- and now I wonder if this is somehow related to the issue of the suspend not resuming if the machine is charging? Are we masking out any events, perhaps? -Kenny -- Kenneth R. Crudup Sr. SW Engineer, Scott County Consulting, Silicon Valley