From: Julia Lawall <julia.lawall@inria.fr>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Doug Smythies <dsmythies@telus.net>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Len Brown <lenb@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Viresh Kumar <viresh.kumar@linaro.org>,
Linux PM list <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: problem in changing from active to passive mode
Date: Fri, 29 Oct 2021 22:29:25 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2110292227540.3011@hadrien> (raw)
In-Reply-To: <CAJZ5v0ijM9V2UmgqM4FzckXA8SQy6pHpBTFm8LLv1Lp_L8JiLw@mail.gmail.com>
On Fri, 29 Oct 2021, Rafael J. Wysocki wrote:
> On Thu, Oct 28, 2021 at 10:18 PM Julia Lawall <julia.lawall@inria.fr> wrote:
> >
> >
> >
> > On Thu, 28 Oct 2021, Rafael J. Wysocki wrote:
> >
> > > On Thu, Oct 28, 2021 at 9:25 PM Julia Lawall <julia.lawall@inria.fr> wrote:
>
> [cut]
>
> > > Attached is a patch to do that, but please note that the 5.9 will need
> > > to be patched too to address this issue.
> >
> > I'm not completely clear on what the new patch is doing and how I should
> > test it. If I stay in 5.15, the original patch worked for clearing des
> > when going from passive to active.
>
> Sorry for the confusion.
>
> If applied to 5.15-rc alone, the last patch would cause des to be
> cleared when switching from passive to active and if applied to both
> 5.15-rc and 5.9, it would fix the kexec issue as well.
>
> Never mind, though.
>
> The patch attached to this message should cause des to be cleared when
> switching from passive to active (because it is based on the previous
> patch doing that) and it should prevent nonzero des from being leaked
> via the HWP_REQUEST MSR to the new kernel started via kexec. With
> this patch applied to 5.15-rc des should be 0 when switching from
> passive to active and it should also be 0 after starting another
> kernel via kexec while intel_pstate is running in the passive mode.
>
> Can you please verify that it works as expected?
I booted 5.15 rc6 in active then changed to passive making the des field
non zero, and then changed back to active, making it 0 again. I them
changed again to passive and kexeced 5.9. The des field was again 0.
So it looks fine.
thanks,
julia
prev parent reply other threads:[~2021-10-29 20:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-24 13:02 problem in changing from active to passive mode Julia Lawall
2021-10-24 22:44 ` Doug Smythies
2021-10-25 5:17 ` Julia Lawall
2021-10-25 20:49 ` Julia Lawall
[not found] ` <alpine.DEB.2.22.394.2110261658440.3825@hadrien>
2021-10-27 15:10 ` Doug Smythies
2021-10-27 15:16 ` Julia Lawall
2021-10-28 17:10 ` Julia Lawall
2021-10-28 17:29 ` Rafael J. Wysocki
2021-10-28 17:57 ` Rafael J. Wysocki
2021-10-28 18:16 ` Rafael J. Wysocki
2021-10-28 18:43 ` Rafael J. Wysocki
2021-10-28 19:13 ` Julia Lawall
2021-10-28 19:21 ` Rafael J. Wysocki
2021-10-28 19:25 ` Julia Lawall
2021-10-28 19:48 ` Rafael J. Wysocki
2021-10-28 20:18 ` Julia Lawall
2021-10-29 15:39 ` Rafael J. Wysocki
2021-10-29 20:29 ` Julia Lawall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2110292227540.3011@hadrien \
--to=julia.lawall@inria.fr \
--cc=dsmythies@telus.net \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox