public inbox for linux-pm@vger.kernel.org
 help / color / mirror / Atom feed
From: Len Brown <lenb@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-acpi@vger.kernel.org,
	Linux Power Management List <linux-pm@lists.osdl.org>
Subject: Re: [GIT PATCH] ACPI patches for 2.6.26-rc5
Date: Wed, 11 Jun 2008 23:08:17 -0400 (EDT)	[thread overview]
Message-ID: <alpine.LFD.1.10.0806112301570.12191@localhost.localdomain> (raw)
In-Reply-To: <alpine.LFD.1.10.0806111718240.3101@woody.linux-foundation.org>



> >  27 files changed, 255 insertions(+), 180 deletions(-)
> 
> Hmm. I get very different statistics:
> 
>  27 files changed, 434 insertions(+), 359 deletions(-)
> 
> You seem to use "git diff -w" to ignore whitespace changes, which explains 
> it, but please don't - it makes it harder to compare with expected 
> results, and it hides some changes entirely.
> 
> I do agree that using '-w' is often useful, but especially for the purpose 
> of letting people know what changed it kind of avoids the point by hiding 
> many things.

Yes, I've been using "-b" recently:

git diff -b -M --stat linus..$RELEASE

and if I remove the "-b", we match:

 27 files changed, 434 insertions(+), 359 deletions(-)

I have a vague memory of having a good reason to cut over to "-b"
a while back and noting that in my pull request, but if you prefer
no -b, no problem.

thanks,
-Len

  reply	other threads:[~2008-06-12  3:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <alpine.LFD.1.10.0806111942510.12191@localhost.localdomain>
2008-06-12  0:24 ` [GIT PATCH] ACPI patches for 2.6.26-rc5 Linus Torvalds
2008-06-12  3:08   ` Len Brown [this message]
2008-06-12  5:31 ` Vegard Nossum
2008-06-12  5:37   ` Vegard Nossum
2008-06-11 23:44 Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.1.10.0806112301570.12191@localhost.localdomain \
    --to=lenb@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.osdl.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox