From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: [RFC][PATCH 2/4] PM: Change suspend code ordering Date: Mon, 2 Mar 2009 12:48:00 -0800 (PST) Message-ID: References: <200902221837.49396.rjw@sisk.pl> <200903012321.40328.rjw@sisk.pl> <200903012325.53084.rjw@sisk.pl> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <200903012325.53084.rjw@sisk.pl> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.linux-foundation.org Errors-To: linux-pm-bounces@lists.linux-foundation.org To: "Rafael J. Wysocki" Cc: Jeremy Fitzhardinge , LKML , Jesse Barnes , Johannes Berg , Thomas Gleixner , "Eric W. Biederman" , Ingo Molnar , pm list List-Id: linux-pm@vger.kernel.org On Sun, 1 Mar 2009, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > Change the ordering of the suspend core code so that the platform > "prepare" callback is executed and the nonboot CPUs are disabled > after calling device drivers' "late suspend" methods. Ok, ack on this whole series, looks fine. I'd like to see a 5/4 though: > This change will allow us to rework the PCI PM core so that the power > state of devices is changed in the "late" phase of suspend (and > analogously in the "early" phase of resume) .. doing this. Right now we have that hacky "avoid ACPI by doing a special limited form of pci_set_power_state() and pci_enable() in the early_resume. I'd love to see the actual PCI code cleanup too. Linus