From: Linus Torvalds <torvalds@linux-foundation.org>
To: Oliver Neukum <oliver@neukum.org>
Cc: Greg KH <gregkh@suse.de>, Marcel Holtmann <marcel@holtmann.org>,
Mike Galbraith <efault@gmx.de>,
LKML <linux-kernel@vger.kernel.org>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
Oleg Nesterov <oleg@redhat.com>,
linux-bluetooth@vger.kernel.org,
pm list <linux-pm@lists.linux-foundation.org>,
Tejun Heo <tj@kernel.org>, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: GPF in run_workqueue()/list_del_init(cwq->worklist.next) on resume (was: Re: Help needed: Resume problems in 2.6.32-rc, perhaps related to preempt_count leakage in keventd)
Date: Wed, 11 Nov 2009 13:38:08 -0800 (PST) [thread overview]
Message-ID: <alpine.LFD.2.01.0911111335410.31845@localhost.localdomain> (raw)
In-Reply-To: <200911112213.30673.oliver@neukum.org>
On Wed, 11 Nov 2009, Oliver Neukum wrote:
>
> Yes, btusb_close() needs to cancel the waker workqueue, too.
> In addition, in order to avoid a memory leak it must call
> usb_scuttle_anchored_urbs(&data->deferred)
> to make sure any deferred data is destroyed.
Ok. I committed the one-liner patch to fix the oops (confirmed by Rafael),
but I'm leaving the memory leak for you as I'm not going to commit some
untested patch at this stage.
Thanks to everybody involved, I was personally very nervous that this was
something much more fundamental (we've had some scary bugs during the
32-rc series), and am relieved that it was "just" a silly driver bug.
Linus
next prev parent reply other threads:[~2009-11-11 21:38 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-09 11:50 Help needed: Resume problems in 2.6.32-rc, perhaps related to preempt_count leakage in keventd Rafael J. Wysocki
2009-11-09 12:02 ` Ingo Molnar
[not found] ` <20091109120217.GB18399@elte.hu>
2009-11-09 12:24 ` Rafael J. Wysocki
[not found] ` <200911091324.37955.rjw@sisk.pl>
2009-11-09 12:49 ` Ingo Molnar
2009-11-09 14:02 ` Thomas Gleixner
[not found] ` <alpine.LFD.2.00.0911091452300.2725@localhost.localdomain>
2009-11-09 14:16 ` Mike Galbraith
2009-11-09 14:26 ` Rafael J. Wysocki
[not found] ` <1257776176.6365.8.camel@marge.simson.net>
2009-11-09 14:27 ` Rafael J. Wysocki
2009-11-09 14:30 ` Mike Galbraith
[not found] ` <1257777040.6365.15.camel@marge.simson.net>
2009-11-09 15:47 ` Rafael J. Wysocki
[not found] ` <200911091647.54171.rjw@sisk.pl>
2009-11-09 16:19 ` Mike Galbraith
[not found] ` <1257783553.6408.6.camel@marge.simson.net>
2009-11-09 17:36 ` Rafael J. Wysocki
[not found] ` <200911091836.30349.rjw@sisk.pl>
2009-11-09 18:50 ` Thomas Gleixner
2009-11-09 19:13 ` Thomas Gleixner
[not found] ` <alpine.LFD.2.00.0911091949500.2725@localhost.localdomain>
2009-11-09 20:00 ` Rafael J. Wysocki
[not found] ` <200911092100.58187.rjw@sisk.pl>
2009-11-09 20:31 ` Alan Stern
2009-11-09 20:45 ` GPF in run_workqueue()/list_del_init(cwq->worklist.next) on resume (was: Re: Help needed: Resume problems in 2.6.32-rc, perhaps related to preempt_count leakage in keventd) Rafael J. Wysocki
[not found] ` <200911092145.27485.rjw@sisk.pl>
2009-11-09 21:42 ` Linus Torvalds
2009-11-10 0:19 ` Rafael J. Wysocki
[not found] ` <200911100119.38019.rjw@sisk.pl>
2009-11-10 22:02 ` Linus Torvalds
2009-11-11 8:08 ` GPF in run_workqueue()/list_del_init(cwq->worklist.next) on resume Tejun Heo
2009-11-11 11:52 ` GPF in run_workqueue()/list_del_init(cwq->worklist.next) on resume (was: Re: Help needed: Resume problems in 2.6.32-rc, perhaps related to preempt_count leakage in keventd) Rafael J. Wysocki
2009-11-11 16:13 ` Oleg Nesterov
2009-11-11 17:17 ` Oleg Nesterov
[not found] ` <4AFA70FB.60706@kernel.org>
2009-11-11 18:13 ` GPF in run_workqueue()/list_del_init(cwq->worklist.next) on resume Oleg Nesterov
[not found] ` <20091111181349.GA30638@redhat.com>
2009-11-12 4:56 ` Tejun Heo
[not found] ` <4AFB9595.1030002@kernel.org>
2009-11-12 18:35 ` Oleg Nesterov
[not found] ` <20091112183508.GA14661@redhat.com>
2009-11-12 19:14 ` Tejun Heo
2009-11-16 11:01 ` Tejun Heo
[not found] ` <200911111252.48214.rjw@sisk.pl>
2009-11-11 19:52 ` GPF in run_workqueue()/list_del_init(cwq->worklist.next) on resume (was: Re: Help needed: Resume problems in 2.6.32-rc, perhaps related to preempt_count leakage in keventd) Linus Torvalds
2009-11-11 20:18 ` Marcel Holtmann
[not found] ` <1257970719.21467.4.camel@violet>
2009-11-11 20:25 ` Linus Torvalds
2009-11-11 21:18 ` Rafael J. Wysocki
2009-11-11 21:13 ` Oliver Neukum
[not found] ` <200911112213.30673.oliver@neukum.org>
2009-11-11 21:38 ` Linus Torvalds [this message]
2009-11-11 21:44 ` Oliver Neukum
[not found] ` <20091111161348.GA27394@redhat.com>
2009-11-11 20:00 ` Rafael J. Wysocki
[not found] ` <200911112100.16561.rjw@sisk.pl>
2009-11-11 20:11 ` Linus Torvalds
[not found] ` <alpine.LFD.2.01.0911111202490.31845@localhost.localdomain>
2009-11-11 20:20 ` Marcel Holtmann
2009-11-11 20:24 ` Oleg Nesterov
[not found] ` <20091111202433.GA5714@redhat.com>
2009-11-11 21:15 ` Oliver Neukum
[not found] ` <20091111171703.GA28506@redhat.com>
2009-11-12 17:33 ` Thomas Gleixner
[not found] ` <alpine.LFD.2.00.0911121821370.24119@localhost.localdomain>
2009-11-12 19:17 ` GPF in run_workqueue()/list_del_init(cwq->worklist.next) on resume Tejun Heo
2009-11-12 20:53 ` GPF in run_workqueue()/list_del_init(cwq->worklist.next) on resume (was: Re: Help needed: Resume problems in 2.6.32-rc, perhaps related to preempt_count leakage in keventd) Rafael J. Wysocki
[not found] ` <4AFC5F2E.9040709@kernel.org>
2009-11-12 20:53 ` GPF in run_workqueue()/list_del_init(cwq->worklist.next) on resume Thomas Gleixner
[not found] ` <200911122153.12419.rjw@sisk.pl>
2009-11-12 20:55 ` GPF in run_workqueue()/list_del_init(cwq->worklist.next) on resume (was: Re: Help needed: Resume problems in 2.6.32-rc, perhaps related to preempt_count leakage in keventd) Thomas Gleixner
[not found] ` <alpine.LFD.2.00.0911122153320.24119@localhost.localdomain>
2009-11-12 22:55 ` Rafael J. Wysocki
[not found] ` <200911122355.11675.rjw@sisk.pl>
2009-11-12 23:08 ` Thomas Gleixner
2009-11-15 23:37 ` Frederic Weisbecker
[not found] ` <20091115233703.GA6090@nowhere>
2009-11-15 23:40 ` Frederic Weisbecker
[not found] ` <alpine.LFD.2.00.0911092012340.2725@localhost.localdomain>
2009-11-09 20:03 ` Help needed: Resume problems in 2.6.32-rc, perhaps related to preempt_count leakage in keventd Rafael J. Wysocki
[not found] ` <200911091526.02147.rjw@sisk.pl>
2009-11-09 14:44 ` Mike Galbraith
[not found] ` <1257777896.6365.21.camel@marge.simson.net>
2009-11-09 15:47 ` Rafael J. Wysocki
2009-11-09 15:57 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.01.0911111335410.31845@localhost.localdomain \
--to=torvalds@linux-foundation.org \
--cc=efault@gmx.de \
--cc=gregkh@suse.de \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=marcel@holtmann.org \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
--cc=oliver@neukum.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox