public inbox for linux-pm@vger.kernel.org
 help / color / mirror / Atom feed
From: Len Brown <lenb@kernel.org>
To: stable@kernel.org
Cc: linux-pm@lists.linux-foundation.org
Subject: [PATCH 2/2 2.6.37.stable] intel_idle: disable Atom/Lincroft HW C-state auto-demotion
Date: Tue, 22 Mar 2011 22:26:59 -0400 (EDT)	[thread overview]
Message-ID: <alpine.LFD.2.02.1103222224530.10489@x980> (raw)
In-Reply-To: <alpine.LFD.2.02.1103222222490.10489@x980>

From: Len Brown <len.brown@intel.com>

upstream bfb53ccf1c734b1907df7189eef4c08489827951

Just as we had to disable auto-demotion for NHM/WSM,
we need to do the same for Atom (Lincroft version).

In particular, auto-demotion will prevent Lincroft
from entering the S0i3 idle power saving state.

https://bugzilla.kernel.org/show_bug.cgi?id=25252

Signed-off-by: Len Brown <len.brown@intel.com>
---
 arch/x86/include/asm/msr-index.h |    1 +
 drivers/idle/intel_idle.c        |    4 ++++
 2 files changed, 5 insertions(+), 0 deletions(-)

Index: linux-2.6.37.y/arch/x86/include/asm/msr-index.h
===================================================================
--- linux-2.6.37.y.orig/arch/x86/include/asm/msr-index.h
+++ linux-2.6.37.y/arch/x86/include/asm/msr-index.h
@@ -39,6 +39,7 @@
 #define MSR_NHM_SNB_PKG_CST_CFG_CTL	0x000000e2
 #define NHM_C3_AUTO_DEMOTE		(1UL << 25)
 #define NHM_C1_AUTO_DEMOTE		(1UL << 26)
+#define ATM_LNC_C6_AUTO_DEMOTE		(1UL << 25)
 
 #define MSR_MTRRcap			0x000000fe
 #define MSR_IA32_BBL_CR_CTL		0x00000119
Index: linux-2.6.37.y/drivers/idle/intel_idle.c
===================================================================
--- linux-2.6.37.y.orig/drivers/idle/intel_idle.c
+++ linux-2.6.37.y/drivers/idle/intel_idle.c
@@ -340,8 +340,12 @@ static int intel_idle_probe(void)
 		break;
 
 	case 0x1C:	/* 28 - Atom Processor */
+		cpuidle_state_table = atom_cstates;
+		break;
+
 	case 0x26:	/* 38 - Lincroft Atom Processor */
 		cpuidle_state_table = atom_cstates;
+		auto_demotion_disable_flags = ATM_LNC_C6_AUTO_DEMOTE;
 		break;
 
 	case 0x2A:	/* SNB */

  reply	other threads:[~2011-03-23  2:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-23  2:24 [PATCH 1/2 2.6.37.stable] intel_idle: disable NHM/WSM HW C-state auto-demotion Len Brown
2011-03-23  2:26 ` Len Brown [this message]
2011-03-23 22:55   ` [stable] [PATCH 2/2 2.6.37.stable] intel_idle: disable Atom/Lincroft " Greg KH
2011-03-23 22:54 ` [stable] [PATCH 1/2 2.6.37.stable] intel_idle: disable NHM/WSM " Greg KH
     [not found] ` <20110323225420.GE27334@kroah.com>
2011-03-24  2:53   ` Len Brown
2011-03-24  3:39     ` Greg KH
2011-04-08 13:16     ` Pavel Machek
2011-04-08 16:14       ` Len Brown
2011-04-08 13:16 ` Pavel Machek
2011-04-08 22:31   ` Len Brown
2011-04-15 16:25     ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.02.1103222224530.10489@x980 \
    --to=lenb@kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox