From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Gleixner Subject: Re: [PATCH v2 07/10] futex: use freezable blocking call Date: Thu, 2 May 2013 21:45:56 +0200 (CEST) Message-ID: References: <1367458508-9133-1-git-send-email-ccross@android.com> <1367458508-9133-8-git-send-email-ccross@android.com> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: In-Reply-To: <1367458508-9133-8-git-send-email-ccross@android.com> Sender: linux-kernel-owner@vger.kernel.org To: Colin Cross Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , arve@android.com, Tejun Heo , Oleg Nesterov , Darren Hart , Andrew Morton , Randy Dunlap , Al Viro List-Id: linux-pm@vger.kernel.org On Wed, 1 May 2013, Colin Cross wrote: > Avoid waking up every thread sleeping in a futex_wait call during > suspend and resume by calling a freezable blocking call. Previous > patches modified the freezer to avoid sending wakeups to threads > that are blocked in freezable blocking calls. > > This call was selected to be converted to a freezable call because > it doesn't hold any locks or release any resources when interrupted > that might be needed by another freezing task or a kernel driver > during suspend, and is a common site where idle userspace tasks are > blocked. > > Signed-off-by: Colin Cross Acked-by: Thomas Gleixner > --- > kernel/futex.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/kernel/futex.c b/kernel/futex.c > index b26dcfc..d710fae 100644 > --- a/kernel/futex.c > +++ b/kernel/futex.c > @@ -61,6 +61,7 @@ > #include > #include > #include > +#include > > #include > > @@ -1807,7 +1808,7 @@ static void futex_wait_queue_me(struct futex_hash_bucket *hb, struct futex_q *q, > * is no timeout, or if it has yet to expire. > */ > if (!timeout || timeout->task) > - schedule(); > + freezable_schedule(); > } > __set_current_state(TASK_RUNNING); > } > -- > 1.8.2.1 > >