From: Meelis Roos <mroos@linux.ee>
To: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>
Cc: rjw@rjwysocki.net, viresh.kumar@linaro.org,
ego@linux.vnet.ibm.com, cpufreq@vger.kernel.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] cpufreq: Catch double invocations of cpufreq_freq_transition_begin/end
Date: Mon, 5 May 2014 11:53:48 +0300 (EEST) [thread overview]
Message-ID: <alpine.SOC.1.00.1405051152370.17122@math.ut.ee> (raw)
In-Reply-To: <20140505072129.14454.25747.stgit@srivatsabhat.in.ibm.com>
>
> Changes in v3:
> Expanded the comment in the code to briefly mention why ASYNC_NOTIFICATION
> drivers are left out from the check, as suggested by Gautham R. Shenoy.
> No code changes in this version.
>
> v2: https://lkml.org/lkml/2014/4/29/283
> v1: https://lkml.org/lkml/2014/4/28/469
Seems to work on VIA EPIA with 3.15-rc2 (no other cpufreq fixes):
[ 8.250959] ------------[ cut here ]------------
[ 8.251179] WARNING: CPU: 0 PID: 116 at drivers/cpufreq/cpufreq.c:367 cpufreq_freq_transition_begin+0xd3/0xd8()
[ 8.251400] Modules linked in: snd_via82xx snd_mpu401_uart longhaul snd_ac97_codec ac97_bus snd_rawmidi snd_seq_device sg snd_pcm snd_timer vt8231 via_rhine uhci_hcd hwmon ehci_hcd tulip i2c_viapro snd evdev soundcore serio_raw sr_mod i2c_core mii usbcore gameport usb_common cdrom parport_pc fan parport via_agp button agpgart processor
[ 8.253465] CPU: 0 PID: 116 Comm: kworker/0:1 Not tainted 3.15.0-rc2-dirty #40
[ 8.253664] Hardware name: VIA TECHNOLOGIES, INC. EPIA/EPIA, BIOS 6.00 PG 11/02/2004
[ 8.253873] Workqueue: events od_dbs_timer
[ 8.254038] 00000000 00000000 cf6afd60 c1283096 cf6afd90 c101ff15 c135a90c 00000000
[ 8.254574] 00000074 c138ccdc 0000016f c11eaaf0 c11eaaf0 cf542000 00061698 cf582c00
[ 8.255118] cf6afda0 c101ffa8 00000009 00000000 cf6afdd0 c11eaaf0 cf6afdd8 cf6afdf4
[ 8.255661] Call Trace:
[ 8.255815] [<c1283096>] dump_stack+0x16/0x18
[ 8.255988] [<c101ff15>] warn_slowpath_common+0x70/0x87
[ 8.256151] [<c11eaaf0>] ? cpufreq_freq_transition_begin+0xd3/0xd8
[ 8.256316] [<c11eaaf0>] ? cpufreq_freq_transition_begin+0xd3/0xd8
[ 8.256482] [<c101ffa8>] warn_slowpath_null+0x1d/0x1f
[ 8.256641] [<c11eaaf0>] cpufreq_freq_transition_begin+0xd3/0xd8
[ 8.256809] [<c1036cba>] ? __srcu_notifier_call_chain+0x24/0x93
[ 8.256989] [<d06c52d5>] longhaul_setstate+0x88/0x2f1 [longhaul]
[ 8.257149] [<c1036d43>] ? srcu_notifier_call_chain+0x1a/0x1c
[ 8.257315] [<c11eaad9>] ? cpufreq_freq_transition_begin+0xbc/0xd8
[ 8.257481] [<d06c55ba>] longhaul_target+0x7c/0x8b [longhaul]
[ 8.257647] [<c11eaebd>] __cpufreq_driver_target+0xfe/0x148
[ 8.257824] [<c10540c6>] ? get_cpu_iowait_time_us+0x84/0xa3
[ 8.257981] [<c11ebe27>] od_check_cpu+0x75/0x79
[ 8.258135] [<c11ec7a1>] dbs_check_cpu+0xbd/0xc5
[ 8.258286] [<c11ec813>] ? need_load_eval+0x18/0x79
[ 8.258439] [<c11ec004>] od_dbs_timer+0x7a/0xd9
[ 8.258612] [<c102f808>] process_one_work+0x205/0x363
[ 8.258770] [<c102f7d7>] ? process_one_work+0x1d4/0x363
[ 8.258927] [<c10300b3>] ? worker_thread+0x27/0x26f
[ 8.259086] [<c103022c>] worker_thread+0x1a0/0x26f
[ 8.259244] [<c103008c>] ? rescuer_thread+0x204/0x204
[ 8.259405] [<c10339e9>] kthread+0xa3/0xa8
[ 8.259567] [<c1287bc0>] ret_from_kernel_thread+0x20/0x30
[ 8.259726] [<c1033946>] ? kthread_create_on_node+0x112/0x112
[ 8.259874] ---[ end trace fe16863c964a8bbe ]---
--
Meelis Roos <mroos@linux.ee>
next prev parent reply other threads:[~2014-05-05 8:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-05 7:22 [PATCH v3] cpufreq: Catch double invocations of cpufreq_freq_transition_begin/end Srivatsa S. Bhat
2014-05-05 8:53 ` Meelis Roos [this message]
2014-05-05 9:09 ` Srivatsa S. Bhat
2014-05-21 12:32 ` Srivatsa S. Bhat
2014-05-21 13:01 ` Rafael J. Wysocki
2014-05-21 12:48 ` Srivatsa S. Bhat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.SOC.1.00.1405051152370.17122@math.ut.ee \
--to=mroos@linux.ee \
--cc=cpufreq@vger.kernel.org \
--cc=ego@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).