From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Matti Vaittinen <mazziesaccount@gmail.com>
Cc: "Matti Vaittinen" <matti.vaittinen@fi.rohmeurope.com>,
"Matti Vaittinen" <matti.vaittinen@linux.dev>,
"Andreas Kemnade" <andreas@kemnade.info>,
"Sebastian Reichel" <sre@kernel.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
"Kalle Niemi" <kaleposti@gmail.com>,
"Topi Sonkajärvi" <sonkajarvi@hotmail.com>,
"Mikko Mutanen" <mikko.mutanen@fi.rohmeurope.com>,
"Markus Laine" <markus.laine@fi.rohmeurope.com>
Subject: Re: [PATCH 5/5] power: supply: bd99954: Drop bad register fields
Date: Mon, 10 Aug 2026 21:03:22 +0300 [thread overview]
Message-ID: <anoSamyqNwUzo5ad@ashevche-desk.local> (raw)
In-Reply-To: <758fd430d02286a6f18603a8aecfe443f5ddeb8e.1786356145.git.mazziesaccount@gmail.com>
On Mon, Aug 10, 2026 at 01:10:03PM +0300, Matti Vaittinen wrote:
> The bd99954 driver creates regmap fields for all the registers. All the
> fields for VBUS_UCD_FCTRL_SET (extended command 0x33) are accidentally
> created for VCC_UCD_FCTRL_SET (extended command 0x2b), causing all
> reads/writes for the fields to access wrong register. Luckily the fields
> for VBUS_UCD_FCTRL_SET are unused.
>
> Taking a look at the data-sheet:
> https://fscdn.rohm.com/en/products/databook/datasheet/ic/power/battery_management/bd99954xxx-e.pdf
Make it a Link or Datasheet tag.
> all the fields in the VBUS_UCD_FCTRL_SET are marked as:
> "In normal operation, please don’t set these registers" with not much of
> additional documentation. As the fields are wrong and because there seems
> to be no users of the fields - it is better to just drop them. This will
> also decrease the memory footprint.
>
> Drop incorrect VBUS_UCD_FCTRL_SET fields.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-08-10 18:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-10 10:08 [PATCH 0/5] ROHM bd71828 power-supply fixes Matti Vaittinen
2026-08-10 10:08 ` [PATCH 1/5] power: supply: bd71815: Fix temperature reading Matti Vaittinen
2026-08-10 10:09 ` [PATCH 2/5] power: supply: bd71828: Fix current direction Matti Vaittinen
2026-08-10 17:18 ` Andy Shevchenko
2026-08-10 10:09 ` [PATCH 3/5] power: supply: bd71828: Drop duplicate power-supply property Matti Vaittinen
2026-08-10 18:01 ` Andy Shevchenko
2026-08-10 10:09 ` [PATCH 4/5] power: supply: bd71828: Do not hide errors Matti Vaittinen
2026-08-10 10:10 ` [PATCH 5/5] power: supply: bd99954: Drop bad register fields Matti Vaittinen
2026-08-10 18:03 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anoSamyqNwUzo5ad@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=andreas@kemnade.info \
--cc=kaleposti@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=markus.laine@fi.rohmeurope.com \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=matti.vaittinen@linux.dev \
--cc=mazziesaccount@gmail.com \
--cc=mikko.mutanen@fi.rohmeurope.com \
--cc=sonkajarvi@hotmail.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox