From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender5-op-o11.zoho.com (sender5-op-o11.zoho.com [165.173.182.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 028864582F6 for ; Fri, 18 Sep 2026 17:54:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=165.173.182.11 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789754073; cv=pass; b=riFK/faQY23hKmiu4IMyFrxD7VLQ94qs7u8+zhvrMzQ5vstLw7AIa22fFAsHr0WBNAsC5C6rm3WQr0a730yMCK2IiD6h13ViMHjfIMAqAEHTw58Y6vWvo44HE3FUfVwAN/fu2+kldd8Icn+Kka46CRp5JWoc0fr8j/gxzlJntis= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789754073; c=relaxed/simple; bh=GsKVvJLwF0c/ZF1XYuy0FF1oQZeeINqC56jLuJY1/2k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LOpZR/jKv1btZnxmSlmu8L0AF5KDqIJ3F8SZcOkWcJUL3yhTRkwj6VCeePW9i6MriV0P4ZsrR3IXu0TUNlqRcwzYgMI3r646BHQ9zgH3c9IVM5A/DnTUen1bxySXTEPL7dhiDm2TCsscNooF5jP3wMAu3Yr1E/l/wsjdCss8iqQ= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=sebastian.reichel@collabora.com header.b=L3ZL1gbP; arc=pass smtp.client-ip=165.173.182.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=sebastian.reichel@collabora.com header.b="L3ZL1gbP" ARC-Seal: i=1; a=rsa-sha256; t=1789754057; cv=none; d=zohomail.com; s=zohoarc; b=jzZp+bCCtv8N6HtMmrvG3103FUUHf/RPkD2/52jxisHwhyI1Xr8fZ3atd4PBU5zsXc45x0MNOr5iAqvd3lDQmZ92LG2taSFx2DkvCkhS+pxGVu6e9c2aL91c6S2cHAfrqXZb7t0PLPpDGpTJBOKU9aZVKvee+szALm7IZiWfitI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1789754057; h=Content-Type:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=gGFaTfRq5dYHvrVJRIxLQYdylPpTIHpysFaBIisPlMM=; b=GuqnqxFXsfQqGypMFz4aEg78QyDo7YN5hMqASOfueg1H4GWN1aWVERU7nt8/O3vT4ceRG3bbiyPcBs6I+furS62Xq1utiUoIjLrC7kgH0LXPXQrH/idYujaNu0ybRrv3AsIQCA+RgMXrQyOzRuAEVIGRF70nZEOpJnd2INgHU4w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=sebastian.reichel@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1789754057; s=zohomail; d=collabora.com; i=sebastian.reichel@collabora.com; h=Date:Date:From:From:To:To:Cc:Cc:Subject:Subject:Message-ID:MIME-Version:Content-Type:In-Reply-To:Message-Id:Reply-To; bh=gGFaTfRq5dYHvrVJRIxLQYdylPpTIHpysFaBIisPlMM=; b=L3ZL1gbPjcsJ6lwtG/LAk5mFvlBqaIrMkesSe+nIEsCZ6f94A6IqP15puwmyAS8K FCZmeWgWvG17xUoucNdFPcKIVK8phrOY9fmUNelzr9rH733CvWGckNEoXzPQ03x26Dd K6TJ34ZXGblx+Ail2iARZShaFVbjHtaBVLyQY8j0= Received: by smtp.zohomail.com with SMTPS id 1789754056775590.397012828916; Fri, 18 Sep 2026 10:54:16 -0700 (PDT) Received: by venus (Postfix, from userid 1000) id 41E40180608; Fri, 18 Sep 2026 19:54:14 +0200 (CEST) Date: Fri, 18 Sep 2026 19:54:14 +0200 From: Sebastian Reichel To: Shawn Lin Cc: Ulf Hansson , Heiko Stuebner , linux-pm@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH 4/4] pmdomain: rockchip: drop duplicated errno from supply failure message Message-ID: References: <1789733258-10133-1-git-send-email-shawn.lin@rock-chips.com> <1789733258-10133-5-git-send-email-shawn.lin@rock-chips.com> Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="wo4ywt35kyoe72ye" Content-Disposition: inline In-Reply-To: <1789733258-10133-5-git-send-email-shawn.lin@rock-chips.com> X-Zoho-Virus-Status: 1 X-Zoho-AV-Stamp: zmail-av-0.2.13.1.5.4/289.731.60 X-ZohoMailClient: External --wo4ywt35kyoe72ye Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH 4/4] pmdomain: rockchip: drop duplicated errno from supply failure message MIME-Version: 1.0 Hi, On Fri, Sep 18, 2026 at 08:07:38PM +0800, Shawn Lin wrote: > dev_err_probe() already appends the error code. >=20 > Signed-off-by: Shawn Lin > --- Reviewed-by: Sebastian Reichel -- Sebastian >=20 > drivers/pmdomain/rockchip/pm-domains.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/pmdomain/rockchip/pm-domains.c b/drivers/pmdomain/ro= ckchip/pm-domains.c > index e193f97..dd5e2987 100644 > --- a/drivers/pmdomain/rockchip/pm-domains.c > +++ b/drivers/pmdomain/rockchip/pm-domains.c > @@ -721,7 +721,7 @@ static int rockchip_pd_power_on(struct generic_pm_dom= ain *domain) > ret =3D rockchip_pd_regulator_enable(pd); > if (ret) > return dev_err_probe(pd->pmu->dev, ret, > - "Failed to enable supply: %d\n", ret); > + "Failed to enable supply\n"); > =20 > ret =3D rockchip_pd_power(pd, true); > if (ret) > --=20 > 2.7.4 >=20 >=20 --wo4ywt35kyoe72ye Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmqtesIACgkQ2O7X88g7 +pqZuw//WxV/jL8BUfpYOrO2ZLi84y8R0/RQ1tzDgZKL3SONJyfT/ovqpUkIaMGi eyzCCTX8ugrJQyN22eVN95C0Xxn8GDPgWh13sAvDzBrAWDFMeGtCZr+qQGVTR85O csKLVjUWEyxrOoamG516K51D7E8+jDuIu+VLbO4be0ZGNQhQDPf383PVxAGX/9W1 dPF+9T9lzq0tR+AbDSWq+T2Fg98+9ioCRgJNLa302j2W423okiRHmjX7N8XmDJ9i jTLVRTGKhxoRjbePz1oxuaQ/20dUflIAtLD8Pxr/gZK4DlwRopgor+EGKwENOo5R 5kMc7qTLfHeY9bE7XnRgXSdVG3oHUFnpJt0747i8TmgG7pYpfydmwx3C6QUnEyAr kweNavOTuzZErZ7fV25+k7Nt0/BDBT/LGKSCmKatJ1bN3kAahv620amUQo3z9Qi/ epErlDzuUuBRkB0oVB7faSU3NpTj5T00JW4yQrML8cTnxEiuK39yAFoV3GBI6/Ma MLKjcTmQmXD+4wFvQz5GghTyeCZn1q4BMyTpRQpjp4R0NjcgYSHuX4UkocayoqEj Ep8kJIbIXjAE0ROVAk52BfBpvD8kGM79fil30Mm8UCywsQIBXVjW+K9YC1ghDORv b1HEeY7mfVw3oEGFOOGLSyeTgqIwr9wF2b6HfQ0ExwKNSYcw/vI= =0bqw -----END PGP SIGNATURE----- --wo4ywt35kyoe72ye--