From: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
To: korryasdlerto@gmail.com
Cc: Sebastian Reichel <sre@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] power: supply: Add Silicon Mitus SM5714 fuel gauge driver
Date: Fri, 13 Nov 2026 07:39:17 +0100 [thread overview]
Message-ID: <avawPqDGPEYPWTEg@monoceros> (raw)
In-Reply-To: <20261111-sm5714-fuel-gauge-v1-2-b9d163fff6ff@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 778 bytes --]
Hello,
On Wed, Nov 11, 2026 at 05:35:00PM +0200, Asdlerto Korry via B4 Relay wrote:
> +#include <linux/i2c.h>
> [...]
> +#include <linux/mod_devicetable.h>
<linux/i2c.h> already provides of_device_id and
<linux/mod_devicetable.h> introduces a lot of unneeded build
dependencies. So please drop the latter.
> +static const struct of_device_id sm5714_fg_of_match[] = {
> + { .compatible = "siliconmitus,sm5714-fuelgauge" },
> + { }
> +};
> +MODULE_DEVICE_TABLE(of, sm5714_fg_of_match);
> +
> +static struct i2c_driver sm5714_fg_driver = {
> + .driver = {
> + .name = "sm5714-fuelgauge",
> + .of_match_table = sm5714_fg_of_match,
> + },
> + .probe = sm5714_fg_probe,
> +};
> +module_i2c_driver(sm5714_fg_driver);
Don't you need an i2c_device_id table, too?
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-11-13 6:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 15:34 [PATCH 0/2] power: supply: Add Silicon Mitus SM5714 fuel gauge Asdlerto Korry via B4 Relay
2026-11-11 15:34 ` [PATCH 1/2] dt-bindings: " Asdlerto Korry via B4 Relay
2026-11-11 15:35 ` [PATCH 2/2] power: supply: Add Silicon Mitus SM5714 fuel gauge driver Asdlerto Korry via B4 Relay
2026-11-13 6:39 ` Uwe Kleine-König [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-11-08 11:22 [PATCH 0/2] power: supply: Add Silicon Mitus SM5714 fuel gauge Nizat Mikayilli via B4 Relay
2026-11-08 11:22 ` [PATCH 2/2] power: supply: Add Silicon Mitus SM5714 fuel gauge driver Nizat Mikayilli via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avawPqDGPEYPWTEg@monoceros \
--to=u.kleine-koenig@baylibre.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=korryasdlerto@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox