From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Anand Moon <linux.amoon@gmail.com>
Cc: Troy Mitchell <troy.mitchell@linux.spacemit.com>,
Andi Shyti <andi.shyti@kernel.org>, Yixun Lan <dlan@kernel.org>,
Aurelien Jarno <aurelien@aurel32.net>,
"open list:I2C SUBSYSTEM HOST DRIVERS"
<linux-i2c@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
"open list:SYSTEM RESET/SHUTDOWN DRIVERS"
<linux-pm@vger.kernel.org>,
"open list:RISC-V SPACEMIT SoC Support"
<linux-riscv@lists.infradead.org>,
"open list:RISC-V SPACEMIT SoC Support"
<spacemit@lists.linux.dev>
Subject: Re: [PATCH v1 2/2] power: reset: spacemit-p1: Use atomic I2C transfers for power-off and restart
Date: Mon, 16 Nov 2026 01:30:41 +0100 [thread overview]
Message-ID: <avpN-gFOvTBAMY6G@venus> (raw)
In-Reply-To: <20261110061429.2036-2-linux.amoon@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 6374 bytes --]
Hi,
On Tue, Nov 10, 2026 at 11:44:27AM +0530, Anand Moon wrote:
> The SpacemiT P1 power-off and restart handlers use regmap_set_bits()
> to access the PMIC. However, these handlers run in an atomic notifier
> context (specifically within an rcu_read_lock() critical section), while
> the I2C-backed regmap uses a sleepable mutex.
>
> This triggers a "WARNING: suspicious RCU usage" warning due to an illegal
> context switch in the RCU read-side critical section during shutdown on the
> Banana Pi BPI-F3:
>
> [ 563.803475] WARNING: suspicious RCU usage
> [ 563.807813] 7.3.1-ARCH-RISC-V #1 Not tainted
> [ 563.816614] ./include/linux/rcupdate.h:387 Illegal context switch in RCU read-side critical section!
> ...
> [ 563.841445] locks held by shutdown/1: 2, last CPU#0:
> [ 563.846694] #0: ffffffff8404fb20 (system_transition_mutex){+.+.}-{4:4}, at: __do_sys_reboot+0x230/0x29e
> [ 563.856806] #1: ffffffff84167860 (rcu_read_lock){....}-{1:3}, at: atomic_notifier_call_chain+0x4a/0x1c2
>
> Replace the regmap operations with atomic I2C transfers to avoid sleeping
> in an atomic context. Preserve unrelated register bits through
> read-modify-write operations and check for atomic I2C support before
> registering the handlers.
>
> Obtain the I2C client from the parent device and verify that the adapter
> supports atomic transfers before registering the handlers.
>
> Tested on the Banana Pi BPI-F3 (SpacemiT K1).
>
> Assisted-by: LLM
> Cc: Troy Mitchell <troy.mitchell@linux.spacemit.com>
> Cc: Aurelien Jarno <aurelien@aurel32.net>
> Fixes: 28124cc0fb8c ("driver: reset: spacemit-p1: add driver for poweroff/reboot")
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
regmap runs i2c_transfer itself and thus also uses the atomic I2C
transfers. The problem here is regmap itself. But instead of moving
away from regmap, the atomic use case should be supported properly
in regmap.
Greetings,
-- Sebastian
> drivers/power/reset/spacemit-p1-reboot.c | 86 ++++++++++++++++++++----
> 1 file changed, 74 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/power/reset/spacemit-p1-reboot.c b/drivers/power/reset/spacemit-p1-reboot.c
> index c0454b547718..8fcb3eadddf3 100644
> --- a/drivers/power/reset/spacemit-p1-reboot.c
> +++ b/drivers/power/reset/spacemit-p1-reboot.c
> @@ -4,8 +4,9 @@
> */
>
> #include <linux/bits.h>
> +#include <linux/errno.h>
> +#include <linux/i2c.h>
> #include <linux/platform_device.h>
> -#include <linux/regmap.h>
> #include <linux/reboot.h>
>
> /* Power Control Register 2 */
> @@ -13,13 +14,68 @@
> #define PWR_CTRL2_SHUTDOWN BIT(2) /* Shutdown request */
> #define PWR_CTRL2_RST BIT(1) /* Reset request */
>
> +static int spacemit_p1_read_atomic(struct i2c_client *client,
> + u8 reg, u8 *val)
> +{
> + struct i2c_msg msgs[] = {
> + {
> + .addr = client->addr,
> + .flags = client->flags & I2C_M_TEN,
> + .len = 1,
> + .buf = ®,
> + },
> + {
> + .addr = client->addr,
> + .flags = (client->flags & I2C_M_TEN) | I2C_M_RD,
> + .len = 1,
> + .buf = val,
> + },
> + };
> + int ret;
> +
> + ret = i2c_transfer(client->adapter, msgs, ARRAY_SIZE(msgs));
> +
> + return ret == ARRAY_SIZE(msgs) ? 0 : ret < 0 ? ret : -EIO;
> +}
> +
> +static int spacemit_p1_write_atomic(struct i2c_client *client,
> + u8 reg, u8 val)
> +{
> + u8 buf[] = { reg, val };
> + struct i2c_msg msg = {
> + .addr = client->addr,
> + .flags = client->flags & I2C_M_TEN,
> + .len = sizeof(buf),
> + .buf = buf,
> + };
> + int ret;
> +
> + ret = i2c_transfer(client->adapter, &msg, 1);
> +
> + return ret == 1 ? 0 : ret < 0 ? ret : -EIO;
> +}
> +
> +static int spacemit_p1_update_bits_atomic(struct i2c_client *client,
> + u8 reg, u8 mask)
> +{
> + u8 val;
> + int ret;
> +
> + ret = spacemit_p1_read_atomic(client, reg, &val);
> + if (ret)
> + return ret;
> +
> + return spacemit_p1_write_atomic(client, reg, val | mask);
> +}
> +
> static int spacemit_p1_pwroff_handler(struct sys_off_data *data)
> {
> - struct regmap *regmap = data->cb_data;
> + struct i2c_client *client = data->cb_data;
> int ret;
>
> /* Put the PMIC into shutdown state */
> - ret = regmap_set_bits(regmap, PWR_CTRL2, PWR_CTRL2_SHUTDOWN);
> + ret = spacemit_p1_update_bits_atomic(client, PWR_CTRL2,
> + PWR_CTRL2_SHUTDOWN);
> if (ret) {
> dev_err(data->dev, "shutdown failed: %d\n", ret);
> return notifier_from_errno(ret);
> @@ -30,11 +86,12 @@ static int spacemit_p1_pwroff_handler(struct sys_off_data *data)
>
> static int spacemit_p1_restart_handler(struct sys_off_data *data)
> {
> - struct regmap *regmap = data->cb_data;
> + struct i2c_client *client = data->cb_data;
> int ret;
>
> /* Put the PMIC into reset state */
> - ret = regmap_set_bits(regmap, PWR_CTRL2, PWR_CTRL2_RST);
> + ret = spacemit_p1_update_bits_atomic(client, PWR_CTRL2,
> + PWR_CTRL2_RST);
> if (ret) {
> dev_err(data->dev, "restart failed: %d\n", ret);
> return notifier_from_errno(ret);
> @@ -46,21 +103,26 @@ static int spacemit_p1_restart_handler(struct sys_off_data *data)
> static int spacemit_p1_reboot_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> - struct regmap *regmap;
> + struct i2c_client *client;
> int ret;
>
> - regmap = dev_get_regmap(dev->parent, NULL);
> - if (!regmap)
> - return -ENODEV;
> + client = i2c_verify_client(dev->parent);
> + if (!client)
> + return dev_err_probe(dev, -ENODEV,
> + "Failed to find parent I2C client\n");
> +
> + if (!client->adapter->algo->xfer_atomic)
> + return dev_err_probe(dev, -EOPNOTSUPP,
> + "Atomic I2C transfers not supported\n");
>
> - ret = devm_register_power_off_handler(dev, &spacemit_p1_pwroff_handler,
> - regmap);
> + ret = devm_register_power_off_handler(dev, spacemit_p1_pwroff_handler,
> + client);
> if (ret)
> return dev_err_probe(dev, ret,
> "Failed to register power off handler\n");
>
> ret = devm_register_restart_handler(dev, spacemit_p1_restart_handler,
> - regmap);
> + client);
> if (ret)
> return dev_err_probe(dev, ret,
> "Failed to register restart handler\n");
> --
> 2.56.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2026-11-16 6:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 6:14 [PATCH v1 1/2] i2c: spacemit: Avoid sleeping during bus reset in atomic context Anand Moon
2026-11-10 6:14 ` [PATCH v1 2/2] power: reset: spacemit-p1: Use atomic I2C transfers for power-off and restart Anand Moon
2026-11-10 21:25 ` Aurelien Jarno
2026-11-11 1:16 ` Troy Mitchell
2026-11-11 9:29 ` Aurelien Jarno
2026-11-11 11:05 ` Anand Moon
2026-11-16 0:30 ` Sebastian Reichel [this message]
2026-11-10 6:41 ` [PATCH v1 1/2] i2c: spacemit: Avoid sleeping during bus reset in atomic context Troy Mitchell
2026-11-10 6:49 ` Troy Mitchell
2026-11-10 7:04 ` Anand Moon
2026-11-10 20:49 ` Aurelien Jarno
2026-11-10 21:15 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avpN-gFOvTBAMY6G@venus \
--to=sebastian.reichel@collabora.com \
--cc=andi.shyti@kernel.org \
--cc=aurelien@aurel32.net \
--cc=dlan@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux.amoon@gmail.com \
--cc=spacemit@lists.linux.dev \
--cc=troy.mitchell@linux.spacemit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox