From: Frank Li <Frank.li@oss.nxp.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Frank Li <Frank.Li@nxp.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
linux-pm@vger.kernel.org,
Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Tvrtko Ursulin <tursulin@ursulin.net>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Hellstrom <thomas.hellstrom@linux.intel.com>,
Simona Vetter <simona@ffwll.ch>, David Airlie <airlied@gmail.com>,
Matthew Brost <matthew.brost@intel.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
Patrik Jakobsson <patrik.r.jakobsson@gmail.com>,
Alessio Belle <alessio.belle@imgtec.com>,
Luigi Santivetti <luigi.santivetti@imgtec.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>,
Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Robin Murphy <robin.murphy@arm.com>,
Yong Wu <yong.wu@mediatek.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Heiko Stuebner <heiko@sntech.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Dafna Hirschfeld <dafna@fastmail.com>,
Michael Tretter <m.tretter@pengutronix.de>,
Daniel Baluta <daniel.baluta@nxp.com>,
Will Deacon <will@kernel.org>,
Vijendar Mukunda <Vijendar.Mukunda@amd.com>,
dri-devel@lists.freedesktop.org,
imagination@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-media@vger.kernel.org,
linux-rockchip@lists.infradead.org, linux-sound@vger.kernel.org,
sound-open-firmware@alsa-project.org, imx@lists.linux.dev
Subject: Re: [PATCH v2 2/2] PM: runtime: fix stub pm_runtime_get_if_in_use() for !CONFIG_PM
Date: Mon, 16 Nov 2026 09:43:13 -0600 [thread overview]
Message-ID: <avskkbztzVF_SRo6@SMW015318> (raw)
In-Reply-To: <20261116153139.GB1763944@killaraus.ideasonboard.com>
On Mon, Nov 16, 2026 at 05:31:39PM +0200, Laurent Pinchart wrote:
> Hi Frank,
>
> On Mon, Nov 16, 2026 at 10:25:11AM -0500, Frank.Li@oss.nxp.com wrote:
> > From: Frank Li <Frank.Li@nxp.com>
> >
> > The stub for pm_runtime_get_if_in_use() under !CONFIG_PM currently
> > returns -EINVAL. The real implementation returns:
> > 1 - device is active and its usage counter is non-zero (bumped)
> > 0 - device is not in use or not active (counter not bumped)
> > -EINVAL - runtime PM disabled for this device
> >
> > When CONFIG_PM is not set every device is permanently "active" and
> > always considered "in use", so the stub must return 1, mirroring
> > __pm_runtime_resume() which already returns 1 in the same build.
> >
> > Returning -EINVAL breaks callers that test the return value with
> > comparisons other than "!= 0 / == 0":
> >
> > drivers/gpu/drm/i915/intel_runtime_pm.c:
> > if (intel_runtime_pm_get_if_in_use(rpm))
> > which wraps to: ret = pm_runtime_get_if_in_use(); return ret > 0;
> > With -EINVAL the wrapper returns false, causing an incorrect error
> > path in the GT fence revocation code.
> >
> > drivers/gpu/drm/xe/xe_pm.c:
> > if (pm_runtime_get_if_in_use(xe->drm.dev) > 0)
> > With -EINVAL the condition is false; xe_pm_runtime_get_if_in_use()
> > returns false, so callers believe the device is not usable.
> >
> > drivers/gpu/drm/gma500/power.c:
> > return pm_runtime_get_if_in_use(dev) == 1;
> > -EINVAL != 1, so the helper always returns false when !CONFIG_PM.
> >
> > drivers/gpu/drm/imagination/pvr_power.c:
> > if (pm_runtime_get_if_in_use(...) <= 0)
> > -EINVAL <= 0 is true, so the driver always takes the "requeue" error
> > path instead of proceeding with the active device.
> >
> > sound/soc/sof/debug.c:
> > if (pm_runtime_get_if_in_use(sdev->dev) == 1)
> > -EINVAL != 1, so d3_prevented is never set, corrupting exception
> > debug accounting.
> >
> > drivers/iommu/mtk_iommu.c:
> > if (pm_runtime_get_if_in_use(dom->plat_dev->dev) <= 0)
> > -EINVAL <= 0 skips the TLB flush, leaving stale IOMMU mappings.
> >
> > drivers/iommu/rockchip-iommu.c:
> > Three call sites use WARN_ON_ONCE(err < 0) or similar patterns.
> > -EINVAL < 0 triggers a spurious WARNING on every call.
> >
> > drivers/media/i2c/isl7998x.c:
> > if (pm_runtime_get_if_in_use(dev) <= 0) (two call sites)
> > -EINVAL <= 0 causes the driver to always skip register programming
> > when !CONFIG_PM.
> >
> > drivers/media/platform/rockchip/rkisp1/rkisp1-debug.c:
> > if (pm_runtime_get_if_in_use(dev) <= 0) (two call sites)
> > -EINVAL <= 0 prevents any debug statistics from being collected.
> >
> > Fixes: 9d58aa46291d ("drm/i915: Fix the GT fence revocation runtime PM logic")
> > Fixes: cbb6a7413b17 ("drm/xe: Introduce xe_pm_runtime_get_noresume for inner callers")
> > Fixes: 672c473576ca ("drm/gma500: Rewrite power management code")
> > Fixes: 727538a4bbff ("drm/imagination: Implement power management")
> > Fixes: b30289e7fa92 ("ASoC: SOF: Fix runtime pm usage counter balance after fw exception")
> > Fixes: c0b57581b73b ("iommu/mediatek: Add power-domain operation")
> > Fixes: 0f181d3cf7d9 ("iommu/rockchip: Add runtime PM support")
> > Fixes: 51ef2be546e2 ("media: i2c: isl7998x: Add driver for Intersil ISL7998x")
> > Fixes: cbb819c363c5 ("media: rkisp1: debug: Collect input status by sampling ISP_FLAGS_SHD")
>
> I don't think this one is right. The rkisp1 driver only runs on ARCH_MXC
> and ARCH_ROCKCHIP, which select CONFIG_PM. The same may be true for some
> of the other fixes tags.
But code itself should be wrong even though these platform force enable
CONFIG_PM.
Frank
>
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> > Change in v2
> > - new patches.
> >
> > Cc: "Rafael J. Wysocki" <rafael@kernel.org>
> > Cc: linux-pm@vger.kernel.org
> > Cc: Jani Nikula <jani.nikula@linux.intel.com>
> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > Cc: Tvrtko Ursulin <tursulin@ursulin.net>
> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > Cc: Maxime Ripard <mripard@kernel.org>
> > Cc: "Thomas Hellstrom" <thomas.hellstrom@linux.intel.com>
> > Cc: Simona Vetter <simona@ffwll.ch>
> > Cc: David Airlie <airlied@gmail.com>
> > Cc: Matthew Brost <matthew.brost@intel.com>
> > Cc: Thomas Zimmermann <tzimmermann@suse.de>
> > Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
> > Cc: Alessio Belle <alessio.belle@imgtec.com>
> > Cc: Luigi Santivetti <luigi.santivetti@imgtec.com>
> > Cc: Liam Girdwood <lgirdwood@gmail.com>
> > Cc: Mark Brown <broonie@kernel.org>
> > Cc: Jaroslav Kysela <perex@perex.cz>
> > Cc: Takashi Iwai <tiwai@suse.com>
> > Cc: Bard Liao <yung-chuan.liao@linux.intel.com>
> > Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>
> > Cc: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
> > Cc: Kai Vehmanen <kai.vehmanen@linux.intel.com>
> > Cc: Robin Murphy <robin.murphy@arm.com>
> > Cc: Yong Wu <yong.wu@mediatek.com>
> > Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> > Cc: Matthias Brugger <matthias.bgg@gmail.com>
> > Cc: Heiko Stuebner <heiko@sntech.de>
> > Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> > Cc: Dafna Hirschfeld <dafna@fastmail.com>
> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Cc: Michael Tretter <m.tretter@pengutronix.de>
> > Cc: Daniel Baluta <daniel.baluta@nxp.com>
> > Cc: Will Deacon <will@kernel.org>
> > Cc: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
> > Cc: dri-devel@lists.freedesktop.org
> > Cc: imagination@lists.freedesktop.org
> > Cc: intel-gfx@lists.freedesktop.org
> > Cc: intel-xe@lists.freedesktop.org
> > Cc: iommu@lists.linux.dev
> > Cc: linux-arm-kernel@lists.infradead.org
> > Cc: linux-mediatek@lists.infradead.org
> > Cc: linux-media@vger.kernel.org
> > Cc: linux-rockchip@lists.infradead.org
> > Cc: linux-sound@vger.kernel.org
> > Cc: sound-open-firmware@alsa-project.org
> > Cc: imx@lists.linux.dev
> > ---
> > include/linux/pm_runtime.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/linux/pm_runtime.h b/include/linux/pm_runtime.h
> > index de9e7518ecef2..1d983fe55a16a 100644
> > --- a/include/linux/pm_runtime.h
> > +++ b/include/linux/pm_runtime.h
> > @@ -276,7 +276,7 @@ static inline int pm_schedule_suspend(struct device *dev, unsigned int delay)
> > }
> > static inline int pm_runtime_get_if_in_use(struct device *dev)
> > {
> > - return -EINVAL;
> > + return 1;
> > }
> > static inline int pm_runtime_get_if_active(struct device *dev)
> > {
>
> --
> Regards,
>
> Laurent Pinchart
next prev parent reply other threads:[~2026-11-16 15:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 15:25 [PATCH v2 1/2] PM: runtime: fix stub pm_runtime_get_if_active() for !CONFIG_PM Frank.Li
2026-11-16 15:25 ` [PATCH v2 2/2] PM: runtime: fix stub pm_runtime_get_if_in_use() " Frank.Li
2026-11-16 15:31 ` Laurent Pinchart
2026-11-16 15:43 ` Frank Li [this message]
2026-11-16 15:52 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avskkbztzVF_SRo6@SMW015318 \
--to=frank.li@oss.nxp.com \
--cc=Frank.Li@nxp.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=airlied@gmail.com \
--cc=alessio.belle@imgtec.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=broonie@kernel.org \
--cc=dafna@fastmail.com \
--cc=daniel.baluta@nxp.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=imagination@lists.freedesktop.org \
--cc=imx@lists.linux.dev \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=iommu@lists.linux.dev \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=luigi.santivetti@imgtec.com \
--cc=m.tretter@pengutronix.de \
--cc=maarten.lankhorst@linux.intel.com \
--cc=matthew.brost@intel.com \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=mripard@kernel.org \
--cc=patrik.r.jakobsson@gmail.com \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.dev \
--cc=rafael@kernel.org \
--cc=robin.murphy@arm.com \
--cc=rodrigo.vivi@intel.com \
--cc=simona@ffwll.ch \
--cc=sound-open-firmware@alsa-project.org \
--cc=thomas.hellstrom@linux.intel.com \
--cc=tiwai@suse.com \
--cc=tursulin@ursulin.net \
--cc=tzimmermann@suse.de \
--cc=will@kernel.org \
--cc=yong.wu@mediatek.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox