From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nandor Han Subject: Re: [PATCH v2 1/2] power: reset: nvmem-reboot-mode: use NVMEM as reboot mode write interface Date: Thu, 18 Apr 2019 09:29:08 +0300 Message-ID: References: <20190411055341.9263-1-nandor.han@vaisala.com> <20190411055341.9263-2-nandor.han@vaisala.com> <20190417215649.ejrvd6zekfmvjtn5@earth.universe> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190417215649.ejrvd6zekfmvjtn5@earth.universe> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Sebastian Reichel Cc: "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "devicetree@vger.kernel.org" List-Id: linux-pm@vger.kernel.org On 4/18/19 12:56 AM, Sebastian Reichel wrote: > On Thu, Apr 11, 2019 at 05:54:09AM +0000, Han Nandor wrote: >> Add a new reboot mode write interface that is using an NVMEM cell >> to store the reboot mode magic. >> >> Signed-off-by: Nandor Han >> --- >> +module_platform_driver(nvmem_reboot_mode_driver); >> + >> +MODULE_AUTHOR("Nandor Han "); >> +MODULE_DESCRIPTION("NVMEM reboot mode driver"); >> +MODULE_LICENSE("GPL v2"); > > I suppose as of bf7fbeeae6db "GPL v2" is deprecated, before it was > often read as GPL v2 only. In both cases it makes sense to just > use "GPL". Otherwise the driver looks fine to me, but I'm waiting > for Rob's review of the DT bindings before merging this. > > -- Sebastian > Thanks Sebastian. Do you want me to send a new revision with license changed to "GPL"?..or will you change it when it's merged? Nandor From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26AFAC10F0B for ; Thu, 18 Apr 2019 06:38:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E89BD2184B for ; Thu, 18 Apr 2019 06:38:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733151AbfDRGir (ORCPT ); Thu, 18 Apr 2019 02:38:47 -0400 Received: from hel-mailgw-01.vaisala.com ([193.143.230.17]:35080 "EHLO hel-mailgw-01.vaisala.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725836AbfDRGir (ORCPT ); Thu, 18 Apr 2019 02:38:47 -0400 X-Greylist: delayed 573 seconds by postgrey-1.27 at vger.kernel.org; Thu, 18 Apr 2019 02:38:46 EDT X-IronPort-AV: E=Sophos;i="5.60,364,1549922400"; d="scan'208";a="217000148" Subject: Re: [PATCH v2 1/2] power: reset: nvmem-reboot-mode: use NVMEM as reboot mode write interface To: Sebastian Reichel Cc: "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "devicetree@vger.kernel.org" References: <20190411055341.9263-1-nandor.han@vaisala.com> <20190411055341.9263-2-nandor.han@vaisala.com> <20190417215649.ejrvd6zekfmvjtn5@earth.universe> From: Nandor Han Message-ID: Date: Thu, 18 Apr 2019 09:29:08 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190417215649.ejrvd6zekfmvjtn5@earth.universe> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 18 Apr 2019 06:29:08.0317 (UTC) FILETIME=[071FF0D0:01D4F5B0] Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Message-ID: <20190418062908.v-5uAFg-9ygsWU_ErBvVc0Klpe_ePelZI55PPHzBbKM@z> On 4/18/19 12:56 AM, Sebastian Reichel wrote: > On Thu, Apr 11, 2019 at 05:54:09AM +0000, Han Nandor wrote: >> Add a new reboot mode write interface that is using an NVMEM cell >> to store the reboot mode magic. >> >> Signed-off-by: Nandor Han >> --- >> +module_platform_driver(nvmem_reboot_mode_driver); >> + >> +MODULE_AUTHOR("Nandor Han "); >> +MODULE_DESCRIPTION("NVMEM reboot mode driver"); >> +MODULE_LICENSE("GPL v2"); > > I suppose as of bf7fbeeae6db "GPL v2" is deprecated, before it was > often read as GPL v2 only. In both cases it makes sense to just > use "GPL". Otherwise the driver looks fine to me, but I'm waiting > for Rob's review of the DT bindings before merging this. > > -- Sebastian > Thanks Sebastian. Do you want me to send a new revision with license changed to "GPL"?..or will you change it when it's merged? Nandor