* [PATCH] soc: mediatek: fix the mistaken pointer accessed when subdomains are added
@ 2018-02-08 18:07 sean.wang
2018-03-07 9:21 ` Sean Wang
2018-03-11 22:51 ` Matthias Brugger
0 siblings, 2 replies; 3+ messages in thread
From: sean.wang @ 2018-02-08 18:07 UTC (permalink / raw)
To: matthias.bgg, rjw, khilman
Cc: ulf.hansson, linux-mediatek, linux-pm, linux-arm-kernel,
linux-kernel, Sean Wang, stable
From: Sean Wang <sean.wang@mediatek.com>
Fix the pointer to struct scp_subdomian not being moved forward
when each sub-domain is expected to be iteratively added through
pm_genpd_add_subdomain call.
Cc: stable@vger.kernel.org
Fixes: 53fddb1a66dd ("soc: mediatek: reduce code duplication of scpsys_probe across all SoCs")
Reported-by: Weiyi Lu <weiyi.lu@mediatek.com>
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
---
drivers/soc/mediatek/mtk-scpsys.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/mediatek/mtk-scpsys.c b/drivers/soc/mediatek/mtk-scpsys.c
index fc55faa..9de801e 100644
--- a/drivers/soc/mediatek/mtk-scpsys.c
+++ b/drivers/soc/mediatek/mtk-scpsys.c
@@ -1048,7 +1048,7 @@ static int scpsys_probe(struct platform_device *pdev)
pd_data = &scp->pd_data;
- for (i = 0, sd = soc->subdomains ; i < soc->num_subdomains ; i++) {
+ for (i = 0, sd = soc->subdomains; i < soc->num_subdomains; i++, sd++) {
ret = pm_genpd_add_subdomain(pd_data->domains[sd->origin],
pd_data->domains[sd->subdomain]);
if (ret && IS_ENABLED(CONFIG_PM))
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] soc: mediatek: fix the mistaken pointer accessed when subdomains are added
2018-02-08 18:07 [PATCH] soc: mediatek: fix the mistaken pointer accessed when subdomains are added sean.wang
@ 2018-03-07 9:21 ` Sean Wang
2018-03-11 22:51 ` Matthias Brugger
1 sibling, 0 replies; 3+ messages in thread
From: Sean Wang @ 2018-03-07 9:21 UTC (permalink / raw)
To: matthias.bgg
Cc: rjw, khilman, ulf.hansson, linux-mediatek, linux-pm,
linux-arm-kernel, linux-kernel, stable
Hi, Matthis
also a gentle ping for the patch
Sean
On Fri, 2018-02-09 at 02:07 +0800, sean.wang@mediatek.com wrote:
> From: Sean Wang <sean.wang@mediatek.com>
>
> Fix the pointer to struct scp_subdomian not being moved forward
> when each sub-domain is expected to be iteratively added through
> pm_genpd_add_subdomain call.
>
> Cc: stable@vger.kernel.org
> Fixes: 53fddb1a66dd ("soc: mediatek: reduce code duplication of scpsys_probe across all SoCs")
> Reported-by: Weiyi Lu <weiyi.lu@mediatek.com>
> Signed-off-by: Sean Wang <sean.wang@mediatek.com>
> ---
> drivers/soc/mediatek/mtk-scpsys.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/mediatek/mtk-scpsys.c b/drivers/soc/mediatek/mtk-scpsys.c
> index fc55faa..9de801e 100644
> --- a/drivers/soc/mediatek/mtk-scpsys.c
> +++ b/drivers/soc/mediatek/mtk-scpsys.c
> @@ -1048,7 +1048,7 @@ static int scpsys_probe(struct platform_device *pdev)
>
> pd_data = &scp->pd_data;
>
> - for (i = 0, sd = soc->subdomains ; i < soc->num_subdomains ; i++) {
> + for (i = 0, sd = soc->subdomains; i < soc->num_subdomains; i++, sd++) {
> ret = pm_genpd_add_subdomain(pd_data->domains[sd->origin],
> pd_data->domains[sd->subdomain]);
> if (ret && IS_ENABLED(CONFIG_PM))
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] soc: mediatek: fix the mistaken pointer accessed when subdomains are added
2018-02-08 18:07 [PATCH] soc: mediatek: fix the mistaken pointer accessed when subdomains are added sean.wang
2018-03-07 9:21 ` Sean Wang
@ 2018-03-11 22:51 ` Matthias Brugger
1 sibling, 0 replies; 3+ messages in thread
From: Matthias Brugger @ 2018-03-11 22:51 UTC (permalink / raw)
To: sean.wang, rjw, khilman
Cc: ulf.hansson, linux-mediatek, linux-pm, linux-arm-kernel,
linux-kernel, stable
On 02/08/2018 07:07 PM, sean.wang@mediatek.com wrote:
> From: Sean Wang <sean.wang@mediatek.com>
>
> Fix the pointer to struct scp_subdomian not being moved forward
> when each sub-domain is expected to be iteratively added through
> pm_genpd_add_subdomain call.
>
> Cc: stable@vger.kernel.org
> Fixes: 53fddb1a66dd ("soc: mediatek: reduce code duplication of scpsys_probe across all SoCs")
> Reported-by: Weiyi Lu <weiyi.lu@mediatek.com>
> Signed-off-by: Sean Wang <sean.wang@mediatek.com>
Pushed now to v4.16-next/soc
Thanks a lot
@stable this would need to be applied since v4.13
> ---
> drivers/soc/mediatek/mtk-scpsys.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/mediatek/mtk-scpsys.c b/drivers/soc/mediatek/mtk-scpsys.c
> index fc55faa..9de801e 100644
> --- a/drivers/soc/mediatek/mtk-scpsys.c
> +++ b/drivers/soc/mediatek/mtk-scpsys.c
> @@ -1048,7 +1048,7 @@ static int scpsys_probe(struct platform_device *pdev)
>
> pd_data = &scp->pd_data;
>
> - for (i = 0, sd = soc->subdomains ; i < soc->num_subdomains ; i++) {
> + for (i = 0, sd = soc->subdomains; i < soc->num_subdomains; i++, sd++) {
> ret = pm_genpd_add_subdomain(pd_data->domains[sd->origin],
> pd_data->domains[sd->subdomain]);
> if (ret && IS_ENABLED(CONFIG_PM))
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-11 22:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-08 18:07 [PATCH] soc: mediatek: fix the mistaken pointer accessed when subdomains are added sean.wang
2018-03-07 9:21 ` Sean Wang
2018-03-11 22:51 ` Matthias Brugger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).