Re: [PATCH v7 6/9] interconnect: qcom: rpm: Handle interface clocks

Bryan O'Donoghue
2023-03-11T12:11:52Z

On 11/03/2023 00:54, Konrad Dybcio wrote:
>> - Update the commit log and potentially the structure comments
> I'm probably just very biased because I authored these commits, but I can't
> see which part is not clear.. Could I (and this is not passive-aggressive or
> anything) ask for a pointer there?
>

I mean to say "non scaling clocks" isn't an indicator IMO of the fact
that these are QoS node specific clocks.

Right now the interconnect model is predicated on bus and bus_a but,
you've found that on some SoCs we have node-specific clocks too.

:g/non\ scaling/s//non-scaling\ node-specific/g

would do or "QoS node-specific" the fact the clocks don't scale is
incidental the dependency though is that IMO at least these are
additional node-specific clocks we need to enable.

---
bod