From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 689403B78B for ; Tue, 9 Jan 2024 17:23:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="oAVJ3Vki" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1704821011; x=1736357011; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=dQ/zjNa5R1aGqolilaWfdhz/3U3vkl1yq6Hgrj/XWUw=; b=oAVJ3Vkiqej6grCxdeo3iJxn9xYri4+eLBjXG7yzyaRLUiac6etvH+CJ uWanMX00BYYtq4YQk1LvkRfjRjozdKVTdQjyCW7lVsNKyQZ4hm5qrK/7T qFOeL4e9pIB91qriQ2q3NZ9+1S1lSlBtqGKWYLlFjs9mxUKeuBlypj6ag C+RBigmq9d9qqjsAGhfAKanb7YZGCeh1wZVaPfmTBxOzggoghWI+Iqxi5 NirvRKreVMCI+UUSdngjlUZqOaSgr+mB9z5W/sSAlcPPNAG/Oxr47UrEs zZfMrplN56OFuw55tF1rrfhg9kuGWPC2t7QZrL6jiX5VAeKdm7rIrufyf A==; X-IronPort-AV: E=McAfee;i="6600,9927,10947"; a="19770940" X-IronPort-AV: E=Sophos;i="6.04,183,1695711600"; d="scan'208";a="19770940" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jan 2024 09:23:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10947"; a="758056922" X-IronPort-AV: E=Sophos;i="6.04,183,1695711600"; d="scan'208";a="758056922" Received: from jlawryno-mobl.ger.corp.intel.com (HELO [10.249.150.128]) ([10.249.150.128]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jan 2024 09:23:24 -0800 Message-ID: Date: Tue, 9 Jan 2024 18:23:21 +0100 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] pm: runtime: Simplify pm_runtime_get_if_active() usage Content-Language: en-US To: Sakari Ailus , linux-pm@vger.kernel.org Cc: "Rafael J. Wysocki" , Andy Shevchenko , laurent.pinchart@ideasonboard.com, Stanislaw Gruszka , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , Lucas De Marchi , =?UTF-8?Q?Thomas_Hellstr=C3=B6m?= , Paul Elder , Alex Elder , Greg Kroah-Hartman , Jaroslav Kysela , Takashi Iwai , Mark Brown References: <20240109133639.111210-1-sakari.ailus@linux.intel.com> <20240109133657.111258-1-sakari.ailus@linux.intel.com> From: Jacek Lawrynowicz Organization: Intel Technology Poland sp. z o.o. - ul. Slowackiego 173, 80-298 Gdansk - KRS 101882 - NIP 957-07-52-316 In-Reply-To: <20240109133657.111258-1-sakari.ailus@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 09.01.2024 14:36, Sakari Ailus wrote: > There are two ways to opportunistically increment a device's runtime PM > usage count, calling either pm_runtime_get_if_active() or > pm_runtime_get_if_in_use(). The former has an argument to tell whether to > ignore the usage count or not, and the latter simply calls the former with > ign_usage_count set to false. The other users that want to ignore the > usage_count will have to explitly set that argument to true which is a bit > cumbersome. > > To make this function more practical to use, remove the ign_usage_count > argument from the function. The main implementation is renamed as > __pm_runtime_get_conditional(). > > Signed-off-by: Sakari Ailus > --- For drivers/accel/ivpu: Reviewed-by: Jacek Lawrynowicz Thanks, Jacek