From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9339420864 for ; Mon, 6 Jul 2026 13:04:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783343070; cv=none; b=War9Njevm5nSKnHecg/tLaqC0ocFg0FxKHrmHlfbN7zQgi4iLrOvwEWfQxg0eM+BC2vU/e66ZRKFpo9iKT+8xMukk1SLWqCnG99k/30KX6NO1oAlfk9ir4wmcGDLh2lBxX/5sDJgDk9lyKflVwyDgV87TdgFgP8ZKoKPg02qt1I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783343070; c=relaxed/simple; bh=9/7QPfKMTMI/CjWRhumszI3/aGbVFOoiMgVoaf9cHw8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ol/knd52WZ47Tm0K4PZ40Xgni5QQHzZanpU7QHPeJeHpJ3IGYgsNCDP26jj5E8uKzSy0h5hty0wYwT5O02l18J1yU9YHKQKlVHJcco8tKCcIlgtYZsLrtfL42izaNgMHAbREAz2IewwoUOdVdaMEXl4TNqtzYlstNF2TilEWirQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JapYqo/b; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=QXWY6x+c; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JapYqo/b"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="QXWY6x+c" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 666AxTeV317147 for ; Mon, 6 Jul 2026 13:04:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= pWsnU3ydAXBOIOITNJSSKAM8BpjQAyuQui8bRCBB0A8=; b=JapYqo/b3DOlXT5l YMkVOG5SkD+soPzoW2SxJcmivNrwV0JagYLz/i1Yzga4SuyiMddZ9BOzp9AY3VUC ZB+ETwaWTBYE6NkT8O6hB3MrGqkwoUBLOLV3OCVJvHIMk1sMG7WbYFJk4EiEDVMK A6oAebTAZ9ge/1H5uZTGMSAVfn5v1ItcScKJByUgdfAfZ5qsG6M0NjQbef4hLPlT JRh/wZ1lUSLTwa19my23fMtBUNR9r/eJrT7V+Q8J63mMlQIPc6TtTOmCh/ovCzRu 21f9oUxvn8bpiG4mzCmDG9+Wf1njfa2eNPEuWfVhcHV8EBH/M/igw9ujOvGR0pl7 y9GzUA== Received: from mail-ot1-f72.google.com (mail-ot1-f72.google.com [209.85.210.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f87q7hbvt-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Jul 2026 13:04:28 +0000 (GMT) Received: by mail-ot1-f72.google.com with SMTP id 46e09a7af769-7eb4f51ba95so141054a34.3 for ; Mon, 06 Jul 2026 06:04:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783343068; x=1783947868; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=pWsnU3ydAXBOIOITNJSSKAM8BpjQAyuQui8bRCBB0A8=; b=QXWY6x+cx2dKGLfJxcCMYyeYgLCK4kvzLzPIr5N53epyzrjAFmAhBsXd4ykBgDewub lezYuUVXl4k4CjF+ORKxtn6X5ECF77Kr+MXaOE5hRMjERRILo6N7zf/RCZ+Zw8eLrk46 xXddJyOeEnr5DLC4qi1m4Lt+biwjFyK/K2B5TjmXJP4qE8JOyvenTiFacgMSmjWUSxJj CVvGqNwEAkkGSXFnausahXeKcVbosgIAxIqvS6co8XtKR/kvTlcYeYSDgdAgpusBzW4I mTWXT1k6TZ1T7BcQYXz2YDv6u+ES+6n+zj+QoeSV/yGhvQFMYMmvU/9PSdrD7gT3u7yt cOHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783343068; x=1783947868; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=pWsnU3ydAXBOIOITNJSSKAM8BpjQAyuQui8bRCBB0A8=; b=pJxYopPAsVOWR+sA/ISN3otHqFC9ky2ZT5X0OVKUGOIuC/CARe1oTIQ/F4bdgGGZsA OJhzQjTfZIWVvXoA6IZTns5jYB6xyYp8czCcifH3nR+Ipg79VycBeK4GHuV17qdHQJmO IF1mj3LZwjQXQQhFSS/ltnYQKjMsBaJ5iyA/KX+gQ3pblDaDOtnjd8d86Y+4yLBJsscC fFsediO22bZ1Q/Vd+eUiD/bEArQc43PcjXff2gc84R0gZzIRYxT9XW9e3/rED3yUnxJU hSt4Y3Um8AL5FtU+yULnrHK3/uxwX5fYzyIXsUZbFMc4g+mQVv6E6NxUO3Grs0tc910W oUGg== X-Forwarded-Encrypted: i=1; AFNElJ9XuJN0bk8EMbE71WgBas7sTvCRvR5B/K/wWG8l/Fp/bE10BlDZlA8kC0PFFtQRU4uL4UqvLzUMKw==@vger.kernel.org X-Gm-Message-State: AOJu0YxpddByn5QIAwz5dZZ8MgPVgCHc1DfrGvMsxNT/UNk4UrlQe3WF 8H41QBEHdynZooxevuQCXO8xpd36NyVWlM/iNzcaJo+olyplc6/khrDXw0LBlmpX9YvVZWqMWh3 1aHXvTL79HdgkEUMScXfC0AbTwQMJmsXN09HZnmTv2WSTlXTxelUljfHOblFcgA== X-Gm-Gg: AfdE7cnmTuAQMs9WY6u1d+vcJ/9YzbKeAyJTn3fc4MpP+S2/FQ9xZnxWtfoJ/Pu4oMU 3c2OpHXqjGnFIZd5ie1dQr9LPIZWNuEbsIQuPxWgBlCHB+nQ0x2BQZ5fRxP2P2ydxyUF0Ap1nvD VNvHyZjrbmfL1eeYssHO43bLrdwE4UshKDAMNgig5HrB223fgLsxKGz1c8Yy1d34HzzXIkvFLBg wupwk5Ie1GIZeXVmubTTb7ig2xBtEzEtmJNK6mLuknYssPLKFCAX2TOm3GWNwQzWhSVuM7MoKGO Ykq+yj++yOh9syKyy4Bn4mc5cC3h5aN85z9YNvH49cM8rRM8tCOeJjGcEM8Fljzp7BmPIuCt3Jd 9Syt5/vNpY0X7aOLBbUN+pOi4hZJR674BflU= X-Received: by 2002:a05:6830:348d:b0:7e9:e1ca:5316 with SMTP id 46e09a7af769-7eb7f1933cfmr4339226a34.0.1783343067627; Mon, 06 Jul 2026 06:04:27 -0700 (PDT) X-Received: by 2002:a05:6830:348d:b0:7e9:e1ca:5316 with SMTP id 46e09a7af769-7eb7f1933cfmr4339199a34.0.1783343067095; Mon, 06 Jul 2026 06:04:27 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-69a19dbef44sm4216078a12.31.2026.07.06.06.04.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Jul 2026 06:04:26 -0700 (PDT) Message-ID: Date: Mon, 6 Jul 2026 15:04:22 +0200 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] spi: qcom-geni: Fix missing error check on pm_runtime_get_sync() To: Praveen Talari , Mark Brown , Dilip Kota , Stephen Boyd , Girish Mahadevan , Alok Chauhan , bjorn.andersson@oss.qualcomm.com, "Rafael J. Wysocki" , Len Brown , Pavel Machek , Greg Kroah-Hartman , Danilo Krummrich , Douglas Anderson Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Mukesh Kumar Savaliya , aniket.randive@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com, jyothi.seerapu@oss.qualcomm.com, linux-pm@vger.kernel.org, driver-core@lists.linux.dev References: <20260706-fix_sticky_-einval_after_pm_runtime_api_failure-v3-0-92feb5a7b926@oss.qualcomm.com> <20260706-fix_sticky_-einval_after_pm_runtime_api_failure-v3-2-92feb5a7b926@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260706-fix_sticky_-einval_after_pm_runtime_api_failure-v3-2-92feb5a7b926@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDEzMyBTYWx0ZWRfXyGoh3lyEF1v8 trbiaM03tCP8xoDoB57Pa3VErsAa0HWEB6T6VxoAKC8AQMxYzGRzpTeIbn8MuZfzk6MP0Un9OwD CYIVfbY9PfGLtqNe+ir/+LQj1QW1M71yScUfBuPGqwmYUqdE+hnSvs6KNOWKLIQMdYWtSWww58q ralhJFgPnk4gctx/ioAWurArLvTnJsfS+OyPWr6ccA6LUJhRNkHkY4ARN/v1QqpLpP527o5LzIX RD9eHUWKkFeRzGJqanp2K4yo4kS4k+OeikaPthtuxceibCNLXuUE1nYOTna85Qbw/q06aN5DneI lwfZarN1PBhHGddIcR3noMDMUu2hA0M5eNdssb5s5DHxX1Y7XxNwT0A2B7uC9T5n6NKzD7RrPsx rUOz07tXjUoXhteBwFmggXJ41wlAwFQ1Sp+O/SrjDrWj0REUCtHKuFGH5bH3Kc0fkqs9FrhCkMc ZFDfUcc49Ev/jdrE8xQ== X-Proofpoint-ORIG-GUID: S6enUd5Y_ru8tLLyHrLIYAstVxdsoBCZ X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDEzMyBTYWx0ZWRfX6A6PKzCL1hbW 5LyzCdFnAcKfYuCSsd1xuvWevCFh68oKo5EeLgfht+hzYgn8I+ttNZ0OY+VHPTj8b5smZpgOVIB ikbEROEvcmEvlII7rp3s2jgABajTRdk= X-Proofpoint-GUID: S6enUd5Y_ru8tLLyHrLIYAstVxdsoBCZ X-Authority-Analysis: v=2.4 cv=f9N4wuyM c=1 sm=1 tr=0 ts=6a4ba7dc cx=c_pps a=+3WqYijBVYhDct2f5Fivkw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=p3Hybbcu0AkdvJTjDJUA:9 a=QEXdDO2ut3YA:10 a=eYe2g0i6gJ5uXG_o6N4q:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-06_01,2026-07-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 impostorscore=0 bulkscore=0 suspectscore=0 clxscore=1015 spamscore=0 phishscore=0 priorityscore=1501 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060133 On 7/6/26 10:53 AM, Praveen Talari wrote: > spi_geni_init() calls pm_runtime_get_sync() to power up the device > before accessing hardware registers, but never checks the return value. > If the runtime resume fails, the function silently proceeds to read and > write hardware registers on a device that may not be powered up, leading > to register access faults. > > Fix this by replacing pm_runtime_get_sync() with the > PM_RUNTIME_ACQUIRE_IF_ENABLED() macro and checking the result via > PM_RUNTIME_ACQUIRE_ERR(), propagating any error back to the caller > immediately before any hardware access occurs. > > Since the macro handles its own cleanup on failure, the out_pm label and > the corresponding pm_runtime_put() call are no longer needed. Replace > all goto out_pm paths with direct return ret statements and remove the > label entirely. > > Fixes: 561de45f72bd ("spi: spi-geni-qcom: Add SPI driver support for GENI based QUP") > Signed-off-by: Praveen Talari > --- Reviewed-by: Konrad Dybcio Konrad