From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Luca Weiss <luca.weiss@fairphone.com>,
cros-qcom-dts-watchers@chromium.org,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>
Cc: ~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 04/11] arm64: dts: qcom: pm7250b: make SID configurable
Date: Wed, 30 Aug 2023 12:06:59 +0200 [thread overview]
Message-ID: <b82f4683-e8b5-b424-8f7a-6d2ba1cab61f@linaro.org> (raw)
In-Reply-To: <20230830-fp5-initial-v1-4-5a954519bbad@fairphone.com>
On 30/08/2023 11:58, Luca Weiss wrote:
> Like other Qualcomm PMICs the PM7250B can be used on different addresses
> on the SPMI bus. Use similar defines like the PMK8350 to make this
> possible.
>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
> arch/arm64/boot/dts/qcom/pm7250b.dtsi | 23 ++++++++++++++++-------
> 1 file changed, 16 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/pm7250b.dtsi b/arch/arm64/boot/dts/qcom/pm7250b.dtsi
> index e8540c36bd99..3514de536baa 100644
> --- a/arch/arm64/boot/dts/qcom/pm7250b.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm7250b.dtsi
> @@ -7,6 +7,15 @@
> #include <dt-bindings/interrupt-controller/irq.h>
> #include <dt-bindings/spmi/spmi.h>
>
> +/* This PMIC can be configured to be at different SIDs */
> +#ifndef PM7250B_SID
> + #define PM7250B_SID 2
> +#endif
Why do you send the same patch as v1, without any reference to previous
discussions?
You got here feedback already.
https://lore.kernel.org/linux-arm-msm/f52524da-719b-790f-ad2c-0c3f313d9fe9@linaro.org/
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-08-30 18:36 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-30 9:58 [PATCH 00/11] Initial support for the Fairphone 5 smartphone Luca Weiss
2023-08-30 9:58 ` [PATCH 01/11] arm64: dts: qcom: sc7280: Mark some nodes as 'reserved' Luca Weiss
2023-08-30 10:08 ` Konrad Dybcio
2023-08-30 10:35 ` Luca Weiss
2023-08-30 10:45 ` Konrad Dybcio
2023-08-30 9:58 ` [PATCH 02/11] nvmem: qfprom: Mark core clk as optional Luca Weiss
2023-08-30 10:03 ` Krzysztof Kozlowski
2023-08-30 14:30 ` Doug Anderson
2023-08-30 14:43 ` Luca Weiss
2023-08-30 14:57 ` Doug Anderson
2023-09-01 14:54 ` Luca Weiss
2023-09-01 15:08 ` Doug Anderson
2023-09-02 11:28 ` Konrad Dybcio
2023-09-04 8:14 ` Luca Weiss
2023-09-01 20:29 ` Trilok Soni
2023-08-30 9:58 ` [PATCH 03/11] arm64: dts: qcom: sc7280: Move qfprom clock to chrome-common Luca Weiss
2023-08-30 10:09 ` Konrad Dybcio
2023-08-31 11:28 ` Luca Weiss
2023-08-30 9:58 ` [PATCH 04/11] arm64: dts: qcom: pm7250b: make SID configurable Luca Weiss
2023-08-30 10:06 ` Krzysztof Kozlowski [this message]
2023-08-31 10:12 ` Luca Weiss
2023-08-31 11:33 ` Dmitry Baryshkov
2023-08-31 11:54 ` Krzysztof Kozlowski
2023-08-31 12:27 ` Dmitry Baryshkov
2023-09-05 8:30 ` Luca Weiss
2023-09-11 8:34 ` Luca Weiss
2023-09-11 9:44 ` Krzysztof Kozlowski
2023-09-11 9:59 ` Luca Weiss
2023-09-11 11:15 ` Krzysztof Kozlowski
2023-09-11 11:22 ` Konrad Dybcio
2023-08-31 12:32 ` Luca Weiss
2023-08-30 9:58 ` [PATCH 05/11] arm64: dts: qcom: pm8350c: Add flash led node Luca Weiss
2023-08-30 9:58 ` [PATCH 06/11] dt-bindings: pinctrl: qcom,sc7280: Allow gpio-reserved-ranges Luca Weiss
2023-08-30 10:08 ` Krzysztof Kozlowski
2023-08-30 11:47 ` Linus Walleij
2023-08-30 9:58 ` [PATCH 07/11] dt-bindings: arm: qcom,ids: Add SoC ID for QCM6490 Luca Weiss
2023-08-30 10:08 ` Krzysztof Kozlowski
2023-08-30 10:16 ` Konrad Dybcio
2023-08-30 9:58 ` [PATCH 08/11] soc: qcom: socinfo: " Luca Weiss
2023-08-30 10:09 ` Krzysztof Kozlowski
2023-08-30 9:58 ` [PATCH 09/11] cpufreq: Add QCM6490 to cpufreq-dt-platdev blocklist Luca Weiss
2023-08-30 10:10 ` Krzysztof Kozlowski
2023-08-31 5:01 ` Viresh Kumar
2023-08-30 9:58 ` [PATCH 10/11] dt-bindings: arm: qcom: Add QCM6490 Fairphone 5 Luca Weiss
2023-08-30 10:13 ` Krzysztof Kozlowski
2023-08-30 9:58 ` [PATCH 11/11] arm64: dts: qcom: qcm6490: Add device-tree for " Luca Weiss
2023-08-30 10:17 ` Krzysztof Kozlowski
2023-08-30 10:45 ` Konrad Dybcio
2023-09-01 14:27 ` Luca Weiss
2023-09-02 11:45 ` Konrad Dybcio
2023-09-04 8:19 ` Luca Weiss
2023-09-14 16:04 ` (subset) [PATCH 00/11] Initial support for the Fairphone 5 smartphone Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b82f4683-e8b5-b424-8f7a-6d2ba1cab61f@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=phone-devel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox