From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f173.google.com (mail-il1-f173.google.com [209.85.166.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3911C21C179 for ; Wed, 6 Aug 2025 23:37:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754523459; cv=none; b=IqGyrqEKsF3ROzncCo27CVk9/FzC9KZVQKU3GRD4IpA1ly70pinJVaTipIYK85wHkFa+4vU6eBzGCwj2YstK/+dDOliH64g9+sXrOAaU4yVj456KBIXWLFeKQvg/86/ZbATAkjNue7ISZZrjtcPlJ115nrOQv8Z3y+9uUsp5pP4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754523459; c=relaxed/simple; bh=Uf9dtk59gFzJjlH8ShXanMDOj+0+ZVxzHKwT8GoMWBA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=X0uoofSovdAKkbDmjDSpGsh5wNX0JrCtckT0/JhoJLVjZ84G/9dt9Kex1I9FPfj+ujYVA3yQGQ82HwbQ46mBdY/zHwrJF0wxTOgyw8NX4WbYhk6L9A4OnP0mTa8SNzFIM84CEF/5F6k2MUYtcaC6rMcrqOqnmYOb8uQjuS4d1p8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=hc7JZeXO; arc=none smtp.client-ip=209.85.166.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="hc7JZeXO" Received: by mail-il1-f173.google.com with SMTP id e9e14a558f8ab-3e40212e6ceso2160785ab.0 for ; Wed, 06 Aug 2025 16:37:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1754523456; x=1755128256; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uw+3hQa1gfaYBGKUs7YEQ5o4Ob+RRHGwFhvrqOMiO6I=; b=hc7JZeXOMuwSTkXWpfDbfnEeLmiZCuCGH0yqIUjOnukaYjVUka1zWX8zv8tNFqkkyN 25l8hWYsBHEmNiyFfntj1MGlDLUGu1z+gpD0h+PxvdqhzPMRNzqdtDKTV7sLEd86jYgT 2xSjrI3J3wnulQWwzse5X4KV4gysAnWA4kQ8I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754523456; x=1755128256; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uw+3hQa1gfaYBGKUs7YEQ5o4Ob+RRHGwFhvrqOMiO6I=; b=g7Z46C0QfXadAjbkBHrzJiPIru2xAUlzDr1HrQv3nTuT5ZfywSXzhUTzj5ChX1KCEh dCfJHIEpOrvT0cj6c51H5d3F2Pg+rtD3FOXw6GUNnXdLSLq9M42HoMJpoIBZdbQ3LM63 +IvEVLQdEUkq968xBcEwgJPa156gb7HRYCxoCP5qp0pd5xlhtxYSXbON9eL9GTH+7d3r juSvCfdp9XLYlzegXChoWdLkbLj+7pA0qcWFzLtRX+ujJYP53F2ddAepHgHNltNev5u9 mlrbMR5Vbeja7o+vl6jkueb0PwM7QcmKBIvqigVS+ZqDo6fzuB3qlHfbpgXDKobF/nZh CYMw== X-Gm-Message-State: AOJu0Yz/sKkc9r0yFOfvL/hTJI+wqUOpl74Ex4KHmZsr+eIn8//ormTM ybpVv7xn0aidWdhdonzQFlrY0YlVfdS3WrRT+CR+NNsp/TgJb6DHrZq4OLhkJv8uYac= X-Gm-Gg: ASbGncvp4J2BfGPFKnybX6m6HMNQyB5TEmETc69sBryyhQDA+CwaMA1X3R37AtlTS6H U91C8+QziSPw71AqemgIX38lppdTNylfd81MmOtZH84sBUT3nilFzdZuMJAlkrRbQV1agWMnbYM +aLtXg2Gn4yD1tDgNIlJWUL5c26dCOaOwcVKH7LCSvEh/0ynCxBDqg3lWaynyHtumBWm/JQM8Y3 rPXbv2KE4Kw/ok/cCeLPMyfVh1WHg50/zOWqIkxvZVo7txCbJuRpvKXCY1AljfNSU5HRcZzqvhR DfSkMR80uYtVu27WG9onQzzeA/DmHitsKdTOpsh9XFLRi3DZ3Cd8RJq997TSRc+15hsdpG9k07x xpswGwOOQhD4ZQ5Er3aWhAFx/alzGAAu4kIOo8h5ptt7fIYqUz5gJKhQ= X-Google-Smtp-Source: AGHT+IGqqJVTA2htapTaUHkMpzxdklgfTGVquWo2AJSzNnJfbuGn+Zh7vo/Di0EaQuQx1JtIkMQcKQ== X-Received: by 2002:a92:cdac:0:b0:3e3:f67a:7dfb with SMTP id e9e14a558f8ab-3e51b882074mr75481485ab.4.1754523456246; Wed, 06 Aug 2025 16:37:36 -0700 (PDT) Received: from [192.168.1.14] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-3e4029a1553sm66302015ab.14.2025.08.06.16.37.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Aug 2025 16:37:35 -0700 (PDT) Message-ID: Date: Wed, 6 Aug 2025 17:37:35 -0600 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] cpupower: repair mangled powercap comment To: cryolitia@uniontech.com, Thomas Renninger , Shuah Khan , "John B. Wyatt IV" , John Kacur Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Wangyuli@uniontech.com, Guanwentao@uniontech.com, Zhanjun@uniontech.com, Shuah Khan References: <20250806-mangled_cpupower-v1-1-1a559130326b@uniontech.com> Content-Language: en-US From: Shuah Khan In-Reply-To: <20250806-mangled_cpupower-v1-1-1a559130326b@uniontech.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/6/25 01:08, Cryolitia PukNgae via B4 Relay wrote: > From: Cryolitia PukNgae > > The current comment exhibits clear patch application artifacts: > 1. A stray '-' prefix indicating failed line removal > 2. Broken sentence structure from improper context patching > > What appears to be version control residue has persisted since its > initial introduction and through the 2022 kernel submission[1]. While > my archaeological efforts only trace back to the 2017 openSUSE patch[2], > the corrupted syntax suggests even older origins that remain elusive - > perhaps maintainers with longer institutional memory could shed light > on its provenance. > > Restore grammatical sanity by: > - Removing the redundant second line with its leading '-' > - Preserving only the primary statement about RAPL hardcoding > - Eliminating the fragmented "should show up" clause > > The result reflects reality without speculative future-proofing. > > 1. https://lore.kernel.org/all/20221123111810.16017-2-trenn@suse.de/ > 2. https://build.opensuse.org/request/show/535512 Lots of information for a simple comment spacing change. What are we fixing here? What happens if we don't fix it? thanks, -- Shuah