Linux Power Management development
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: Daniel Hejduk <danielhejduk@disroot.org>,
	shuah@kernel.org, trenn@suse.com, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH 1/4] Signed-off-by: Daniel Hejduk <danielhejduk@disroot.org>
Date: Fri, 28 Jun 2024 08:53:16 -0600	[thread overview]
Message-ID: <ba4d74fd-6762-4e9d-8346-5f3384cb60ce@linuxfoundation.org> (raw)
In-Reply-To: <20240628092508.3664-2-danielhejduk@disroot.org>

On 6/28/24 03:25, Daniel Hejduk wrote:
> Updating maintainer of the translation.
> 
> Last update to the po file is 5 years old. I will try to complete and
> maintain the translation.
> ---
>   tools/power/cpupower/po/cs.mo | Bin 0 -> 12805 bytes
>   tools/power/cpupower/po/cs.po |   6 +++---
>   2 files changed, 3 insertions(+), 3 deletions(-)
>   create mode 100644 tools/power/cpupower/po/cs.mo

There are multiple things to fix with this patch series.

1. Missing cover letter
2. Binary file included in the patch
3. Subject line doesn't include cpupower. See the format below
    cpupower: -----
4. Change logs are missing are inadquate.
5. Missing version information - this is v2 series

Refer to submitting patches documents in the kernel docs.

Please fix all these problems and resend patches.

thanks,
-- Shuah

  reply	other threads:[~2024-06-28 14:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-27 13:54 [PATCH] Correcting all needs work translations, Adding some transaltion and changing maintainer of the cpupower tool Daniel Hejduk
2024-06-28  9:25 ` [PATCH 1/4] Signed-off-by: Daniel Hejduk <danielhejduk@disroot.org> Daniel Hejduk
2024-06-28 14:53   ` Shuah Khan [this message]
2024-06-28 17:44     ` [PATCH 0/3] Updating maintainer and correcting Czech translation in cpupower Daniel Hejduk
2024-06-28 17:44       ` [PATCH 1/3] Updating cpupower's Czech translation maintainer Daniel Hejduk
2024-06-28 17:44       ` [PATCH 2/3] Correcting needs work strings and adding new to cpupower's Czech translation Daniel Hejduk
2024-06-28 17:44       ` [PATCH 3/3] Adding changelog for cpupower Daniel Hejduk
2024-06-28 19:39       ` [PATCH 0/3] Updating maintainer and correcting Czech translation in cpupower Shuah Khan
2024-06-28 20:13         ` Daniel Hejduk
2024-06-28  9:25 ` [PATCH 2/4] Signed-off-by: Daniel Hejduk <danielhejduk@disroot.org> Daniel Hejduk
2024-06-28  9:25 ` [PATCH 3/4] " Daniel Hejduk
2024-06-28  9:25 ` [PATCH 4/4] " Daniel Hejduk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ba4d74fd-6762-4e9d-8346-5f3384cb60ce@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=danielhejduk@disroot.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=trenn@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox