From: Viresh Kumar <viresh.kumar@linaro.org>
To: Rafael Wysocki <rjw@rjwysocki.net>
Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org,
Viresh Kumar <viresh.kumar@linaro.org>,
open list <linux-kernel@vger.kernel.org>
Subject: [PATCH V5 3/3] cpufreq: ondemand: Rearrange od_dbs_timer() to avoid updating delay
Date: Wed, 10 Feb 2016 12:30:13 +0530 [thread overview]
Message-ID: <bc26edcf43dbd23132ef96c1facd39ae0ed9e257.1455087379.git.viresh.kumar@linaro.org> (raw)
In-Reply-To: <8ddf5eb44eebba01062234d9aed931e3b6882a2b.1455087379.git.viresh.kumar@linaro.org>
In-Reply-To: <8ddf5eb44eebba01062234d9aed931e3b6882a2b.1455087379.git.viresh.kumar@linaro.org>
'delay' is updated properly in all paths of the routine od_dbs_timer(),
leaving just one. And can be 0 only in that case.
Move the update to 'delay' as an else part of the if block.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
drivers/cpufreq/cpufreq_ondemand.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/cpufreq/cpufreq_ondemand.c b/drivers/cpufreq/cpufreq_ondemand.c
index 12213823cc93..0b79f1488be4 100644
--- a/drivers/cpufreq/cpufreq_ondemand.c
+++ b/drivers/cpufreq/cpufreq_ondemand.c
@@ -194,7 +194,7 @@ static unsigned int od_dbs_timer(struct cpufreq_policy *policy)
struct policy_dbs_info *policy_dbs = policy->governor_data;
struct dbs_data *dbs_data = policy_dbs->dbs_data;
struct od_cpu_dbs_info_s *dbs_info = &per_cpu(od_cpu_dbs_info, policy->cpu);
- int delay = 0, sample_type = dbs_info->sample_type;
+ int delay, sample_type = dbs_info->sample_type;
/* Common NORMAL_SAMPLE setup */
dbs_info->sample_type = OD_NORMAL_SAMPLE;
@@ -208,13 +208,12 @@ static unsigned int od_dbs_timer(struct cpufreq_policy *policy)
/* Setup timer for SUB_SAMPLE */
dbs_info->sample_type = OD_SUB_SAMPLE;
delay = dbs_info->freq_hi_jiffies;
+ } else {
+ delay = delay_for_sampling_rate(dbs_data->sampling_rate
+ * dbs_info->rate_mult);
}
}
- if (!delay)
- delay = delay_for_sampling_rate(dbs_data->sampling_rate
- * dbs_info->rate_mult);
-
return delay;
}
--
2.7.1.370.gb2aa7f8
next prev parent reply other threads:[~2016-02-10 7:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-09 3:46 [PATCH V4 0/7] cpufreq: Locking fixes and cleanups Viresh Kumar
2016-02-09 3:46 ` [PATCH V4 1/7] cpufreq: Merge cpufreq_offline_prepare/finish routines Viresh Kumar
2016-02-11 0:59 ` Rafael J. Wysocki
2016-02-11 1:15 ` Rafael J. Wysocki
2016-02-11 11:46 ` Viresh Kumar
2016-02-09 3:46 ` [PATCH V4 2/7] cpufreq: Call __cpufreq_governor() with policy->rwsem held Viresh Kumar
2016-02-11 9:48 ` Rafael J. Wysocki
2016-02-11 11:52 ` Viresh Kumar
2016-02-09 3:46 ` [PATCH V4 3/7] cpufreq: Remove cpufreq_governor_lock Viresh Kumar
2016-02-11 9:53 ` Rafael J. Wysocki
2016-02-09 3:46 ` [PATCH V4 4/7] cpufreq: governor: Move common sysfs tunables to cpufreq_governor.c Viresh Kumar
2016-02-10 0:26 ` Rafael J. Wysocki
2016-02-10 7:00 ` [PATCH V5 1/3] cpufreq: governor: No need to manage state machine now Viresh Kumar
2016-02-10 7:00 ` [PATCH V5 2/3] cpufreq: conservative: Update sample_delay_ns immediately Viresh Kumar
2016-02-10 7:00 ` Viresh Kumar [this message]
2016-02-11 9:58 ` [PATCH V5 1/3] cpufreq: governor: No need to manage state machine now Rafael J. Wysocki
2016-02-09 3:46 ` [PATCH V4 5/7] " Viresh Kumar
2016-02-10 0:36 ` Rafael J. Wysocki
2016-02-10 5:36 ` Viresh Kumar
2016-02-09 3:46 ` [PATCH V4 6/7] cpufreq: conservative: Update sample_delay_ns immediately Viresh Kumar
2016-02-09 3:46 ` [PATCH V4 7/7] cpufreq: ondemand: Rearrange od_dbs_timer() to void updating delay Viresh Kumar
2016-02-10 0:28 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc26edcf43dbd23132ef96c1facd39ae0ed9e257.1455087379.git.viresh.kumar@linaro.org \
--to=viresh.kumar@linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).