From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C6F2C433FE for ; Mon, 31 Jan 2022 15:18:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244422AbiAaPSg (ORCPT ); Mon, 31 Jan 2022 10:18:36 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:58871 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376863AbiAaPS2 (ORCPT ); Mon, 31 Jan 2022 10:18:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643642308; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QAmHJ3ZqJTt7UjSWKk/RmdR+bF1h3fqMtdi/ZP9ycBM=; b=ImHrxUve3vujSaLFtiIVtUikfcnCZyhe99GWpdr1ZRF5KfWr8561qZEmRW6T0vj/ZYyZyM /EmldiDmsS6DYEzvvpBBc5QtIMzQm5K7dhVZGVmrrZWTn8WRjyuaDuQXdgqvRPoT/rLzLh 8I8wZI8qAQpaXRene8XRIf20NZUtJ84= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-1-6HyswF3yOS-FKLULqHw9Jg-1; Mon, 31 Jan 2022 10:18:26 -0500 X-MC-Unique: 6HyswF3yOS-FKLULqHw9Jg-1 Received: by mail-ej1-f70.google.com with SMTP id lb14-20020a170907784e00b006aa178894fcso5151482ejc.6 for ; Mon, 31 Jan 2022 07:18:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=QAmHJ3ZqJTt7UjSWKk/RmdR+bF1h3fqMtdi/ZP9ycBM=; b=tPu+IhPslXDeSIGG8aMNnbcEgFRWhBc5hcuB6cf5M3JemduxAGXd1/vyJkx/ocKKKj pf6/4W7jwbYyz7GxNBaDE/VcNtN5R25ms+DWHyPQSs/WJoX5gjz7uH8pY9iyxGbX52WC Ipwligo14oZ8h3ogWBNeRwMyY0d1VWhkPw0snA4aUrvjN+0eqHpzkJ9SM07yQg7yhtjD +3avQOk9ZwB9QGhZjuz1LRMDo5u05W6OaJwa/mijCEP+b2g+5sPzA5wpA/6BF4DqL+41 S8JUHkLULqHCC4nkCovrDhatG2XVT4k5oXkZuQ/JDjl7eK1X9C1zhFvvgQ/nto++c2tT FMpw== X-Gm-Message-State: AOAM530YCztK/L64DptZly9V/RZoSms2AO3cHHCEzKZ/eFFlDYh5CEtv CUDz6DDiDiqI2igV3VvY7R5yRvjbjPWVpuj3wmCSu0rMksuZkiDhnegBDdBK8NlB6wtuYR5AvhS G37iQ9DDGYz+V8c4F50I= X-Received: by 2002:a17:906:6a0f:: with SMTP id qw15mr17992188ejc.66.1643642305194; Mon, 31 Jan 2022 07:18:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJwghhGi3a8HVBfaCXbVG/NksU+mqLsEfT2UOuHdYNlaoGRK5E2h8OZRKIK5ywYsytO+GY3g4w== X-Received: by 2002:a17:906:6a0f:: with SMTP id qw15mr17992163ejc.66.1643642304969; Mon, 31 Jan 2022 07:18:24 -0800 (PST) Received: from [10.40.98.142] ([78.108.130.194]) by smtp.gmail.com with ESMTPSA id co19sm18008399edb.7.2022.01.31.07.18.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Jan 2022 07:18:24 -0800 (PST) Message-ID: Date: Mon, 31 Jan 2022 16:18:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH v4 12/20] power: supply: bq25890: Support higher charging voltages through Pump Express+ protocol Content-Language: en-US To: Andy Shevchenko Cc: "Rafael J . Wysocki" , Mika Westerberg , Mark Gross , Andy Shevchenko , Wolfram Sang , Lee Jones , Sebastian Reichel , MyungJoo Ham , Chanwoo Choi , Ard Biesheuvel , Len Brown , linux-acpi@vger.kernel.org, Yauhen Kharuzhy , Tsuchiya Yuto , Fabio Aiuto , platform-driver-x86@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org References: <20220130204557.15662-1-hdegoede@redhat.com> <20220130204557.15662-13-hdegoede@redhat.com> From: Hans de Goede In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Hi, On 1/31/22 14:48, Andy Shevchenko wrote: > On Sun, Jan 30, 2022 at 09:45:49PM +0100, Hans de Goede wrote: >> From: Yauhen Kharuzhy >> >> Add a "linux,pump-express-vbus-max" property which indicates if the Pump >> Express+ protocol should be used to increase the charging protocol. >> >> If this new property is set and a DCP charger is detected then request >> a higher charging voltage through the Pump Express+ protocol. >> >> So far this new property is only used on x86/ACPI (non devicetree) devs, >> IOW it is not used in actual devicetree files. The devicetree-bindings >> maintainers have requested properties like these to not be added to the >> devicetree-bindings, so the new property is deliberately not added >> to the existing devicetree-bindings. >> >> Changes by Hans de Goede: >> - Port to my bq25890 patch-series + various cleanups >> - Make behavior configurable through a new "linux,pump-express-vbus-max" >> device-property >> - Sleep 1 second before re-checking the Vbus voltage after requesting >> it to be raised, to ensure that the ADC has time to sampled the new Vbus >> - Add VBUSV bq25890_tables[] entry and use it in bq25890_get_vbus_voltage() >> - Tweak commit message > > ... > >> +static void bq25890_pump_express_work(struct work_struct *data) >> +{ >> + struct bq25890_device *bq = >> + container_of(data, struct bq25890_device, pump_express_work.work); >> + int voltage, i, ret; >> + >> + dev_dbg(bq->dev, "Start to request input voltage increasing\n"); >> + >> + /* Enable current pulse voltage control protocol */ >> + ret = bq25890_field_write(bq, F_PUMPX_EN, 1); >> + if (ret < 0) >> + goto error_print; >> + >> + for (i = 0; i < PUMP_EXPRESS_MAX_TRIES; i++) { > >> + voltage = bq25890_get_vbus_voltage(bq); >> + if (voltage < 0) >> + goto error_print; > > It also can be (at least in align with the rest error paths) > > ret = bq25890_get_vbus_voltage(bq); > if (ret < 0) > goto error_print; > voltage = ret; > > followed up (but not necessarily)... The suggested pattern is useful when ret needs to be set on the error-exit path, but we are not doing that here. So I prefer to just keep this as is. Regards, Hans > >> + dev_dbg(bq->dev, "input voltage = %d uV\n", voltage); >> + >> + if ((voltage + PUMP_EXPRESS_VBUS_MARGIN_uV) > >> + bq->pump_express_vbus_max) >> + break; >> + >> + ret = bq25890_field_write(bq, F_PUMPX_UP, 1); >> + if (ret < 0) >> + goto error_print; >> + >> + /* Note a single PUMPX up pulse-sequence takes 2.1s */ >> + ret = regmap_field_read_poll_timeout(bq->rmap_fields[F_PUMPX_UP], >> + ret, !ret, 100000, 3000000); >> + if (ret < 0) >> + goto error_print; >> + >> + /* Make sure ADC has sampled Vbus before checking again */ >> + msleep(1000); >> + } >> + >> + bq25890_field_write(bq, F_PUMPX_EN, 0); >> + >> + dev_info(bq->dev, "Hi-voltage charging requested, input voltage is %d mV\n", >> + voltage); > >> + return; >> +error_print: > > if (ret < 0) > > But it's up to you. > >> + dev_err(bq->dev, "Failed to request hi-voltage charging\n"); >> +} >