* [PATCH] cpufreq: CPPC: Avoid overflow when calculating desired_perf
@ 2016-09-14 23:08 Hoan Tran
2016-09-15 0:50 ` Rafael J. Wysocki
0 siblings, 1 reply; 4+ messages in thread
From: Hoan Tran @ 2016-09-14 23:08 UTC (permalink / raw)
To: Rafael J. Wysocki, Viresh Kumar, pprakash, Al Stone
Cc: linux-pm, linux-kernel, lho, Duc Dang, Hoan Tran
This patch fixes overflow issue when calculating the desired_perf.
Signed-off-by: Hoan Tran <hotran@apm.com>
---
drivers/cpufreq/cppc_cpufreq.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c
index 894e465..3e0961e 100644
--- a/drivers/cpufreq/cppc_cpufreq.c
+++ b/drivers/cpufreq/cppc_cpufreq.c
@@ -84,7 +84,8 @@ static int cppc_cpufreq_set_target(struct cpufreq_policy *policy,
cpu = all_cpu_data[policy->cpu];
- cpu->perf_ctrls.desired_perf = target_freq * policy->max / cppc_dmi_max_khz;
+ cpu->perf_ctrls.desired_perf =
+ (u64)target_freq * policy->max / cppc_dmi_max_khz;
freqs.old = policy->cur;
freqs.new = target_freq;
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] cpufreq: CPPC: Avoid overflow when calculating desired_perf
2016-09-14 23:08 [PATCH] cpufreq: CPPC: Avoid overflow when calculating desired_perf Hoan Tran
@ 2016-09-15 0:50 ` Rafael J. Wysocki
2016-09-15 3:06 ` Hoan Tran
0 siblings, 1 reply; 4+ messages in thread
From: Rafael J. Wysocki @ 2016-09-15 0:50 UTC (permalink / raw)
To: Hoan Tran
Cc: Viresh Kumar, pprakash, Al Stone, linux-pm, linux-kernel, lho,
Duc Dang
On Wednesday, September 14, 2016 04:08:28 PM Hoan Tran wrote:
> This patch fixes overflow issue when calculating the desired_perf.
>
> Signed-off-by: Hoan Tran <hotran@apm.com>
> ---
> drivers/cpufreq/cppc_cpufreq.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c
> index 894e465..3e0961e 100644
> --- a/drivers/cpufreq/cppc_cpufreq.c
> +++ b/drivers/cpufreq/cppc_cpufreq.c
> @@ -84,7 +84,8 @@ static int cppc_cpufreq_set_target(struct cpufreq_policy *policy,
>
> cpu = all_cpu_data[policy->cpu];
>
> - cpu->perf_ctrls.desired_perf = target_freq * policy->max / cppc_dmi_max_khz;
> + cpu->perf_ctrls.desired_perf =
> + (u64)target_freq * policy->max / cppc_dmi_max_khz;
> freqs.old = policy->cur;
> freqs.new = target_freq;
That's on top of the CPPC material in linux-next I gather?
Which commit does it fix?
Thanks,
Rafael
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] cpufreq: CPPC: Avoid overflow when calculating desired_perf
2016-09-15 0:50 ` Rafael J. Wysocki
@ 2016-09-15 3:06 ` Hoan Tran
2016-09-19 18:54 ` Al Stone
0 siblings, 1 reply; 4+ messages in thread
From: Hoan Tran @ 2016-09-15 3:06 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Viresh Kumar, Prashanth Prakash, Al Stone, linux-pm, lkml, Loc Ho,
Duc Dang
Hi Rafael,
On Wed, Sep 14, 2016 at 5:50 PM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> On Wednesday, September 14, 2016 04:08:28 PM Hoan Tran wrote:
>> This patch fixes overflow issue when calculating the desired_perf.
>>
>> Signed-off-by: Hoan Tran <hotran@apm.com>
>> ---
>> drivers/cpufreq/cppc_cpufreq.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c
>> index 894e465..3e0961e 100644
>> --- a/drivers/cpufreq/cppc_cpufreq.c
>> +++ b/drivers/cpufreq/cppc_cpufreq.c
>> @@ -84,7 +84,8 @@ static int cppc_cpufreq_set_target(struct cpufreq_policy *policy,
>>
>> cpu = all_cpu_data[policy->cpu];
>>
>> - cpu->perf_ctrls.desired_perf = target_freq * policy->max / cppc_dmi_max_khz;
>> + cpu->perf_ctrls.desired_perf =
>> + (u64)target_freq * policy->max / cppc_dmi_max_khz;
>> freqs.old = policy->cur;
>> freqs.new = target_freq;
>
> That's on top of the CPPC material in linux-next I gather?
Yes, it's on TOP of linux-next.
>
> Which commit does it fix?
This is a fix for ad38677df44b67e0f5b6c4d31e9c2734abde8ed9 (cpufreq:
CPPC: Force reporting values in KHz to fix user space interface)
http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/drivers/cpufreq/cppc_cpufreq.c?id=ad38677df44b67e0f5b6c4d31e9c2734abde8ed9
Thanks
Hoan
>
> Thanks,
> Rafael
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] cpufreq: CPPC: Avoid overflow when calculating desired_perf
2016-09-15 3:06 ` Hoan Tran
@ 2016-09-19 18:54 ` Al Stone
0 siblings, 0 replies; 4+ messages in thread
From: Al Stone @ 2016-09-19 18:54 UTC (permalink / raw)
To: Hoan Tran, Rafael J. Wysocki
Cc: Viresh Kumar, Prashanth Prakash, linux-pm, lkml, Loc Ho, Duc Dang
On 09/14/2016 09:06 PM, Hoan Tran wrote:
> Hi Rafael,
>
> On Wed, Sep 14, 2016 at 5:50 PM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
>> On Wednesday, September 14, 2016 04:08:28 PM Hoan Tran wrote:
>>> This patch fixes overflow issue when calculating the desired_perf.
>>>
>>> Signed-off-by: Hoan Tran <hotran@apm.com>
>>> ---
>>> drivers/cpufreq/cppc_cpufreq.c | 3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c
>>> index 894e465..3e0961e 100644
>>> --- a/drivers/cpufreq/cppc_cpufreq.c
>>> +++ b/drivers/cpufreq/cppc_cpufreq.c
>>> @@ -84,7 +84,8 @@ static int cppc_cpufreq_set_target(struct cpufreq_policy *policy,
>>>
>>> cpu = all_cpu_data[policy->cpu];
>>>
>>> - cpu->perf_ctrls.desired_perf = target_freq * policy->max / cppc_dmi_max_khz;
>>> + cpu->perf_ctrls.desired_perf =
>>> + (u64)target_freq * policy->max / cppc_dmi_max_khz;
>>> freqs.old = policy->cur;
>>> freqs.new = target_freq;
>>
>> That's on top of the CPPC material in linux-next I gather?
>
> Yes, it's on TOP of linux-next.
>
>>
>> Which commit does it fix?
>
> This is a fix for ad38677df44b67e0f5b6c4d31e9c2734abde8ed9 (cpufreq:
> CPPC: Force reporting values in KHz to fix user space interface)
> http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/drivers/cpufreq/cppc_cpufreq.c?id=ad38677df44b67e0f5b6c4d31e9c2734abde8ed9
>
> Thanks
> Hoan
>
>>
>> Thanks,
>> Rafael
>>
Nice catch, Hoan. Thanks!
--
ciao,
al
-----------------------------------
Al Stone
Software Engineer
Red Hat, Inc.
ahs3@redhat.com
-----------------------------------
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-09-19 18:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-14 23:08 [PATCH] cpufreq: CPPC: Avoid overflow when calculating desired_perf Hoan Tran
2016-09-15 0:50 ` Rafael J. Wysocki
2016-09-15 3:06 ` Hoan Tran
2016-09-19 18:54 ` Al Stone
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).