From: Patryk Wlazlyn <patryk.wlazlyn@linux.intel.com>
To: Len Brown <lenb@kernel.org>
Cc: len.brown@intel.com, linux-pm@vger.kernel.org
Subject: Re: [PATCH 4/4] tools/power turbostat: Add reading aperf and mperf via perf API
Date: Mon, 15 Jan 2024 11:28:15 +0100 [thread overview]
Message-ID: <be5911d1-5364-48c5-aefd-9f37e56feefd@linux.intel.com> (raw)
In-Reply-To: <CAJvTdKkX8LAY5ZOzodzJWS3hafaF5094s1aRNsxXMh3Xfky8jg@mail.gmail.com>
> When this patch is applied (on top of the --no-msr patch), then with
> --no-msr, we should still see Busy%, Avg_Mhz, Bzy_MHz, and IPC -- but
> we do not.
That's true only on some platforms, unfortunately. It's because, to get
the tsc_tweak we need to read an MSR. That being said, there are
platforms that do not require the tsc_tweak and I got it working, but
after rebasing I must have left too many bits in the
bic_disable_msr_access() and now we are being "too conservative" about it.
Will fix.
prev parent reply other threads:[~2024-01-15 10:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-12 12:48 [PATCH 0/4] turbostat msr, perf controls and aperf/mperf via perf Patryk Wlazlyn
2024-01-12 12:48 ` [PATCH 1/4] tools/power turbostat: Add --no-msr option Patryk Wlazlyn
2024-01-13 1:00 ` Len Brown
2024-01-15 12:58 ` Patryk Wlazlyn
2024-01-12 12:48 ` [PATCH 2/4] tools/power turbostat: Add --no-perf option Patryk Wlazlyn
2024-01-13 1:03 ` Len Brown
2024-01-12 12:48 ` [PATCH 3/4] tools/power turbostat: Don't print invalid ucode revision Patryk Wlazlyn
2024-01-13 1:15 ` Len Brown
2024-01-12 12:48 ` [PATCH 4/4] tools/power turbostat: Add reading aperf and mperf via perf API Patryk Wlazlyn
2024-01-13 1:42 ` Len Brown
2024-01-15 10:28 ` Patryk Wlazlyn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be5911d1-5364-48c5-aefd-9f37e56feefd@linux.intel.com \
--to=patryk.wlazlyn@linux.intel.com \
--cc=len.brown@intel.com \
--cc=lenb@kernel.org \
--cc=linux-pm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox