From: Jon Hunter <jonathanh@nvidia.com>
To: Guenter Roeck <linux@roeck-us.net>, Ninad Malwade <nmalwade@nvidia.com>
Cc: treding@nvidia.com, jdelvare@suse.com, nicolinc@nvidia.com,
rkasirajan@nvidia.com, linux-hwmon@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH] [WAR] hwmon: (ina3221) Apply software WAR to offset shunt voltage
Date: Thu, 17 Nov 2022 14:57:20 +0000 [thread overview]
Message-ID: <bf577f21-6c3c-8fb3-9150-17e7500c4c7d@nvidia.com> (raw)
In-Reply-To: <20221117144709.GD664755@roeck-us.net>
On 17/11/2022 14:47, Guenter Roeck wrote:
> On Thu, Nov 17, 2022 at 04:32:26PM +0800, Ninad Malwade wrote:
>> This is used as a software WAR to offset shunt voltage reading
>
> What is a software WAR ? Or a WAR in the first place ?
> What is the relevance of the "[WAR]" tag in the subject ?
>
> None of the definitions at https://acronyms.thefreedictionary.com/WAR
> seem to apply. I am sure it means something for you, and it seems to be
> important enough to use the term repeatedly, but please do not assume
> that others know what it means.
Indeed. I will work with Ninad to correct this.
>> from INA3221 to increase its accuracy. This patch implements a
>> previous downstream feature by reading the offset information
>> from DT and apply it to current readings.
>>
>
> Where is the devicetree documentation ?
Yes that is also missing. Let me sync up with Ninad offline and get this
re-worked properly.
Jon
--
nvpublic
prev parent reply other threads:[~2022-11-17 14:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 8:32 [PATCH] [WAR] hwmon: (ina3221) Apply software WAR to offset shunt voltage Ninad Malwade
2022-11-17 14:47 ` Guenter Roeck
2022-11-17 14:57 ` Jon Hunter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf577f21-6c3c-8fb3-9150-17e7500c4c7d@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=nicolinc@nvidia.com \
--cc=nmalwade@nvidia.com \
--cc=rkasirajan@nvidia.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox