From: Kenneth Crudup <kenny@panix.com>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>,
Kenneth Crudup <kenny@panix.com>
Cc: vidyas@nvidia.com, bhelgaas@google.com,
andrea.righi@canonical.com, vicamo.yang@canonical.com,
linux-pm@vger.kernel.org
Subject: Re: My AlderLake Dell (XPS-9320) needs these patches to get full standby/low-power modes
Date: Wed, 17 Jul 2024 16:46:27 -0700 [thread overview]
Message-ID: <bff3e11e-7b60-4e23-933a-3e84fd82aabc@panix.com> (raw)
In-Reply-To: <CAAd53p7NpwK11AyMtAOiFxAEJ8Ho=V=93gwje_2j=h3a=L5G9Q@mail.gmail.com>
Seems to be working OK, I do think running power states seem to be
spending more time in pc10/cpuLPI/SysLPI, but that's just
seat-of-the-pants though.
While-suspended battery drain seems about the same, however:
----
[E130] 518 /home/kenny> cat /tmp/battery-levels
suspend-in: Wed, 17 Jul 2024 09:33:33 -0700
/sys/power/wakeup_count:46
/sys/power/suspend_stats/success:0
/sys/class/power_supply/BAT0/charge_full:3882000
/sys/class/power_supply/BAT0/capacity:100
/sys/class/power_supply/BAT0/voltage_now:12856000
/sys/class/power_supply/BAT0/status:Full
/sys/class/power_supply/BAT0/capacity_level:Full
/sys/devices/system/cpu/cpuidle/low_power_idle_system_residency_us:0
/sys/kernel/debug/pmc_core/slp_s0_residency_usec:0
----------
suspend-out: Wed, 17 Jul 2024 16:38:37 -0700
/sys/kernel/debug/pmc_core/slp_s0_residency_usec:0
/sys/devices/system/cpu/cpuidle/low_power_idle_system_residency_us:0
/sys/class/power_supply/BAT0/charge_full:3882000
/sys/class/power_supply/BAT0/capacity:89
/sys/class/power_supply/BAT0/voltage_now:12206000
/sys/class/power_supply/BAT0/status:Discharging
/sys/class/power_supply/BAT0/capacity_level:Normal
/sys/power/suspend_stats/success:1
/sys/power/wakeup_count:52
==================================================
[17/16:44:11 kenny@xps-9320]
----
On 7/16/24 18:59, Kai-Heng Feng wrote:
> Hi Kenneth,
>
> On Tue, Jul 16, 2024 at 2:27 AM Kenneth Crudup <kenny@panix.com> wrote:
>>
>>
>> No joy yet for 6.10, so here's my patches, maybe it'll save someone some
>> time (they're pretty much the same as 6.9) .
>>
>> Fingers crossed for 6.11!
>
> I forgot to Cc you when I sent the patch [0].
>
> It will be great if you can test it out.
>
> [0] https://lore.kernel.org/linux-pci/20240530085227.91168-1-kai.heng.feng@canonical.com/
>
> Kai-Heng
>
>>
>> -Kenny
>>
>> On 3/21/24 03:12, Kai-Heng Feng wrote:
>>> Hi Kenneth,
>>>
>>> On Tue, Mar 12, 2024 at 10:37 AM Kenneth R. Crudup <kenny@panix.com> wrote:
>>>>
>>>>
>>>> On Sat, 4 Nov 2023, Kenneth R. Crudup wrote:
>>>>
>>>>> The only release kernel that was able to get this laptop to fully get into
>>>>> low-power (unfortunately only s0ix) was the Ubuntu-6.2.0- ... series from Ubuntu
>>>>
>>>>> I'd bisected it to the following commits:
>>>>> 4ff116d0d5fd PCI/ASPM: Save L1 PM Substates Capability for suspend/resume
>>>>> 5e85eba6f50d PCI/ASPM: Refactor L1 PM Substates Control Register programming
>>>>> 1a0102a08f20 UBUNTU: SAUCE: PCI/ASPM: Enable ASPM for links under VMD domain
>>>>> 47c7bfd31514 UBUNTU: SAUCE: PCI/ASPM: Enable LTR for endpoints behind VMD
>>>>> 154d48da2c57 UBUNTU: SAUCE: vmd: fixup bridge ASPM by driver name instead
>>>>
>>>> Since (for what I'm sure is a good reason ... I hope :) ) this has yet to make
>>>> it into mainline, here's the set of commits refactored for v6.8; maybe someone
>>>> scanning the archives for a solution to their Dell draining too much power can
>>>> use them.
>>>>
>>>> But is there anything I can do to help these go in? I saw that "Refactor L1
>>>> PM Substates Control Register programming" is still reverted, is that still
>>>> an issue on the machine it affected?
>>>
>>> Let me work on this.
>>>
>>> I think both VMD and Thunderbolt devices need ASPM enabled by default
>>> regardless of BIOS setting, but I am not sure if PCI folks will like
>>> the idea.
>>>
>>> Kai-Heng
>>>
>>>>
>>>> -Kenny
>>>>
>>>> --
>>>> Kenneth R. Crudup / Sr. SW Engineer, Scott County Consulting, Orange County CA
>>>
>>
>> --
>> Kenneth R. Crudup / Sr. SW Engineer, Scott County Consulting, Orange
>> County CA
>
--
Kenneth R. Crudup / Sr. SW Engineer, Scott County Consulting, Orange
County CA
next prev parent reply other threads:[~2024-07-17 23:46 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-04 17:13 My AlderLake Dell (XPS-9320) needs these patches to get full standby/low-power modes Kenneth R. Crudup
2023-11-06 18:11 ` Bjorn Helgaas
2023-11-07 11:15 ` Mika Westerberg
2023-11-16 20:10 ` David E. Box
2023-11-16 23:18 ` Bjorn Helgaas
2023-11-16 23:27 ` Matthew Garrett
2023-11-18 0:21 ` David E. Box
2023-12-21 1:19 ` David E. Box
2023-12-27 0:03 ` Bjorn Helgaas
2024-05-13 5:23 ` Kenneth R. Crudup
2023-11-08 15:44 ` Kenneth R. Crudup
2023-11-08 11:45 ` Kai-Heng Feng
2023-11-08 15:46 ` Kenneth R. Crudup
2024-03-12 2:37 ` Kenneth R. Crudup
2024-03-21 10:12 ` Kai-Heng Feng
2024-07-15 18:27 ` Kenneth Crudup
2024-07-17 1:59 ` Kai-Heng Feng
2024-07-17 3:39 ` Kenneth Crudup
2024-07-17 4:40 ` Kenneth Crudup
2024-07-17 23:46 ` Kenneth Crudup [this message]
2024-12-11 23:26 ` Kenneth Crudup
2024-12-12 20:56 ` Bjorn Helgaas
2024-12-12 23:04 ` Kenneth Crudup
2024-12-12 23:13 ` Kenneth Crudup
2024-12-13 16:43 ` Bjorn Helgaas
2024-12-13 19:48 ` Kenneth Crudup
2024-12-13 20:27 ` Kenneth Crudup
2024-12-13 22:26 ` Kenneth Crudup
2024-12-13 22:33 ` Kenneth Crudup
2024-12-13 23:02 ` Bjorn Helgaas
2024-12-19 16:25 ` David E. Box
2024-12-19 18:17 ` Kenneth Crudup
2024-12-19 19:52 ` David E. Box
2024-12-19 20:37 ` Kenneth Crudup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bff3e11e-7b60-4e23-933a-3e84fd82aabc@panix.com \
--to=kenny@panix.com \
--cc=andrea.righi@canonical.com \
--cc=bhelgaas@google.com \
--cc=kai.heng.feng@canonical.com \
--cc=linux-pm@vger.kernel.org \
--cc=vicamo.yang@canonical.com \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).