[Bug 217618] New: Changing maximum frequency and boost state does not work with amd-pstate in passive mode plus the schedutil governor

[Bug 217618] New: Changing maximum frequency and boost state does not work with amd-pstate in passive mode plus the schedutil governor

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=217618

            Bug ID: 217618
           Summary: Changing maximum frequency and boost state does not
                    work with amd-pstate in passive mode plus the
                    schedutil governor
           Product: Power Management
           Version: 2.5
    Kernel Version: 6.4.0
          Hardware: AMD
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P3
         Component: cpufreq
          Assignee: linux-pm@vger.kernel.org
          Reporter: putr4.s@gmail.com
                CC: ray.huang@amd.com
        Regression: No

I have a HP Omen 16-n0000 laptop with a Ryzen 7 6800H, and if I have amd-pstate
set to passive mode (either by booting with `amd_pstate=passive` kernel cmdline
or by running `echo "passive" | sudo tee
/sys/devices/system/cpu/amd_pstate/status` on runtime) and the governor left to
the default schedutil then changing the maximum allowed frequency (via `sudo
cpupower frequency-set -g 3200MHz` for example) does nothing, the CPU
frequencies (and temperatures along with it) still goes up high. Disabling
boost via `echo 0 | sudo tee /sys/devices/system/cpu/cpufreq/boost` also does
not work with the schedutil governor.

However, if I switch to the ondemand governor then both the boost and maximum
frequency settings work as expected.

The distro I am using is Arch Linux, with kernel 6.4.0 from the testing repo,
although this issue has been present since at least kernel 6.2.x when I first
got this laptop. I can recompile the kernel myself to test patches if there are
any.

Also, for what it's worth amd-pstate in guided mode also ignores both the
maximum frequency and boost knobs, but it does that with both the schedutil and
ondemand governors so I guess that's expected(?).

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are the assignee for the bug.

[Bug 217618] Changing maximum frequency and boost state does not work with amd-pstate in passive mode plus the schedutil governor

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=217618

Perry Yuan(AMD) (Perry.Yuan@amd.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |Perry.Yuan@amd.com

--- Comment #1 from Perry Yuan(AMD) (Perry.Yuan@amd.com) ---
Hi Sariputra, 

thank you for reporting this issue, could you let me know the values of your
system?

# cat /sys/devices/system/cpu/cpu*/cpufreq/amd_pstate_max_freq
# cat /sys/devices/system/cpu/cpu*/acpi_cppc/highest_perf

Perry.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are the assignee for the bug.

[Bug 217618] Changing maximum frequency and boost state does not work with amd-pstate in passive mode plus the schedutil governor

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=217618

--- Comment #2 from Prajna Sariputra (putr4.s@gmail.com) ---
Here is the output of the first command:
4785000
4785000
4785000
4785000
4785000
4785000
4785000
4785000
4785000
4785000
4785000
4785000
4785000
4785000
4785000
4785000

And here is the output for the second one:
191
196
196
166
166
186
186
191
181
181
176
176
196
196
171
171

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are the assignee for the bug.

[Bug 217618] Changing maximum frequency and boost state does not work with amd-pstate in passive mode plus the schedutil governor

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=217618

--- Comment #3 from Perry Yuan(AMD) (Perry.Yuan@amd.com) ---
Thanks for your info share, I guess the boost and scaling_max have something
need to be improved when user try to limit the max frequency.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are the assignee for the bug.

[Bug 217618] Changing maximum frequency and boost state does not work with amd-pstate in passive mode plus the schedutil governor

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=217618

--- Comment #4 from Perry Yuan(AMD) (Perry.Yuan@amd.com) ---
I have implemented a new boost control with a patchset that are under internal
viewing. it works for both the passive and active mode.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are the assignee for the bug.

[Bug 217618] Changing maximum frequency and boost state does not work with amd-pstate in passive mode plus the schedutil governor

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=217618

Prajna Sariputra (putr4.s@gmail.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |CODE_FIX

--- Comment #5 from Prajna Sariputra (putr4.s@gmail.com) ---
With kernel 6.9.0, it looks like limiting the frequency control now works in
both active and passive mode, and in the latter case both the schedutil and
ondemand governors respect the frequency limit, so this appears to be fixed for
me, thanks!

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are the assignee for the bug.

[Bug 217618] Changing maximum frequency and boost state does not work with amd-pstate in passive mode plus the schedutil governor

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=217618

--- Comment #6 from Perry Yuan(AMD) (Perry.Yuan@amd.com) ---
(In reply to Prajna Sariputra from comment #5)
> With kernel 6.9.0, it looks like limiting the frequency control now works in
> both active and passive mode, and in the latter case both the schedutil and
> ondemand governors respect the frequency limit, so this appears to be fixed
> for me, thanks!

good to know that. 
thanks for your feedback. 

Perry.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are the assignee for the bug.