[Bug 218041] Buffer overrun in devfreq trans_stat_show()

[Bug 218041] Buffer overrun in devfreq trans_stat_show()

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218041

Artem S. Tashkinov (aros@gmx.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Other                       |cpufreq
           Assignee|drivers_other@kernel-bugs.o |linux-pm@vger.kernel.org
                   |sdl.org                     |
            Product|Drivers                     |Power Management

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are the assignee for the bug.

[Bug 218041] Buffer overrun in devfreq trans_stat_show()

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218041

Artem S. Tashkinov (aros@gmx.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ansuelsmth@gmail.com

--- Comment #1 from Artem S. Tashkinov (aros@gmx.com) ---
Christian, could you take a look please?

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are the assignee for the bug.

[Bug 218041] Buffer overrun in devfreq trans_stat_show()

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218041

Artem S. Tashkinov (aros@gmx.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cwchoi00@gmail.com

--- Comment #2 from Artem S. Tashkinov (aros@gmx.com) ---
CC'ing Chanwoo as well.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are the assignee for the bug.

[Bug 218041] Buffer overrun in devfreq trans_stat_show()

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218041

--- Comment #3 from Christian Marangi (Ansuel) (ansuelsmth@gmail.com) ---
Can you describe the amount of frequency? An easy fix would be truncating the
output but I don't think it would be a correct fix...

If there isn't a bug in how the char are count I feel like the only solution is
moving this to debugfs where there isn't the PAGE_SIZE limit.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are the assignee for the bug.

[Bug 218041] Buffer overrun in devfreq trans_stat_show()

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218041

--- Comment #4 from tnifc@protonmail.com ---
(In reply to Christian Marangi (Ansuel) from comment #3)
> Can you describe the amount of frequency?

There are 20 available frequencies on the Tegra 30 "Ouya" device.

$ cat /sys/class/devfreq/6000c800.actmon/available_frequencies  
12750000 25500000 27000000 51000000 54000000 102000000 108000000 204000000
266500000 333500000 375000000 400000000 416000000 450000000 500000000 533000000
625000000 667000000 750000000 800000000

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are the assignee for the bug.

[Bug 218041] Buffer overrun in devfreq trans_stat_show()

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218041

--- Comment #5 from Christian Marangi (Ansuel) (ansuelsmth@gmail.com) ---
Thanks for the report. I checked how the equivalent function for cpufreq works
and as I tought it does fail the thing to write exceed PAGE_SIZE. I sent a
patch upstream that fix the missing check.

sysfs stuff is ABI so moving this to debugfs is a no go (due to we don't break
userspace rule) so this is the only solution currently.

If accepted, it will be queued for stable backport.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are the assignee for the bug.

[Bug 218041] Buffer overrun in devfreq trans_stat_show()

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218041

--- Comment #6 from Christian Marangi (Ansuel) (ansuelsmth@gmail.com) ---
BTW this has been fixed upstream and got backported. This can be closed as
fixed.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are the assignee for the bug.

[Bug 218041] Buffer overrun in devfreq trans_stat_show()

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218041

tnifc@protonmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |CODE_FIX

--- Comment #7 from tnifc@protonmail.com ---
Thanks.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are the assignee for the bug.