From: Dmitry Osipenko <digetx@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] PM / devfreq: tegra30: disable clock on error in probe
Date: Mon, 14 Sep 2020 17:28:11 +0300 [thread overview]
Message-ID: <c0621c79-00e4-0fec-c98e-b46e231b30ef@gmail.com> (raw)
In-Reply-To: <20200914141754.GB18329@kadam>
14.09.2020 17:17, Dan Carpenter пишет:
...
>>> Is it doesn't need to reset with reset_contrl_reset()?
>>
>> Hello, Chanwoo!
>>
>> It's reset just before the clk_round_rate() invocation, hence there
>> shouldn't be a need to reset it second time.
>
> Ah... I was looking the wrong code. Plus I don't really know this code
> very well.
>
> If clk_prepare_enable() fails, then I would have assumed we need to call
> reset_control_deassert(). I would have assumed the
> reset_control_assert() and _deassert() functions were paired. So what
> I'm suggesting is something like the following: (I'll resend this if
> it's correct).
The reset shouldn't be deasserted if clk-enable fails.
Reset deassertion should be done only with enabled clock because reset
happens synchronously with a clock tick, otherwise it makes no much
sense to deassert the reset.
Yours current v1 variant is already good to me.
next prev parent reply other threads:[~2020-09-14 14:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200908072627epcas1p41f2c8c2730d42bd8935a40b0ab8122f7@epcas1p4.samsung.com>
2020-09-08 7:25 ` [PATCH] PM / devfreq: tegra30: disable clock on error in probe Dan Carpenter
2020-09-08 13:02 ` Dmitry Osipenko
2020-09-14 7:09 ` Chanwoo Choi
2020-09-14 13:56 ` Dmitry Osipenko
2020-09-14 14:17 ` Dan Carpenter
2020-09-14 14:28 ` Dmitry Osipenko [this message]
2020-09-15 2:00 ` Chanwoo Choi
2020-09-15 2:13 ` Chanwoo Choi
2020-09-15 17:01 ` Dmitry Osipenko
2020-09-16 2:38 ` Chanwoo Choi
2020-09-16 19:07 ` Dmitry Osipenko
2020-09-17 2:32 ` Chanwoo Choi
2020-09-17 21:14 ` Dmitry Osipenko
2020-09-18 9:23 ` Chanwoo Choi
2020-09-20 21:37 ` Dmitry Osipenko
2020-09-23 0:23 ` Dmitry Osipenko
2020-09-23 0:42 ` Chanwoo Choi
2020-09-14 13:57 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0621c79-00e4-0fec-c98e-b46e231b30ef@gmail.com \
--to=digetx@gmail.com \
--cc=cw00.choi@samsung.com \
--cc=dan.carpenter@oracle.com \
--cc=jonathanh@nvidia.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).