From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B23DC00140 for ; Fri, 12 Aug 2022 13:55:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238101AbiHLNy6 (ORCPT ); Fri, 12 Aug 2022 09:54:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234501AbiHLNy4 (ORCPT ); Fri, 12 Aug 2022 09:54:56 -0400 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6976AA8CF4 for ; Fri, 12 Aug 2022 06:54:55 -0700 (PDT) Received: by mail-wr1-x431.google.com with SMTP id z12so1286642wrs.9 for ; Fri, 12 Aug 2022 06:54:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=jM7EPdzO3/8UIbNc27Sgu5Ssc7D/JbAU5jUdYrnh1RQ=; b=j8Sp0Ny1AUyYQrQLBjWgLArXRjmzPu1lvmcKL+902eFWGt+x+95FkQ+LUAsRGB/lG9 Dsd23JA6G0mporl2ukXShKbHFJXlIMyXriCwpi96pWky/eRqATdJp79iylWXQJGFpu9S xi+1UOTIuWDsawV/wl8Dto08G4ACp7h0YnyyjQPSXFK+U1fOlYPha14ooMsaX20r7lCm bpMNJ0Cuqi8z9Q9OwkQszpmVmR4TjAun/1/WWNu7V1kR1ByiV66W7m6jqDWkR+dh6V/z K9XUY1oS+Z8W3lx4hTsBrNot3HvxxwnQizqulHzAO+bfX7BrES7mig84NrV3S9AG12v1 0SRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=jM7EPdzO3/8UIbNc27Sgu5Ssc7D/JbAU5jUdYrnh1RQ=; b=XDtlQOQvZSxL8E7o1hiZEX0jArLSXT8D+sJQFmBSDC00wTqBB2h2ZUOlB5FOiI8s1h JyYysfa35n+sdA7ZQYG/WxJS+uvJmUadCVu/v13A9ShIV+Vi7rWa9z3xfTvVpcw6ubZP VI6ivl0lhvlfL/BHEZDf3McHJip1UDCEfCFxrWYq+t9HHPgvVpTKbVOr7sFbeIrJeHqV yQtq3Z2DhEuU4Dql97PQ4WH4DQXvSOygHlcJieXnZr2F9pxkKuaDGNh+D4npL3KIy9h6 t0e8IK+FccY4eR4hD/P2Uj2LQulpGVqQvIsk/UkM7pP5wNOlMS8bJpR71FiYSGxxY/p+ EqaA== X-Gm-Message-State: ACgBeo1KH++TkjLIx6d3gqsVuExSkZObrFdYnu4+cbS8yhG+CkYH6Q/P M+ShA4BiSznH9NMLyu49ZE+4yw== X-Google-Smtp-Source: AA6agR5Kf8LT3vuuSyA8RzNo0c2gUbzfKa5DRzkQ/uyCoMf8X9uhFvLsN0rMwuIy/15RvIrWqifSIQ== X-Received: by 2002:a05:6000:1acd:b0:220:62c2:bc29 with SMTP id i13-20020a0560001acd00b0022062c2bc29mr2199687wry.620.1660312493881; Fri, 12 Aug 2022 06:54:53 -0700 (PDT) Received: from [192.168.10.46] (146725694.box.freepro.com. [130.180.211.218]) by smtp.googlemail.com with ESMTPSA id bo22-20020a056000069600b0021d80f53324sm2164032wrb.7.2022.08.12.06.54.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Aug 2022 06:54:53 -0700 (PDT) Message-ID: Date: Fri, 12 Aug 2022 15:54:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] thermal/core: Fix lockdep_assert() warning Content-Language: en-US To: Marek Szyprowski Cc: rafael@kernel.org, krzk@kernel.org, rui.zhang@intel.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, amitk@kernel.org, linux-samsung-soc@vger.kernel.org References: <20220812131202.1331238-1-daniel.lezcano@linaro.org> From: Daniel Lezcano In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 12/08/2022 15:34, Marek Szyprowski wrote: > On 12.08.2022 15:12, Daniel Lezcano wrote: >> The function thermal_zone_device_is_enabled() must be called with the >> thermal zone lock held. In the resume path, it is called without. >> >> As the thermal_zone_device_is_enabled() is also checked in >> thermal_zone_device_update(), do the check in resume() function is >> pointless, except for saving an extra initialization which does not >> hurt if it is done in all the cases. >> >> Signed-off-by: Daniel Lezcano > > This fixes the warning I've reported. Feel free to add: > > Reported-by: Marek Szyprowski > > Tested-by: Marek Szyprowski Great, thanks for testing -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog