Linux Power Management development
 help / color / mirror / Atom feed
From: Yiwei Lin <s921975628@gmail.com>
To: Shuah Khan <skhan@linuxfoundation.org>, trenn@suse.com, shuah@kernel.org
Cc: jwyatt@redhat.com, jkacur@redhat.com, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] cpupower: monitor: Exit with error status if execvp() fail
Date: Fri, 21 Feb 2025 01:46:29 +0800	[thread overview]
Message-ID: <c0c8505e-ceb4-4a82-8c3c-8043ee2ce256@gmail.com> (raw)
In-Reply-To: <929c1d63-e3e7-432c-b34a-8953662297ab@linuxfoundation.org>


On 2/21/2025 1:37 AM, Shuah Khan wrote:
> On 2/20/25 09:38, Yiwei Lin wrote:
>> In the case that we give a invalid command to idle_monitor for
>> monitoring, the execvp() will fail and thus go to the next line.
>> As a result, we'll see two differnt monitoring output. For
>> example, running `cpupower monitor -i 5 invalidcmd` which `invalidcmd`
>> is not executable.
>>
>> ---
>
> Note that everything below this gets thrown away.
>
>> V3:
>> - Modify output message content
>>
>> V2:
>> - Check return value from execvp and print message for invalid command
>> ---
>
> These version information goes after the --- below the Signed-off-by
>
> Note that everything below the
>
>>
>> Signed-off-by: Yiwei Lin <s921975628@gmail.com>
>> ---
>
> This where the patch version stuff goes. I fixed this for now.
>
Thank you to help for the fix! I'll be careful with the commit message 
next time. I'm sorry if you experienced any inconvenience with this.

All the best,

Yiwei Lin


      reply	other threads:[~2025-02-20 17:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-20 16:38 [PATCH v3] cpupower: monitor: Exit with error status if execvp() fail Yiwei Lin
2025-02-20 17:37 ` Shuah Khan
2025-02-20 17:46   ` Yiwei Lin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c0c8505e-ceb4-4a82-8c3c-8043ee2ce256@gmail.com \
    --to=s921975628@gmail.com \
    --cc=jkacur@redhat.com \
    --cc=jwyatt@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=trenn@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox