From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3E77279345; Wed, 11 Jun 2025 12:26:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749644773; cv=none; b=kU65ESRg9g6Pky6p3ckr0otOAVZqe9CxAMC5zxT/bGshjbTmqFGPX2vtR+vACJi6nXYxFzdu6cU1jTel/ZvzKODpKav/o7CIb2XIMyM6Dj0jkuHpFwANQwq7hzA/AaRnIHlDYZQpotURLyGR/PaDb9BIOEsuVM/1Ce1dF2hfuts= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749644773; c=relaxed/simple; bh=Ez52NeBMUxcrzUPf0xC9UbNQTDiocdTPSw3oyEp8JjE=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=RA5vDKu3xvKWxNt5fJkHO0VaApDkizf90kRRaInFWCyfTPIvHYc8hGZ7ZDeL6dzg3jzHxXk8ihWrAovcaZzi1mxI6vRDvooSEguod8QsXOjDVylCUq8b5HPvXFsOefBRuKGCjgAvzPhLlqAMe5XeTZdT6ZtFFuOo2VrAnkpTVUg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=CQj851vI; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="CQj851vI" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55B9DENR027189; Wed, 11 Jun 2025 12:25:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= c6dng+NmjwGmVNZ97SvTt6nnPTfoc7CDndqawYoKecA=; b=CQj851vItCeJ03gE a+LrhLjw8M44GfdyTI08L7ooHeA3i1o8mMejPbmKqh7bNtbgFCHph4xuHNjrT8yY 9//tXwnTuzDn+rO15eKB+60jm9Xrw94ZnxDfvBcv3Zm0NWQTh6hVwMzowGEbaseJ ijG7yoGbu5eEtUwAk6eqqWuybWy4wlCcnooIe8wurJ1JOn0ZNHSZaodDNPLOdv0G 9ySLaR99hgeZURErgkDfpt5DVlZacxsDHPs2kPwQ+dTNmtsMuqGr8tLlvro6t7jT dq2/ratIa/jh+yYVDxXXO2W30bQROVDALYpi9qKp9Rcd2T5Av+IsNYBgNB8NnWwO Vg8ZWg== Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 474ccvcuk8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 11 Jun 2025 12:25:43 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA01.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 55BCPglG005497 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 11 Jun 2025 12:25:42 GMT Received: from [10.216.28.79] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Wed, 11 Jun 2025 05:25:33 -0700 Message-ID: Date: Wed, 11 Jun 2025 17:55:30 +0530 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/4] arm64: dts: qcom: Add GPU support to X1P42100 SoC To: Krzysztof Kozlowski , Akhil P Oommen , Catalin Marinas , "Will Deacon" , Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , "Simona Vetter" , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Viresh Kumar , Nishanth Menon , Stephen Boyd CC: , , , , , , References: <20250611-x1p-adreno-v2-0-5074907bebbd@oss.qualcomm.com> <20250611-x1p-adreno-v2-4-5074907bebbd@oss.qualcomm.com> <1ee554e4-d813-47cd-a1ab-9eaa4634cdb1@kernel.org> From: Akhil P Oommen Content-Language: en-US In-Reply-To: <1ee554e4-d813-47cd-a1ab-9eaa4634cdb1@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: LJFgD0crCd2XFLk2fVs6HasaeizgOAS6 X-Authority-Analysis: v=2.4 cv=TsLmhCXh c=1 sm=1 tr=0 ts=684975c7 cx=c_pps a=ouPCqIW2jiPt+lZRy3xVPw==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=GEpy-HfZoHoA:10 a=IkcTkHD0fZMA:10 a=6IFa9wvqVegA:10 a=tElcPi6GYvQhG-JPmBIA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-GUID: LJFgD0crCd2XFLk2fVs6HasaeizgOAS6 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjExMDEwNiBTYWx0ZWRfX8c8v5ENXGd05 UTomTWW1atRegb5wiad2v98e5LBy4Wht46THwUBBrcQqWsRfCcq/z1wzPLpIvlhT2FfEOe/x6ix qBOBVtZmYNPlKIJRBQSffKhlviQBRoegsF8ljM4Dij2DYukxJuxOM2gofQiiRxPMetD1C+7Llkn GIib4wF5G6QOpAYXGhMFaJEJJ1DptOahLaopR0Y2uaPFL2A5bDLOz0D6aZ90CqQv9LiV9Hx/xUO gX4hCzz1ZRcH1zggEVd7sbS6cwXCNupW4XboWeW2aw44S/ZntGKYXCNz/fRQC+KrPy5casNToPr PzC2shXdzflleQX5aeCsqtt4xyWZAuiITaJxVC/BAVF2EnuuX5zgjq9kLYn1zHKAKre7W2v/cpj OlYWmt3J05HiAgPm+ZU/vykHRjPI39DmA27GWmZrpPSMyUoTZA549Mw9TyuEzIHOuiD5vChh X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-11_05,2025-06-10_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 spamscore=0 mlxlogscore=999 impostorscore=0 priorityscore=1501 bulkscore=0 adultscore=0 clxscore=1015 mlxscore=0 malwarescore=0 lowpriorityscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2506110106 On 6/11/2025 4:52 PM, Krzysztof Kozlowski wrote: > On 11/06/2025 13:15, Akhil P Oommen wrote: >> + opp-280000000 { >> + opp-hz = /bits/ 64 <280000000>; >> + opp-level = ; >> + opp-peak-kBps = <2136719>; >> + qcom,opp-acd-level = <0xc82f5ffd>; >> + opp-supported-hw = <0x1f>; >> + }; >> + }; >> + >> }; >> >> &gpucc { >> @@ -41,6 +150,13 @@ &pcie6a_phy { >> compatible = "qcom,x1p42100-qmp-gen4x4-pcie-phy"; >> }; >> >> +&qfprom { >> + gpu_speed_bin: gpu_speed_bin@119 { > > No underscores. You need to align downstream code to upstream. See > coding style. Ack. -Akhil > > > > Best regards, > Krzysztof