From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A67B7C433E4 for ; Mon, 20 Jul 2020 10:38:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 831B922BF3 for ; Mon, 20 Jul 2020 10:38:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="InuP5ggH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728385AbgGTKiO (ORCPT ); Mon, 20 Jul 2020 06:38:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728356AbgGTKiN (ORCPT ); Mon, 20 Jul 2020 06:38:13 -0400 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37DB8C0619D2 for ; Mon, 20 Jul 2020 03:38:13 -0700 (PDT) Received: by mail-wr1-x42d.google.com with SMTP id r12so17222219wrj.13 for ; Mon, 20 Jul 2020 03:38:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=N+KShEFnJxGX9yyx1xEF9LSqKvHu0acMJ8Lfm+hfvF0=; b=InuP5ggHa1/pALofoPR9I3mpWK6lk35q8MGa+FJ0Cza+bBiYtFfAfJifs5zPiJVAKO CSLgdxPzxyqBiXe2uGN/mkOvmK79TKhwicrYic0fPSwbvA1F2oYSeo6BnetKrChAk48K RphsMD8e2J70zfqCIDM8f8/BX73vUE0Z2Ia+w26NKh8JaxhJndQox54CkzJLPm91UjXc DczOioE6l7MGFL2/aBhgWuSQP6Va27Dm3aIXNq//YPAH0ckPXiXknmAjFN1Bo4N8Oyob HjJp9feTK7Mg2/cI61mhCw7+gbtK7C6kpJ+P/DHeZGYRrsZfJ8RoYMxCiT2cGVJ3rtfD ISlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=N+KShEFnJxGX9yyx1xEF9LSqKvHu0acMJ8Lfm+hfvF0=; b=nhGA6z6in01UEIPLBp9TlrWZZFm0uhWninqJrf66Db8Jny4E1Ovq2y2m7O680uqEo/ ON+jf9wzaKIoUm78nqQMov9Ln4/3Q6FZCDJ5BYjii75DIHYWPgBsfd34oCanvdVfxFTz zKdB1YHzhztgz0zD8uxvXm2AP/3UW9cwwiY+E4QTlQH35hz/bxgrTCrjN4tvY4q6jbX0 ue++vJVa02GFWG9tr71z7w6+7wHbu7LsAkYGM+meoH/2wgCUpOINJo3CeEFOB7+7YfEe aBsRixz4v3rrcBQ6MANPMdz8mid1GRmGWWa1nxg4zIILdr7dPkTP0ioQMCdoBuO9RV5v zMoQ== X-Gm-Message-State: AOAM533QFiiKukKz5u6S+sULhpWz8oZYjdpx6Y/To/vkmzQllJbdtJd8 agzrXc2EP20TzAW6IXAVsVWQ7Q== X-Google-Smtp-Source: ABdhPJw1/id93mBovoy22Lfk5BHPwv61GWmvOT4Bygs+7ogCIaqufAY1PEFM0xd4XmzTqhaH/IU8vg== X-Received: by 2002:a5d:548f:: with SMTP id h15mr5097677wrv.331.1595241491766; Mon, 20 Jul 2020 03:38:11 -0700 (PDT) Received: from ?IPv6:2a01:e34:ed2f:f020:3590:b402:869a:11fc? ([2a01:e34:ed2f:f020:3590:b402:869a:11fc]) by smtp.googlemail.com with ESMTPSA id t141sm33345477wmt.26.2020.07.20.03.38.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jul 2020 03:38:11 -0700 (PDT) Subject: Re: [PATCH v4 08/16] thermal: sun8i: add TEMP_CALIB_MASK for calibration data in sun50i_h6_ths_calibrate To: Frank Lee Cc: Frank Lee , Vasily Khoruzhick , Zhang Rui , Amit Kucheria , Maxime Ripard , Chen-Yu Tsai , Linux PM , Linux ARM , Linux Kernel Mailing List , =?UTF-8?B?6buE54OB55Sf?= , liyong@allwinnertech.com References: <4771acd6-ecd3-b8e1-8605-75d78720b1d3@linaro.org> <836e1b23-1c75-57fe-6e45-f7141272071c@linaro.org> From: Daniel Lezcano Message-ID: Date: Mon, 20 Jul 2020 12:38:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 20/07/2020 11:27, Frank Lee wrote: > HI, > On Fri, Jul 17, 2020 at 3:56 PM Daniel Lezcano > wrote: >> >> On 17/07/2020 09:35, Frank Lee wrote: >>> On Fri, Jul 17, 2020 at 12:26 PM Daniel Lezcano >>> wrote: >>>> >>>> On 14/07/2020 09:13, Frank Lee wrote: >>>>> From: Yangtao Li >>>>> >>>>> For sun50i_h6_ths_calibrate(), the data read from nvmem needs a round of >>>>> calculation. On the other hand, the newer SOC may store other data in >>>>> the space other than 12bit sensor data. Add mask operation to read data >>>>> to avoid conversion error. >>>>> >>>>> Signed-off-by: Yangtao Li >>>>> Reviewed-by: Yangtao Li >>>> >>>> Can you clarify these SoB ? >>> >>> Previously I used 'Signed-off-by: Yangtao Li ', >>> maybe this should be removed directly? >>> >>>> >>>> Frank Lee==Yangtao Li==frank@allwinnertech.com==tiny.windzz@gmail.com ? >>>> >>> >>> Yeah. >> >> You are not supposed to add reviewed-by yourself. Please remove it. > > Should I resend the entire series or just the thermal patch? > What about those that have been applied. I can not speak on behalf of other maintainers. The simplest would be to ask them directly. If you want to go forward with the thermal changes, you can send them separately but Maxim's Ack will be needed anyway. -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog