From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Konrad Dybcio <konradybcio@kernel.org>,
Sebastian Reichel <sre@kernel.org>,
linux-pm@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] power: supply: mm8013: Fix an error checking issue in mm8013_checkdevice()
Date: Wed, 27 Sep 2023 15:04:12 +0200 [thread overview]
Message-ID: <c17d93d6-72cf-4ce3-8927-b99be3c53bb5@linaro.org> (raw)
In-Reply-To: <c46b4408-bf1d-408d-9e6b-16b0ad272532@moroto.mountain>
On 27.09.2023 14:41, Dan Carpenter wrote:
> There is a missing "ret = " assignment so this checks the same "ret"
> value twice.
>
> Fixes: c75f4bf6800b ("power: supply: Introduce MM8013 fuel gauge driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
Oh that's a funny mistake
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Thanks!
Konrad
next prev parent reply other threads:[~2023-09-27 13:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-27 12:41 [PATCH] power: supply: mm8013: Fix an error checking issue in mm8013_checkdevice() Dan Carpenter
2023-09-27 13:04 ` Konrad Dybcio [this message]
2023-09-30 20:28 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c17d93d6-72cf-4ce3-8927-b99be3c53bb5@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=dan.carpenter@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).