* [PATCH] power: supply: mm8013: Fix an error checking issue in mm8013_checkdevice()
@ 2023-09-27 12:41 Dan Carpenter
2023-09-27 13:04 ` Konrad Dybcio
2023-09-30 20:28 ` Sebastian Reichel
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2023-09-27 12:41 UTC (permalink / raw)
To: Konrad Dybcio; +Cc: Konrad Dybcio, Sebastian Reichel, linux-pm, kernel-janitors
There is a missing "ret = " assignment so this checks the same "ret"
value twice.
Fixes: c75f4bf6800b ("power: supply: Introduce MM8013 fuel gauge driver")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/power/supply/mm8013.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/supply/mm8013.c b/drivers/power/supply/mm8013.c
index 29fd65fe6545..caa272b03564 100644
--- a/drivers/power/supply/mm8013.c
+++ b/drivers/power/supply/mm8013.c
@@ -53,7 +53,7 @@ static int mm8013_checkdevice(struct mm8013_chip *chip)
if (ret < 0)
return ret;
- regmap_read(chip->regmap, REG_BATID, &val);
+ ret = regmap_read(chip->regmap, REG_BATID, &val);
if (ret < 0)
return ret;
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] power: supply: mm8013: Fix an error checking issue in mm8013_checkdevice()
2023-09-27 12:41 [PATCH] power: supply: mm8013: Fix an error checking issue in mm8013_checkdevice() Dan Carpenter
@ 2023-09-27 13:04 ` Konrad Dybcio
2023-09-30 20:28 ` Sebastian Reichel
1 sibling, 0 replies; 3+ messages in thread
From: Konrad Dybcio @ 2023-09-27 13:04 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Konrad Dybcio, Sebastian Reichel, linux-pm, kernel-janitors
On 27.09.2023 14:41, Dan Carpenter wrote:
> There is a missing "ret = " assignment so this checks the same "ret"
> value twice.
>
> Fixes: c75f4bf6800b ("power: supply: Introduce MM8013 fuel gauge driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
Oh that's a funny mistake
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Thanks!
Konrad
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] power: supply: mm8013: Fix an error checking issue in mm8013_checkdevice()
2023-09-27 12:41 [PATCH] power: supply: mm8013: Fix an error checking issue in mm8013_checkdevice() Dan Carpenter
2023-09-27 13:04 ` Konrad Dybcio
@ 2023-09-30 20:28 ` Sebastian Reichel
1 sibling, 0 replies; 3+ messages in thread
From: Sebastian Reichel @ 2023-09-30 20:28 UTC (permalink / raw)
To: Konrad Dybcio, Dan Carpenter
Cc: Konrad Dybcio, Sebastian Reichel, linux-pm, kernel-janitors
On Wed, 27 Sep 2023 15:41:05 +0300, Dan Carpenter wrote:
> There is a missing "ret = " assignment so this checks the same "ret"
> value twice.
>
>
Applied, thanks!
[1/1] power: supply: mm8013: Fix an error checking issue in mm8013_checkdevice()
commit: 8f8e9b7388514d937843337140f18ceb0f3da6eb
Best regards,
--
Sebastian Reichel <sebastian.reichel@collabora.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-30 20:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-27 12:41 [PATCH] power: supply: mm8013: Fix an error checking issue in mm8013_checkdevice() Dan Carpenter
2023-09-27 13:04 ` Konrad Dybcio
2023-09-30 20:28 ` Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).