From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93121C4332F for ; Sat, 4 Nov 2023 12:01:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229487AbjKDMBC (ORCPT ); Sat, 4 Nov 2023 08:01:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229456AbjKDMBB (ORCPT ); Sat, 4 Nov 2023 08:01:01 -0400 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A9EFFB for ; Sat, 4 Nov 2023 05:00:58 -0700 (PDT) Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-9ae2cc4d17eso455310666b.1 for ; Sat, 04 Nov 2023 05:00:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1699099256; x=1699704056; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=B5Yt0+TL7qwu2OzCEiBStN1gkCqYNrb0qxd9SfM0lAY=; b=Dc/g4py5zMFuqTYWhkAY16G8xLtp8UYLqZx0vFWpSGc3zOo8MP4xVIv+Ah9rKDY3w1 EQoE7fZ/j7ZtiKkLrZNCj70ifdzDM0EJpYQJ9PIFrvQim1pcorVxYk63t7/Y5nRhX6Yx 91faJTa9tNwOCLvCMgb8D/MyVF2lLfnCwejsUk+PaQEtybxKSUoE0ARNDCwhLX7XYyc7 QDlUf4knDi6W2lx/e20JPgt8PwYg+kGoUsC+YaegvpOcVqvgFOuhXSimdJyh9dd4G2mk AHkkjC/yiAyUKyGVAdyrG3mlnKMcB2oWiDeAosTTIMkcQqNw0pj1tD5xsvzMiBM4VRmq OCSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699099256; x=1699704056; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=B5Yt0+TL7qwu2OzCEiBStN1gkCqYNrb0qxd9SfM0lAY=; b=iin5CSK0YLpHef6I/pGb3UYwcFJml2Lz5YrNnW4+1AigSyNn1VW4rKL9i02nxXTAXD knkjY43jLlRpUhrh4km0LhC3a80CXPHj6lIWNxGlEsDGsJkcpMEVJqUCXNhdyyIfkfJz 3mlutnb8hc3NSWNG63T4X1YiXyCFPrO5SgYynMpe0OHKVpNorWLGYsLndKcK3w3QiEaF vJOjN4NQNlWF/xrK5hskszOtUrTgV+fojPkTTfCrTk5DlaDSfrNK+IUpc2a/c+cM0dmX P0ZZoFnzKy7hmZC9xXheUGL6wAlWd0QjvIYyCSJOgDeFPrLY3Ywrpo2uZS4LMouD3o5h 2axw== X-Gm-Message-State: AOJu0YyyavXTWjBX//ANrB5ASidT9Mq4sAZ9gYXsY4nSgSAQ6fU20zeP Ej1olImTZEuZLe9F4u2nJemCrg== X-Google-Smtp-Source: AGHT+IEf2aG1zYzvkplVu8QxKBB5EH4uxsOMWiRATX+cU9J2QXHRp6TCbOa+4AdBleHq3fmacdjruQ== X-Received: by 2002:a17:907:6d24:b0:9c3:d356:ad0c with SMTP id sa36-20020a1709076d2400b009c3d356ad0cmr8602893ejc.24.1699099256471; Sat, 04 Nov 2023 05:00:56 -0700 (PDT) Received: from [192.168.0.153] (178235177017.dynamic-4-waw-k-1-1-0.vectranet.pl. [178.235.177.17]) by smtp.gmail.com with ESMTPSA id r1-20020a170906a20100b00997d76981e0sm1860925ejy.208.2023.11.04.05.00.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 04 Nov 2023 05:00:56 -0700 (PDT) Message-ID: Date: Sat, 4 Nov 2023 13:00:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RESEND v3 5/5] venus: pm_helpers: Use dev_pm_genpd_set_hwmode to switch GDSC mode Content-Language: en-US To: Bryan O'Donoghue , Abel Vesa , "Rafael J. Wysocki" , Kevin Hilman , Ulf Hansson , Pavel Machek , Len Brown , Greg Kroah-Hartman , Bjorn Andersson , Andy Gross , Michael Turquette , Stephen Boyd , Stanimir Varbanov , Vikash Garodia , Mauro Carvalho Chehab Cc: Taniya Das , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-media@vger.kernel.org, Jagadeesh Kona References: <20231101-gdsc-hwctrl-v3-0-0740ae6b2b04@linaro.org> <20231101-gdsc-hwctrl-v3-5-0740ae6b2b04@linaro.org> From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 11/3/23 11:44, Bryan O'Donoghue wrote: > On 01/11/2023 09:04, Abel Vesa wrote: >> From: Jagadeesh Kona >> >> This change demonstrates the use of dev_pm_genpd_set_hwmode API from >> video driver to switch the video mvs0 gdsc to SW/HW modes at runtime >> based on requirement. >> >> This change adds a new boolean array member vcodec_pmdomains_hwctrl in >> venus_resources structure to indicate if GDSC's have HW control support >> or not. This data is used in vcodec_control_v4() to check if GDSC has >> support to switch to HW control mode and then call dev_pm_genpd_set_hwmode >> to switch the GDSC mode. >> >> Before the GDSC HWCTL was available to the consumer, the venus driver >> needed to somehow keep the power from collapsing while under the driver >> control. The only way to do that was to clear the CORE_PWR_DISABLE bit >> (in wrapper POWER_CONTROL register) and, respectively, set it back after >> the driver control was completed. >> >> Now, that there is a way to switch the GDSC HW/SW control back and >> forth, the CORE_PWR_DISABLE toggling can be dropped. >> >> Signed-off-by: Jagadeesh Kona >> Signed-off-by: Abel Vesa > > So I plan to give this a test on rb5 and db410c > > My q here though is - has anybody on the submission list tested this through suspend/resume and vdd min ? I think that only chromebooks (sc7[12]80) and sc7180-acer-aspire1.dts are able to hit vddmin upstream as of today Konrad