From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B4964192EF for ; Fri, 14 Aug 2026 07:48:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786693742; cv=none; b=PI9qO/MFwo91OxF+orxmcG4kRhGEQxn9Plr4SgLJb0V/Vre/9EEouQvbe/Nq4VHGOXa3mqIKp0P6ydC0ywiwNvEhnLZmG/Is7UZvOnQi6KfOy+f7mPQEHPWcGI9MMWB2KYlrXz3SdWqUBnpffpyh9tP3Qv23O2/2ZXmaxhqc4b4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786693742; c=relaxed/simple; bh=v2/1rGY1jbTV6mnksaNbt64aVjPeYee2pckvADnDVtA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=e5Cl0ERXPiRbWe8IRQgBf9aZuaxAO+VQKVZrSLNRmAk3DujykX6TQLDXxllNyQ2vOMjPMv/TOhYpZa6U7CWfFKi+08xubn8D2olzK2+Ju5No4AKFS2c+pUHtJnj7dPLMsYFomQAhnO1XY4A+EptLqTtBv4OeAs2PXiufuAEKI7k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=cIYdhht5; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XN/SbgKS; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="cIYdhht5"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XN/SbgKS" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67E7fbFE2166396 for ; Fri, 14 Aug 2026 07:48:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 2EEdADYVf7PZDDxkAC3RN/57VZYCx8imRtEtjUOGyeU=; b=cIYdhht5ffjkWy8X HY56cQq9eoqMPrqXHrlYQ32Jr01S2EKEnWadPVUbsnx4eUmU1ktUyTcOBpumUy+K U3yg/ti81tgu2QAcbR7Cap1dG+8jlyBs4ox0LF38pRt9P0hQ02osvPFKE7lE1djx Ty7VsRW9iCy32lkVyfuQhK+F9oyJgxYV7PR2zqeBNkWTNMjqomyZdpO+fCVp53Pd 9AC4rthqt5DMmOEK77zFHoWRit8nY76Mujatu4Q23j+DKbWqXELiwRLymGT6ti3v 0gkgjUHbrZE66sd3B49h3HnyMwEsFFZe/UzdIE0TD1lHQsr1Hc8eym92IYO4uIUd PA76Nw== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g1j2njxe5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 14 Aug 2026 07:48:56 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-38e25e4b41cso801191a91.0 for ; Fri, 14 Aug 2026 00:48:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786693735; x=1787298535; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=2EEdADYVf7PZDDxkAC3RN/57VZYCx8imRtEtjUOGyeU=; b=XN/SbgKSICRL01iXY6vgpmk89zC+7ZIN+jy/iXsVSH+s2R9RlfuJuskoNrG0FXeYD3 kyE1sJT/AZg9/786SNZ0X8g1xAxwVr0f3fqNsAbG563cE6lbYD0SKo0HkR9iezJvHGkp jjgQKUOS0rsq9s6VTJPm3SNQE4e18P27cONz10CURQwptrFDCFNk8whyx0Uv0I2wMtTk tdmUdkypKkL1l64EK3fjPMTrDJG3cJSwOUmZwUYAiBY2I3ufHyS87kLAj2s8N4vDASd2 N5OUsfHiF8kU/vBfVgMGwO2ywC8qw2EPXToBDH0S5pfRg6dIleATxfNXMZuYV6KxRIN/ kPGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786693735; x=1787298535; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=2EEdADYVf7PZDDxkAC3RN/57VZYCx8imRtEtjUOGyeU=; b=lEY13tFRBu2x4xxdC18K4HqyfV96qVLw0wzV9XyX+cmb/Iqks7pBU0DP7iY0H35Koq mBXgIjWg+15ppqocQKbIsKQIpNqLCJw5jPoABT0Q43d/+rqfCcPfdSQD4MgsE4sfrw7W v+fPXcaXAEchkWSL/lx5lcZNv8x1l2j5M/csdUWooXJmXscjumrf6y+TVK3G/p2QrOq5 xTD+3B/pURtNJWpQBob5vD2Rksj2+6GyUgw476eVJrOYkhwiJdkxaxyrbnS8fUO2Y9VW b+UXw8C5uxEvuh2E+XfPm80KG/hGRhd3kYup0v2GpgKdZUWPmvY3zJ9f496U94McO7EB yoUQ== X-Forwarded-Encrypted: i=1; AHgh+RpDM/2kiNVJbLk3RcYbz5m6RE2w/jyCRMpLn8ORmyL3KOakRkD4OiQzEj81+D34tg5kvuWh9gMvyg==@vger.kernel.org X-Gm-Message-State: AOJu0Yyc98656upIpSt1gMDBylrJFZSUqqhbbsNp30S4QNJIAZf1lwNZ DFH5hZA5kfKeluvNfTECSenCvxoyr+FrVZ+t6QqK66OXfyCa2XV6t0zAtRwye/JTx38qJWW8UO/ EcoLGx7GiPXdlMeQZQsns2qP/wQVbwk3mG2EihPPHjMMpT4In7GvFgA5DHC9jd8YcvXUHow== X-Gm-Gg: AR+sD12MWtj65AdbfTANNERJRmw9eWwJvs2fnERya7mUW7AQQP8o+sr/EQU5fRqQQik 3HCBCTmFDQUAln986JAY0k2JpuoyJv9ajZBakvJUHnkkxY4y04WgCNwVIu/j5RlofDe6NW88nG/ N6q0mRts2dgJPtNbzmqYpTesxZKyZxymrrvNWIAnz7PbTsy4INfD/SkhZ8eGGtdwtHRrHuF/WYx D0DrX6sqEvoEqh5l2VijE9D7t+mS4pWp0ZDyNGIeWtBds+7qIvHyJz17YIDsmEgwPkGuwwLcXZA 5FyT+K2k/5D5C1Kk/Gox1vJDj7aVAS1qdwMr1sQHpE5Q+cPey2Cqms0bvnBoMHOwv/igUvVfsLU sdDb5jk6TBsyMBM6IREqeYxWvMUjiDbkpFaNoUvlj9XYod4JZ89rScIfsTznlDkKThmPreE/BCm a8TNMjd+H0yLE1fNMvIqU= X-Received: by 2002:a17:90b:4cc1:b0:37f:be6c:f3f2 with SMTP id 98e67ed59e1d1-3933bd0dd0fmr4662254a91.2.1786693735384; Fri, 14 Aug 2026 00:48:55 -0700 (PDT) X-Received: by 2002:a17:90b:4cc1:b0:37f:be6c:f3f2 with SMTP id 98e67ed59e1d1-3933bd0dd0fmr4662206a91.2.1786693734924; Fri, 14 Aug 2026 00:48:54 -0700 (PDT) Received: from [10.79.117.20] (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-394ebbcbb78sm1556274a91.13.2026.08.14.00.48.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Aug 2026 00:48:54 -0700 (PDT) Message-ID: Date: Fri, 14 Aug 2026 13:18:46 +0530 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 09/15] pinctrl: qcom: Add Kuno pinctrl driver To: Bartosz Golaszewski Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, Bjorn Andersson , Konrad Dybcio , Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Ulf Hansson , Michael Turquette , Stephen Boyd , Brian Masney , Taniya Das , Georgi Djakov , Linus Walleij , Thomas Gleixner , Radu Rendec , Robert Marko , Guru Das Srinagesh References: <20260809-kuno-soc-support-v1-0-5e0ede4a0c72@oss.qualcomm.com> <20260809-kuno-soc-support-v1-9-5e0ede4a0c72@oss.qualcomm.com> Content-Language: en-US From: Hardeep Sharma In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=ApXeGu9P c=1 sm=1 tr=0 ts=6a7ec868 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=S7Hclr-U69tWnHOGgbMA:9 a=QEXdDO2ut3YA:10 a=O8hF6Hzn-FEA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-ORIG-GUID: 1xmJId1y466JNnmOaMVpXoTX1LLYB6VG X-Proofpoint-Spam-Info: AW1haW4tMjYwODE0MDA1OSBTYWx0ZWRfXztYsCX4vXuS2 jHARS5JC+zTt8BPUBYa2mRM8by1KtqPoHI4IF7Vfv1f8tInZEmiH3pXBGXI4P9elVhvilUZeCuD kDSGZ8aYMvpja9PSx13WnEtj53kYjiU= X-Proofpoint-GUID: 1xmJId1y466JNnmOaMVpXoTX1LLYB6VG X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE0MDA1OSBTYWx0ZWRfXzZ4ltWtLxQZ9 4dCGmdeQJFhjTv2F+XegSvfW4Y1EcZW5T08hJS+8JWbrUec51BiAmJUSfyMF1J+nMExTILKs13Y GeFo/4WsICM+tU7+7Ko+49LYWOCjKPK6wdWKZSi/xKd+tYi6lzFCW476kzPdpGbVGnwyqcV/yIr 6rtvu0ST7wMAzZux1bYOyM9D+sKGTpDy+8iWwgF1g/is1ynOU+CK+jEMYzldB1o/HkLm8KN0V2u xrRzuFU+pZky6oFvhvr2D6FEloeopbT/UgSydsZmraXqa7x4SgkOmqpdvOemsmeqCY6qBwViwEo pRmoa4AWT5teTfHcp0IDoHuvb9JQQFFt88cCDpZ0Qbbsns+gWbQVLkA9gI1SKXv/QJY/MU9Dc0q 81u2rQlwqlK0v/L/5/kJRws9Yqq+05syuigQPcbQzRNAU+7XvzMFkFc4ObKnkfVreYbQeUeKA3v +aUQR3W1lhogHDtigvg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-14_03,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 priorityscore=1501 impostorscore=0 clxscore=1015 adultscore=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608140059 On 8/10/2026 4:33 PM, Bartosz Golaszewski wrote: > On Sun, 9 Aug 2026 09:27:08 +0200, Hardeep Sharma > said: >> Add the TLMM pinctrl driver for the Qualcomm Kuno platform, supporting >> 110 GPIOs and their pin multiplexing, pin configuration and gpiolib >> interface through the common pinctrl-msm driver. >> >> Signed-off-by: Hardeep Sharma >> --- >> + > ... > >> +static const struct pinfunction kuno_functions[] = { >> + MSM_PIN_FUNCTION(gpio), > MSM_GPIO_PIN_FUNCTION() ? Thanks for review. Done in v2 : https://lore.kernel.org/all/20260814-kuno-soc-support-v2-0-3079794f0f73@oss.qualcomm.com/ Best Wishes Hardeep Sharma > >> + MSM_PIN_FUNCTION(audio_ref_clk), >> + MSM_PIN_FUNCTION(coex_uart), >> + MSM_PIN_FUNCTION(ebi2_lcd_a), >> + MSM_PIN_FUNCTION(ebi2_lcd_cs), >> + MSM_PIN_FUNCTION(ebi2_lcd_reset), >> + MSM_PIN_FUNCTION(ebi2_lcd_te), >> + MSM_PIN_FUNCTION(emac_mdc), >> + MSM_PIN_FUNCTION(emac_mdio), >> + MSM_PIN_FUNCTION(emac_pps_in), >> + MSM_PIN_FUNCTION(emac_ptp_aux), >> + MSM_PIN_FUNCTION(emac_ptp_pps), >> + MSM_PIN_FUNCTION(gcc_gp1_clk), >> + MSM_PIN_FUNCTION(gcc_gp2_clk), >> + MSM_PIN_FUNCTION(gcc_gp3_clk), >> + MSM_PIN_FUNCTION(mi2s0_data0), >> + MSM_PIN_FUNCTION(mi2s0_data1), >> + MSM_PIN_FUNCTION(mi2s0_sck), >> + MSM_PIN_FUNCTION(mi2s0_ws), >> + MSM_PIN_FUNCTION(mi2s1_data0), >> + MSM_PIN_FUNCTION(mi2s1_data1), >> + MSM_PIN_FUNCTION(mi2s1_sck), >> + MSM_PIN_FUNCTION(mi2s1_ws), >> + MSM_PIN_FUNCTION(mi2s_mclk), >> + MSM_PIN_FUNCTION(nav_gpio), > Possibly here too? This one not required. Grepped the tree for peer TLMM drivers that expose a `nav_gpio` function: all 10 use MSM_PIN_FUNCTION(nav_gpio, ...), none use MSM_GPIO_PIN_FUNCTION. Kuno matches that convention. Best Wishes Hardeep Sharma > >> + MSM_PIN_FUNCTION(pci_e_rst), >> + MSM_PIN_FUNCTION(pcie_clkreq_n), >> + MSM_PIN_FUNCTION(pll_bist_sync), >> + MSM_PIN_FUNCTION(pll_clk_aux), >> + MSM_PIN_FUNCTION(qdss_cti_trig0), >> + MSM_PIN_FUNCTION(qdss_cti_trig1), >> + MSM_PIN_FUNCTION(qdss_gpio_traceclk), >> + MSM_PIN_FUNCTION(qdss_gpio_tracectl), >> + MSM_PIN_FUNCTION(qup0_se0), >> + MSM_PIN_FUNCTION(qup0_se1), >> + MSM_PIN_FUNCTION(qup0_se2), >> + MSM_PIN_FUNCTION(qup0_se3_mira), >> + MSM_PIN_FUNCTION(qup0_se3_mirb), >> + MSM_PIN_FUNCTION(qup0_se4), >> + MSM_PIN_FUNCTION(sdc4_clk), >> + MSM_PIN_FUNCTION(sdc4_cmd), >> + MSM_PIN_FUNCTION(sdc4_data), >> + MSM_PIN_FUNCTION(sdc4_tb_trig), >> + MSM_PIN_FUNCTION(sgmii_phy_intr), >> + MSM_PIN_FUNCTION(spmi_coex_clk), >> + MSM_PIN_FUNCTION(spmi_coex_data), >> + MSM_PIN_FUNCTION(spmi_vgi_hwevent), >> + MSM_PIN_FUNCTION(uim1_clk), >> + MSM_PIN_FUNCTION(uim1_data), >> + MSM_PIN_FUNCTION(uim1_present), >> + MSM_PIN_FUNCTION(uim1_reset), >> + MSM_PIN_FUNCTION(usb2phy_ac_en), >> +}; >> + > Bart