From: Krzysztof Kozlowski <krzk@kernel.org>
To: Dimitri Fedrau <dima.fedrau@gmail.com>
Cc: Dimitri Fedrau <dimitri.fedrau@liebherr.com>,
Sebastian Reichel <sre@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: power: supply: gpio-charger: add support for default charge current limit
Date: Fri, 13 Dec 2024 15:32:50 +0100 [thread overview]
Message-ID: <c27b7edc-b64f-44e3-b847-513dc593cb46@kernel.org> (raw)
In-Reply-To: <20241213141926.GA3920@debian>
On 13/12/2024 15:19, Dimitri Fedrau wrote:
>
>> But what I don't get is why GPIO chager needs it, since this is
>> non-configurable for GPIO charger.
>>
> With properties charge-current-limit-gpios and charge-current-limit-mapping
> one can define charge current limits in uA using up to 32 GPIOs. At the
> moment the driver defaults to smallest current limitation for safety
> reasons. When disabling charging should be possible as in the example,
> the charger defaults to non-charging. By having a default the charge
> current limit can be setup on probe and charging is enabled.
OK, the commit msg should explain the intention and real use case you
are solving here. Plus you miss the dependency - this property depends
on charge-current-limit-mapping.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-12-13 14:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-11 7:29 [PATCH 0/2] power: supply: gpio-charger: add support for default charge current limit Dimitri Fedrau via B4 Relay
2024-12-11 7:29 ` [PATCH 1/2] dt-bindings: " Dimitri Fedrau via B4 Relay
2024-12-13 11:00 ` Krzysztof Kozlowski
2024-12-13 14:19 ` Dimitri Fedrau
2024-12-13 14:32 ` Krzysztof Kozlowski [this message]
2024-12-11 7:29 ` [PATCH 2/2] " Dimitri Fedrau via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c27b7edc-b64f-44e3-b847-513dc593cb46@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dima.fedrau@gmail.com \
--cc=dimitri.fedrau@liebherr.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox