From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6808F35979 for ; Tue, 16 Sep 2025 02:40:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757990414; cv=none; b=X9q43UKVpu/E1vCVJw6KwJREl2f6L4lXGlY04OopDD4BI9aG+RV8z6KmSWNPYsfv7sPxg6q/9oV1VbZNfeeRk/4T/uD36JvU2+k7l2aKNQYRPUCtH75yHGJMKPD6P0fbM7lOkoqmY7kbGkZ17vdV3+ZUHhVPGoZP1teT+U9eKds= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757990414; c=relaxed/simple; bh=sw3T+Yf7rRxGoEHikzqSJtqsISrkBdzL4ry7W6NjCME=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=I1CUOcv/KkbBijVpjOw6ZTyEOdLB6ec0QbMgmeUXPRgmVH+BlJkmNO4bCLEBkCYgrUDlyvu+S4gb1UugrwSMkpdhYtld2+1BzQO9EnVTFsN9N6yz4VW4niiEQInc+QIBsUQFNnOtvBZWiMzh/vSAY7V/lwkQvykw29+9v1BzRuE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Pax8MzK9; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Pax8MzK9" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 58G26ktn018382 for ; Tue, 16 Sep 2025 02:40:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ALKBbxJKWhBYDEwvuuS6efzqtoWF3Q6y4KRex8tFebc=; b=Pax8MzK9tDYbi4Wi Ua6hvVsXPpOHAhwBypsMIc9+z4o6lY/oYAjB83+3hbB+EwhrKjBydKQAtUqlD/M8 eVsqnkaGkJzDxO+RjNwvZLqBHAj6rkTSL2N7BF4N3MNpXPvWGKl+z+kmmgOSP2RK 99dQKfqF/K+g7XKOMTUe+kxakNT6FGXjMoqlsMgu9iLXOvyoqtY7/uMZ88IZKoM/ uKlha3oiUB6s19t7AWs457xcN5xpTZfKY2MI9xbAFDyEylwNgYhILNcCuNnHQkNd opNG3nl8dWny9qc48KNuQeoGhTTfqThLp8b3exkw1BvCmq3mEe2/Ui3/Jv0rc25T NnbHdw== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4950u57113-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 16 Sep 2025 02:40:12 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-25d7c72e163so73078825ad.0 for ; Mon, 15 Sep 2025 19:40:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757990410; x=1758595210; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ALKBbxJKWhBYDEwvuuS6efzqtoWF3Q6y4KRex8tFebc=; b=P6Gkwdbt/kSfYajyjMU7Zt1zYq+VfxzCizgukbn6s5mPfZ6kMF1JbfE2h1Rejt+uIk joUaUOzo2xVrCe9fnYlSyqQXXsGUX/BrWd0yNnycWdM3uc07wwG8jB//JhFdMI9ONVMj JLGxGHbCs/4iQq54S27vNfPIcVe6lG1MUuCO8jAohFQjBT/oM/wcb2+ol1mve0yG/T6R lqSJURP+t4KBoGbWc0WM0BzQUfgmXv+7SEfRmFhZCFNNmBgKRwWJz+vnra/xjwJHNP49 8am5eBPnjfCtbb6GtTcmapPAhnWq4xTpkOSvk2/hk6e3/fuLGVwetUEcZEfrW162a9w1 m4CQ== X-Forwarded-Encrypted: i=1; AJvYcCX1jtFRptjOdtvFmtgwrCtOWfu//+yJA2Voz496L0y7FbzDdqG6q3dyKV9T2eyLhHYibjUnMZKdvg==@vger.kernel.org X-Gm-Message-State: AOJu0YxHZ0GEDIbk4yVtwolK8ai0B8AUpsUct+nqtJsRZTHCj5x51Hcc uZ864r2Qrol4VYGrLs1dSJCgjrAwBqHzezkGly4YoThZTDBza/0fYw+qC2aYe+WNFcaILQub7a8 1fBZ+3pcNdkYpU1G4ng/7cya8zrueo9rPCAgsfBUJ5ZZdecEK/P84JtbupT/Yfg== X-Gm-Gg: ASbGncv0CAMwru+uz/H1sSpliaMapC1Pm85T4en2R48WJrsmGzw4poQGDz9P3n/ej0N JDW592t8O0cN5eE8p8Ui/suTD4tdVyaAGtYdATijwlXVXyWPI3uvGg4BTbH2Iyp7nim5roGVVpY qgvNcVmBhhBCzyetjhKwJhTbsLQQPcMDn3GQgS6MCuWwyjCcr6t7dcdh+Nvumh4qqvsPY6JQLkd d8Yct6fYsXtgNwwg/zTFH2leHKTGS7/Bf+ziRO8qLhgHing+5YYS6bQBP77JOZurEXAyHItx9MC G1axxPTX0f0OYfUA9J+ls3b8LI1rLP5NiSSHyNhckrF+th7OS88CDq7udmK3RZSPMAVAG190pgw AkKz+oCcRKT+NplRGFGoxddO16GmVZpMW0Q== X-Received: by 2002:a17:903:1aa3:b0:246:2b29:71c7 with SMTP id d9443c01a7336-25d2607a10amr176506545ad.25.1757990409788; Mon, 15 Sep 2025 19:40:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHutrm0VahgASYcAGOWnnFZbZG2dQel55GBh/Zu5/ngeQI/Oxmg11OWKXNdJCX6YG0DD91+/A== X-Received: by 2002:a17:903:1aa3:b0:246:2b29:71c7 with SMTP id d9443c01a7336-25d2607a10amr176506265ad.25.1757990409367; Mon, 15 Sep 2025 19:40:09 -0700 (PDT) Received: from [10.133.33.240] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-25e2fb546f9sm109794985ad.127.2025.09.15.19.40.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Sep 2025 19:40:08 -0700 (PDT) Message-ID: Date: Tue, 16 Sep 2025 10:40:03 +0800 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 5/8] power: supply: qcom_battmgr: update compats for SM8550 and X1E80100 To: Dmitry Baryshkov Cc: Sebastian Reichel , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heikki Krogerus , Greg Kroah-Hartman , Bryan O'Donoghue , Konrad Dybcio , Subbaraman Narayanamurthy , David Collins , =?UTF-8?Q?Gy=C3=B6rgy_Kurucz?= , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, kernel@oss.qualcomm.com, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, Neil Armstrong References: <20250915-qcom_battmgr_update-v4-0-6f6464a41afe@oss.qualcomm.com> <20250915-qcom_battmgr_update-v4-5-6f6464a41afe@oss.qualcomm.com> Content-Language: en-US From: Fenglin Wu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: A5EdjLsDxQezHgKSeZyZzavO-_jvoZm2 X-Proofpoint-ORIG-GUID: A5EdjLsDxQezHgKSeZyZzavO-_jvoZm2 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTEzMDAzMSBTYWx0ZWRfX9f/lYYV2AvoU M4Ms/AJOb6x2oLautSDUIacf5sxxKif+zZwcP5ey0PpQUvWkMVgx1cd7jQFRMScEvHwxllXI8TJ FRU6TgtB7W/X5B1P7Jg9zjeIcVTnh1cOAKz0/XuM3gYehEWiTs9BewZTYVL86p/4f63Zlk/TOW/ aOrCgiIGsnBEs+tzld5drYRfRTIRRTTBKGt21OaQvdSV42/G5s+xOSc1sl9OolaowK5KdqIMjTB ZALf+WK8Ffhaw7uO+RK8s+F1l+TU6jUa8iYksySJhtLUlmUqlmowpCQC+sYzvjCQ9PWXF/8bSD2 /H9/7Z8tzDFrIRR4Icsn7iJpJYNS11YiO2CLfIUbatyjzC6RaB1JQ/9nVIzUImGG1pcvrlllMwT /TzW2rl8 X-Authority-Analysis: v=2.4 cv=JvzxrN4C c=1 sm=1 tr=0 ts=68c8ce0c cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=lkjHs5G_WC6zgKVeVEUA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-16_01,2025-09-12_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 suspectscore=0 clxscore=1015 impostorscore=0 spamscore=0 adultscore=0 malwarescore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2509130031 On 9/15/2025 6:19 PM, Dmitry Baryshkov wrote: > On Mon, Sep 15, 2025 at 04:49:57PM +0800, Fenglin Wu via B4 Relay wrote: >> From: Fenglin Wu >> >> Add variant definitions for SM8550 and X1E80100 platforms. Add a compat >> for SM8550 and update match data for X1E80100 specifically so that they >> could be handled differently in supporting charge control functionality. > Why? Is the question about why this was submitted as a separate patch, or about the need for the change itself? The reason for the change is explained in the commit text. As for submitting it separately, that was done to address Bryan's comments to split out the compats changes. Anyway, I will address the further comments from Stephen to make the change bisectable. > >> Tested-by: Neil Armstrong # on Thinkpad T14S OLED >> Signed-off-by: Fenglin Wu >> --- >> drivers/power/supply/qcom_battmgr.c | 7 +++++-- >> 1 file changed, 5 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/power/supply/qcom_battmgr.c b/drivers/power/supply/qcom_battmgr.c >> index 008e241e3eac3574a78459a2256e006e48c9f508..174d3f83ac2b070bb90c21a498686e91cc629ebe 100644 >> --- a/drivers/power/supply/qcom_battmgr.c >> +++ b/drivers/power/supply/qcom_battmgr.c >> @@ -19,8 +19,10 @@ >> #define BATTMGR_STRING_LEN 128 >> >> enum qcom_battmgr_variant { >> - QCOM_BATTMGR_SM8350, >> QCOM_BATTMGR_SC8280XP, >> + QCOM_BATTMGR_SM8350, >> + QCOM_BATTMGR_SM8550, >> + QCOM_BATTMGR_X1E80100, >> }; >> >> #define BATTMGR_BAT_STATUS 0x1 >> @@ -1333,7 +1335,8 @@ static void qcom_battmgr_pdr_notify(void *priv, int state) >> static const struct of_device_id qcom_battmgr_of_variants[] = { >> { .compatible = "qcom,sc8180x-pmic-glink", .data = (void *)QCOM_BATTMGR_SC8280XP }, >> { .compatible = "qcom,sc8280xp-pmic-glink", .data = (void *)QCOM_BATTMGR_SC8280XP }, >> - { .compatible = "qcom,x1e80100-pmic-glink", .data = (void *)QCOM_BATTMGR_SC8280XP }, >> + { .compatible = "qcom,sm8550-pmic-glink", .data = (void *)QCOM_BATTMGR_SM8550 }, >> + { .compatible = "qcom,x1e80100-pmic-glink", .data = (void *)QCOM_BATTMGR_X1E80100 }, >> /* Unmatched devices falls back to QCOM_BATTMGR_SM8350 */ >> {} >> }; >> >> -- >> 2.34.1 >> >>