Re: PowerOp Design and working patch

Greg KH
2006-08-07T04:17:46Z

On Sun, Aug 06, 2006 at 08:52:15PM -0700, david singleton wrote:
>
> On Aug 6, 2006, at 3:05 PM, Pavel Machek wrote:
>
> > Hi!
> >
> >>> 2) interface (kernel as well as userspace(sysfs)) for the rest of
> >>> power
> >>> parameters except cpu voltage and frequency
> >>
> >>
> >> The /sys/power/supported_states file shows the supported operating
> >> points
> >> and their parameters.
> >
> > We have one-value-per-file rule for sysfs.
>
> Yes, the supported_states file would be better off in /proc. I'll
> move it.

No, don't put non-process stuff in /proc, that's not where it belongs.

> I just put it in /sys because it was so easy.

Then use the proper interface with sysfs please.

Just listing the supported states is acceptable, there is prior-usages
like this. Just not the paramaters, this doesn't need to be
self-documented...

Or use configfs, that might be good for something like this.

thanks,

greg k-h