From: Viresh Kumar <viresh.kumar@linaro.org>
To: Rafael Wysocki <rjw@rjwysocki.net>,
Viresh Kumar <viresh.kumar@linaro.org>
Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 1/6] cpufreq: governor: Remove prints from allocation failures
Date: Wed, 18 May 2016 17:55:26 +0530 [thread overview]
Message-ID: <c67367f1c086fce0686e1ab154a9f1142e706a63.1463574213.git.viresh.kumar@linaro.org> (raw)
In-Reply-To: <cover.1463574213.git.viresh.kumar@linaro.org>
In-Reply-To: <cover.1463574213.git.viresh.kumar@linaro.org>
These aren't required anymore as the allocation core already prints such
messages. Remove the redundant ones.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
drivers/cpufreq/cpufreq_conservative.c | 4 +---
drivers/cpufreq/cpufreq_ondemand.c | 4 +---
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/cpufreq/cpufreq_conservative.c b/drivers/cpufreq/cpufreq_conservative.c
index 316df247e00d..5a15f649602c 100644
--- a/drivers/cpufreq/cpufreq_conservative.c
+++ b/drivers/cpufreq/cpufreq_conservative.c
@@ -273,10 +273,8 @@ static int cs_init(struct dbs_data *dbs_data, bool notify)
struct cs_dbs_tuners *tuners;
tuners = kzalloc(sizeof(*tuners), GFP_KERNEL);
- if (!tuners) {
- pr_err("%s: kzalloc failed\n", __func__);
+ if (!tuners)
return -ENOMEM;
- }
tuners->down_threshold = DEF_FREQUENCY_DOWN_THRESHOLD;
tuners->freq_step = DEF_FREQUENCY_STEP;
diff --git a/drivers/cpufreq/cpufreq_ondemand.c b/drivers/cpufreq/cpufreq_ondemand.c
index 300163430516..309cfeb744b2 100644
--- a/drivers/cpufreq/cpufreq_ondemand.c
+++ b/drivers/cpufreq/cpufreq_ondemand.c
@@ -368,10 +368,8 @@ static int od_init(struct dbs_data *dbs_data, bool notify)
int cpu;
tuners = kzalloc(sizeof(*tuners), GFP_KERNEL);
- if (!tuners) {
- pr_err("%s: kzalloc failed\n", __func__);
+ if (!tuners)
return -ENOMEM;
- }
cpu = get_cpu();
idle_time = get_cpu_idle_time_us(cpu, NULL);
--
2.7.1.410.g6faf27b
next prev parent reply other threads:[~2016-05-18 12:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-18 12:25 [PATCH 0/6] cpufreq: minor cleanups Viresh Kumar
2016-05-18 12:25 ` Viresh Kumar [this message]
2016-05-18 12:25 ` [PATCH 2/6] cpufreq: governor: Remove unnecessary bits from print message Viresh Kumar
2016-05-18 12:25 ` [PATCH 3/6] cpufreq: schedutil: Improve prints messages with pr_fmt Viresh Kumar
2016-05-18 12:25 ` [PATCH 4/6] cpufreq: conservative: Remove declaration of cs_dbs_gov Viresh Kumar
2016-05-18 21:03 ` Rafael J. Wysocki
2016-05-19 2:13 ` Viresh Kumar
2016-05-18 12:25 ` [PATCH 5/6] cpufreq: Reuse gov_attr_* macros in schedutil governor Viresh Kumar
2016-05-18 21:01 ` Rafael J. Wysocki
2016-05-19 2:13 ` Viresh Kumar
2016-05-19 11:43 ` Rafael J. Wysocki
2016-05-18 12:25 ` [PATCH 6/6] cpufreq: governor: Create cpufreq_policy_apply_limits() Viresh Kumar
2016-05-18 21:06 ` [PATCH 0/6] cpufreq: minor cleanups Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c67367f1c086fce0686e1ab154a9f1142e706a63.1463574213.git.viresh.kumar@linaro.org \
--to=viresh.kumar@linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).