Re: [PATCH v9,2/7] dt-bindings: thermal: Add dt-binding document for LVTS thermal controllers

Krzysztof Kozlowski
2022-09-21T06:22:17Z

On 14/09/2022 16:01, Balsam CHIHI wrote:
> Hi Angelo,
>
> I've got the following errors after implementing these changes :
> [...]
> nvmem-cells:
> minItems: 1
> description: Calibration eFuse data for LVTS
>
> nvmem-cell-names:
> minItems: 1
> items:
> pattern: 'lvts-calib-data[0-9]+$'
>
> "#thermal-sensor-cells":
> const: 1
>
> allOf:
> - $ref: thermal-sensor.yaml#
>
> - if:
> properties:
> compatible:
> contains:
> enum:
> - mediatek,mt8192-lvts-ap
> - mediatek,mt8192-lvts-mcu
> then:
> properties:
> nvmem-cells:
> maxItems: 1
>
> nvmem-cell-names:
> maxItems: 1
>
> - if:
> properties:
> compatible:
> contains:
> enum:
> - mediatek,mt8195-lvts-ap
> - mediatek,mt8195-lvts-mcu
> then:
> properties:
> nvmem-cells:
> maxItems: 2
>
> nvmem-cell-names:
> maxItems: 2
> [...]
>
> $ make DT_CHECKER_FLAGS=-m dt_binding_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml
> LINT Documentation/devicetree/bindings
> CHKDT Documentation/devicetree/bindings/processed-schema.json
> /home/balsam/src/linux-mtk-lvts-newThermalOF/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml:
> properties:nvmem-cell-names:items: {'pattern':
> 'lvts-calib-data[0-9]+$'} is not of type 'array'
> from schema $id: http://devicetree.org/meta-schemas/string-array.yaml#
> SCHEMA Documentation/devicetree/bindings/processed-schema.json
> /home/balsam/src/linux-mtk-lvts-newThermalOF/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml:
> ignoring, error in schema: properties: nvmem-cell-names: items
> DTEX Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.example.dts
> DTC Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.example.dtb
> CHECK Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.example.dtb
> Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.example.dtb:0:0:
> /example-0/soc/thermal-sensor@1100b000: failed to match any schema
> with compatible: ['mediatek,mt8192-lvts-ap']
>
> am I missing something?

Maybe maxItems: 2 in top-level property?

Best regards,
Krzysztof