Re: [PATCH v3 1/2] cpupower: Fix amd cpu (family < 0x17) active state issue

Re: [PATCH v3 1/2] cpupower: Fix amd cpu (family < 0x17) active state issue

[Shuah Khan]

On 7/23/21 12:23 AM, 徐福海 wrote:
> From: xufuhai<xufuhai1992@gmail.com>  <mailto:xufuhai@kuaishou.com>
> 
> For the old  AMD processor (family < 0x17), cpupower will call the
> amd_pci_get_num_boost_states function, but for the non-root user
> pci_read_byte function (implementation comes from the psutil library),
> val will be set to 0xff, indicating that there is no read function
> callback. At this time, the original logic will set the cpupower turbo
> active state to yes. This is an obvious issue~
> 
> Reproduce procedure:
> 	cpupower frequency-info
> 
> Reported-by:   yangrui<yangrui@kuaishou.com>  <mailto:yangrui@kuaishou.com>
> Signed-off-by: xufuhai<xufuhai1992@gmail.com>  <mailto:xufuhai@kuaishou.com>
> Signed-off-by: chenguanqiao<chenguanqiao@kuaishou.com>  <mailto:chenguanqiao@kuaishou.com>
> Signed-off-by: lishujin<lishujin@kuaishou.com>  <mailto:lishujin@kuaishou.com>

Please use your full names for the Signed-off-by - similar to the way you
would sign a legal document.

thanks,
-- Shuah