From: Lukasz Luba <lukasz.luba@arm.com>
To: Markus Elfring <Markus.Elfring@web.de>,
Bernard Zhao <bernard@vivo.com>,
linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,
linux-samsung-soc@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, opensource.kernel@vivo.com,
Krzysztof Kozlowski <krzk@kernel.org>,
Kukjin Kim <kgene@kernel.org>
Subject: Re: [PATCH v2] memory/samsung: reduce unnecessary mutex lock area
Date: Tue, 12 May 2020 12:56:49 +0100 [thread overview]
Message-ID: <c910fa00-c27b-9854-9ab2-6f37c28b87f6@arm.com> (raw)
In-Reply-To: <edf839ce-cc61-73dc-e017-b49648b94d1c@web.de>
On 5/12/20 12:40 PM, Markus Elfring wrote:
>> Maybe dmc->df->lock seems not needed to protect "if (ret)
>> & dev_warn" branch. Maybe this change speed up the code a bit.
>
> I suggest to improve also this commit message.
>
> * Please reduce uncertainty.
>
> * An imperative wording is probably preferred, isn't it?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=152036d1379ffd6985262743dcf6b0f9c75f83a4#n151
>
> * Will it be more appropriate to refer to the transformation “Reduce the lock scope”?
>
> * Would you like to add the tag “Fixes” to the change description?
>
> Regards,
> Markus
>
Thank you Markus for providing to Bernard helpful suggestions.
@Bernard please read the link above and send v3
Something like: 'memory/samsung: reduce protected code area in IRQ
handler' for the subject header would be better.
Then in the message explain (without 'maybe') that it will speed-up a
bit this IRQ processing and there is no need to protect return value or
printing.
Regards,
Lukasz
next prev parent reply other threads:[~2020-05-12 11:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 11:40 [PATCH v2] memory/samsung: reduce unnecessary mutex lock area Markus Elfring
2020-05-12 11:56 ` Lukasz Luba [this message]
2020-05-12 12:31 ` Bernard
2020-05-12 12:32 ` [v2] " Markus Elfring
2020-05-12 12:48 ` Lukasz Luba
-- strict thread matches above, loose matches on Subject: below --
2020-05-12 11:08 [PATCH v2] " Bernard Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c910fa00-c27b-9854-9ab2-6f37c28b87f6@arm.com \
--to=lukasz.luba@arm.com \
--cc=Markus.Elfring@web.de \
--cc=bernard@vivo.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=opensource.kernel@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox