From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Gustavo A. R. Silva" Subject: Re: [PATCH] devfreq: rk3399_dmc: fix error code in rk3399_dmcfreq_probe() Date: Sun, 16 Jul 2017 23:50:32 -0500 Message-ID: References: <20170630071522.GA20486@embeddedgus> <5956057D.3070704@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: myungjoo.ham@gmail.com, Chanwoo Choi Cc: Kyungmin Park , Linux PM list , LKML List-Id: linux-pm@vger.kernel.org On 07/01/2017 02:50 AM, MyungJoo Ham wrote: > On Fri, Jun 30, 2017 at 5:02 PM, Chanwoo Choi wrote: >> Hi, >> >> On 2017년 06월 30일 16:15, Gustavo A. R. Silva wrote: >>> Print and propagate the return value of platform_get_irq on failure. >>> >>> Signed-off-by: Gustavo A. R. Silva >>> --- >>> drivers/devfreq/rk3399_dmc.c | 5 +++-- >>> 1 file changed, 3 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c >>> index 40a2499..1b89ebb 100644 >>> --- a/drivers/devfreq/rk3399_dmc.c >>> +++ b/drivers/devfreq/rk3399_dmc.c >>> @@ -336,8 +336,9 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev) >>> >>> irq = platform_get_irq(pdev, 0); >>> if (irq < 0) { >>> - dev_err(&pdev->dev, "Cannot get the dmc interrupt resource\n"); >>> - return -EINVAL; >>> + dev_err(&pdev->dev, >>> + "Cannot get the dmc interrupt resource: %d\n", irq); >>> + return irq; >>> } >>> data = devm_kzalloc(dev, sizeof(struct rk3399_dmcfreq), GFP_KERNEL); >>> if (!data) >>> >> >> Reviewed-by: Chanwoo Choi > > Acked-by: MyungJoo Ham > Thank you, Chanwoo and MyungJoo. -- Gustavo A. R. Silva